* [ptxdist] [PATCH 0/2] coreutils: Menu maintenance
@ 2018-06-19 13:51 Alexander Dahl
2018-06-19 13:51 ` [ptxdist] [PATCH 1/2] coreutils: Fix missing busybox guard comments Alexander Dahl
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Alexander Dahl @ 2018-06-19 13:51 UTC (permalink / raw)
To: ptxdist
Hei hei,
I just stumbled over a vanishing menu entry without comment for the
activated busybox tool 'readlink' so I thought I check on more missing
comments. One was actually even in the wrong place.
The second patch is just unifying all the comments to one case
variant. Consider that optional, if you don't like it.
Greets
Alex
Alexander Dahl (2):
coreutils: Fix missing busybox guard comments
coreutils: Unify case in comments
rules/coreutils.in | 35 ++++++++++++++++++++++-------------
1 file changed, 22 insertions(+), 13 deletions(-)
--
2.11.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ptxdist] [PATCH 1/2] coreutils: Fix missing busybox guard comments
2018-06-19 13:51 [ptxdist] [PATCH 0/2] coreutils: Menu maintenance Alexander Dahl
@ 2018-06-19 13:51 ` Alexander Dahl
2018-06-19 13:51 ` [ptxdist] [PATCH 2/2] coreutils: Unify case in comments Alexander Dahl
2018-07-24 12:38 ` [ptxdist] [PATCH 0/2] coreutils: Menu maintenance Alexander Dahl
2 siblings, 0 replies; 5+ messages in thread
From: Alexander Dahl @ 2018-06-19 13:51 UTC (permalink / raw)
To: ptxdist
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
rules/coreutils.in | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/rules/coreutils.in b/rules/coreutils.in
index 75d897440..73cd094b0 100644
--- a/rules/coreutils.in
+++ b/rules/coreutils.in
@@ -327,6 +327,9 @@ config COREUTILS_READLINK
help
the readlink tool
+comment "busybox' readlink is selected!"
+ depends on BUSYBOX_READLINK
+
config COREUTILS_REALPATH
bool
prompt "realpath"
@@ -334,6 +337,9 @@ config COREUTILS_REALPATH
help
return the canonicalised absolute pathname
+comment "busybox' realpath is selected!"
+ depends on BUSYBOX_REALPATH
+
config COREUTILS_TAC
bool
prompt "tac"
@@ -359,6 +365,9 @@ config COREUTILS_DD
help
convert and copy a file
+comment "BusyBox' dd is selected!"
+ depends on BUSYBOX_DD
+
config COREUTILS_DF
bool
prompt "df"
@@ -366,8 +375,8 @@ config COREUTILS_DF
help
report file system disk space usage
-comment "BusyBox' dd is selected!"
- depends on COREUTILS && BUSYBOX_DD
+comment "BusyBox' df is selected!"
+ depends on BUSYBOX_DF
config COREUTILS_YES
bool
--
2.11.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ptxdist] [PATCH 2/2] coreutils: Unify case in comments
2018-06-19 13:51 [ptxdist] [PATCH 0/2] coreutils: Menu maintenance Alexander Dahl
2018-06-19 13:51 ` [ptxdist] [PATCH 1/2] coreutils: Fix missing busybox guard comments Alexander Dahl
@ 2018-06-19 13:51 ` Alexander Dahl
2018-07-24 12:38 ` [ptxdist] [PATCH 0/2] coreutils: Menu maintenance Alexander Dahl
2 siblings, 0 replies; 5+ messages in thread
From: Alexander Dahl @ 2018-06-19 13:51 UTC (permalink / raw)
To: ptxdist
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
rules/coreutils.in | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/rules/coreutils.in b/rules/coreutils.in
index 73cd094b0..19a93758f 100644
--- a/rules/coreutils.in
+++ b/rules/coreutils.in
@@ -27,7 +27,7 @@ config COREUTILS_ECHO
prompt "echo"
depends on !BUSYBOX_ECHO || ALLYES
-comment "BusyBox' echo is selected!"
+comment "busybox' echo is selected!"
depends on BUSYBOX_ECHO
config COREUTILS_STAT
@@ -35,7 +35,7 @@ config COREUTILS_STAT
prompt "stat"
depends on !BUSYBOX_STAT || ALLYES
-comment "BusyBox' stat is selected!"
+comment "busybox' stat is selected!"
depends on BUSYBOX_STAT
config COREUTILS_DATE
@@ -43,7 +43,7 @@ config COREUTILS_DATE
prompt "date"
depends on !BUSYBOX_DATE || ALLYES
-comment "BusyBox' date is selected!"
+comment "busybox' date is selected!"
depends on BUSYBOX_DATE
config COREUTILS_HOSTID
@@ -51,7 +51,7 @@ config COREUTILS_HOSTID
prompt "hostid"
depends on !BUSYBOX_HOSTID || ALLYES
-comment "BusyBox' hostid is selected!"
+comment "busybox' hostid is selected!"
depends on BUSYBOX_HOSTID
config COREUTILS_UNAME
@@ -59,7 +59,7 @@ config COREUTILS_UNAME
prompt "uname"
depends on !BUSYBOX_UNAME || ALLYES
-comment "BusyBox' uname is selected!"
+comment "busybox' uname is selected!"
depends on BUSYBOX_UNAME
config COREUTILS_DIRCOLORS
@@ -73,7 +73,7 @@ config COREUTILS_SEQ
help
print a sequence of numbers
-comment "BusyBox' seq is selected!"
+comment "busybox' seq is selected!"
depends on BUSYBOX_SEQ
config COREUTILS_NOHUP
@@ -81,7 +81,7 @@ config COREUTILS_NOHUP
prompt "nohup"
depends on !BUSYBOX_NOHUP || ALLYES
-comment "BusyBox' nohup is selected!"
+comment "busybox' nohup is selected!"
depends on BUSYBOX_NOHUP
config COREUTILS_GROUPS
@@ -89,7 +89,7 @@ config COREUTILS_GROUPS
prompt "groups"
depends on !BUSYBOX_GROUPS || ALLYES
-comment "BusyBox' groups is selected!"
+comment "busybox' groups is selected!"
depends on BUSYBOX_GROUPS
config COREUTILS_SHA224SUM
@@ -273,7 +273,7 @@ config COREUTILS_USERS
prompt "users"
depends on !BUSYBOX_USERS || ALLYES
-comment "BusyBox' users is selected!"
+comment "busybox' users is selected!"
depends on BUSYBOX_USERS
config COREUTILS_TOUCH
@@ -355,7 +355,7 @@ config COREUTILS_MD5SUM
help
compute and check MD5 message digest
-comment "BusyBox' md5sum is selected!"
+comment "busybox' md5sum is selected!"
depends on BUSYBOX_MD5SUM
config COREUTILS_DD
@@ -365,7 +365,7 @@ config COREUTILS_DD
help
convert and copy a file
-comment "BusyBox' dd is selected!"
+comment "busybox' dd is selected!"
depends on BUSYBOX_DD
config COREUTILS_DF
@@ -375,7 +375,7 @@ config COREUTILS_DF
help
report file system disk space usage
-comment "BusyBox' df is selected!"
+comment "busybox' df is selected!"
depends on BUSYBOX_DF
config COREUTILS_YES
@@ -729,7 +729,7 @@ config COREUTILS_CP
help
copy files and directories
-comment "BusyBox' cp is selected!"
+comment "busybox' cp is selected!"
depends on BUSYBOX_CP
config COREUTILS_COMM
--
2.11.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH 0/2] coreutils: Menu maintenance
2018-06-19 13:51 [ptxdist] [PATCH 0/2] coreutils: Menu maintenance Alexander Dahl
2018-06-19 13:51 ` [ptxdist] [PATCH 1/2] coreutils: Fix missing busybox guard comments Alexander Dahl
2018-06-19 13:51 ` [ptxdist] [PATCH 2/2] coreutils: Unify case in comments Alexander Dahl
@ 2018-07-24 12:38 ` Alexander Dahl
2018-07-25 13:18 ` Michael Olbrich
2 siblings, 1 reply; 5+ messages in thread
From: Alexander Dahl @ 2018-07-24 12:38 UTC (permalink / raw)
To: ptxdist
Hei hei,
Am Dienstag, 19. Juni 2018, 15:51:09 CEST schrieb Alexander Dahl:
> I just stumbled over a vanishing menu entry without comment for the
> activated busybox tool 'readlink' so I thought I check on more missing
> comments. One was actually even in the wrong place.
Maybe the commit message was not clear enough on that? Or should I split that
patch in fixing the wrong comment and adding the others?
Greets
Alex
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH 0/2] coreutils: Menu maintenance
2018-07-24 12:38 ` [ptxdist] [PATCH 0/2] coreutils: Menu maintenance Alexander Dahl
@ 2018-07-25 13:18 ` Michael Olbrich
0 siblings, 0 replies; 5+ messages in thread
From: Michael Olbrich @ 2018-07-25 13:18 UTC (permalink / raw)
To: ptxdist
Hi,
On Tue, Jul 24, 2018 at 02:38:02PM +0200, Alexander Dahl wrote:
> Am Dienstag, 19. Juni 2018, 15:51:09 CEST schrieb Alexander Dahl:
> > I just stumbled over a vanishing menu entry without comment for the
> > activated busybox tool 'readlink' so I thought I check on more missing
> > comments. One was actually even in the wrong place.
>
> Maybe the commit message was not clear enough on that? Or should I split that
> patch in fixing the wrong comment and adding the others?
It just got lost here, sorry. It's in my test queue now and should show up
in master in a few days.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-25 13:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-19 13:51 [ptxdist] [PATCH 0/2] coreutils: Menu maintenance Alexander Dahl
2018-06-19 13:51 ` [ptxdist] [PATCH 1/2] coreutils: Fix missing busybox guard comments Alexander Dahl
2018-06-19 13:51 ` [ptxdist] [PATCH 2/2] coreutils: Unify case in comments Alexander Dahl
2018-07-24 12:38 ` [ptxdist] [PATCH 0/2] coreutils: Menu maintenance Alexander Dahl
2018-07-25 13:18 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox