From: Alexander Dahl <ada@thorsis.com>
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: Re: [ptxdist] [RFC PATCH] setlocalversion: Also match non-annotated tags
Date: Fri, 07 Sep 2018 12:11:27 +0200 [thread overview]
Message-ID: <6568735.l4Ib4zdvsv@ada> (raw)
In-Reply-To: <20180907100105.nleg2qmttyahcmzm@pengutronix.de>
Hello,
Am Freitag, 7. September 2018, 12:01:05 CEST schrieb Michael Olbrich:
> On Thu, Sep 06, 2018 at 10:39:27AM +0200, Alexander Dahl wrote:
> > This fixes the case for PTXDIST_BSP_AUTOVERSION returning things like
> > ????.??.?-?-gcb7418a2299c-dirty when the last tag in the BSP was only a
> > lightweight one, no annotated tag.
>
> Nack. Using only annotated tags is a deliberate choice we made. Changing
> this would break all kinds of existing use-cases.
Okay, I'm fine with that. I will just have to remember that, when creating
tags in a BSP. Or maybe I can even make use of it.
> I think it would be ok to make this optional (opt-in) in the script. And
> then define a custom ptxd_bsp_autoversion() in your BSP to enable this.
That's why I tagged this RFC. No need to add additional complexity here.
Thanks for your answer. :-)
Greets
Alex
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2018-09-07 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 8:39 Alexander Dahl
2018-09-07 10:01 ` Michael Olbrich
2018-09-07 10:11 ` Alexander Dahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6568735.l4Ib4zdvsv@ada \
--to=ada@thorsis.com \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox