From: Alexander Dahl <ada@thorsis.com>
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: Re: [ptxdist] [PATCH 3/3] rootfs: issue: Make date string reproducible
Date: Fri, 20 Mar 2020 13:08:41 +0100 [thread overview]
Message-ID: <6473755.qs92G9q9jm@ada> (raw)
In-Reply-To: <20200320113933.GC7533@pengutronix.de>
Hello,
Am Freitag, 20. März 2020, 12:39:33 CET schrieb Michael Olbrich:
> On Thu, Feb 27, 2020 at 03:44:49PM +0100, Alexander Dahl wrote:
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
>
> Maybe use the same value as os-release?
Would make sense, I thought that's what
$(shell date --utc --date @$(SOURCE_DATE_EPOCH) '+%FT%T%z')
would yield, given SOURCE_DATE_EPOCH is always set? I used that line in both
patches.
I'm sorry, I don't understand what you mean here, or what you mean with that
question above.
Greets
Alex
> > ---
> >
> > rules/rootfs.make | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/rules/rootfs.make b/rules/rootfs.make
> > index b33805d77..6a89bfcc4 100644
> > --- a/rules/rootfs.make
> > +++ b/rules/rootfs.make
> > @@ -210,7 +210,7 @@ ifdef PTXCONF_ROOTFS_ISSUE
> >
> > @$(call install_replace, rootfs, /etc/issue, \
> >
> > @EXTRAVERSION@, $(PTXDIST_VERSION_SCM))
> >
> > @$(call install_replace, rootfs, /etc/issue, \
> >
> > - @DATE@, $(shell date +%FT%T%z))
> > + @DATE@, $(shell date --utc --date @$(SOURCE_DATE_EPOCH) '+%FT%T%z'))
> >
> > @$(call install_replace, rootfs, /etc/issue, \
> >
> > @VENDOR@, $(PTXCONF_PROJECT_VENDOR))
> >
> > @$(call install_replace, rootfs, /etc/issue, \
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2020-03-20 12:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:44 [ptxdist] [PATCH 0/3] Minor build improvements Alexander Dahl
2020-02-27 14:44 ` [ptxdist] [PATCH 1/3] opkg: Regenerate config after input variable changes Alexander Dahl
2020-03-20 11:31 ` Michael Olbrich
2020-03-27 13:24 ` Michael Olbrich
2020-02-27 14:44 ` [ptxdist] [PATCH 2/3] os-release: Make date string reproducible Alexander Dahl
2020-02-28 10:16 ` Roland Hieber
2020-02-28 15:40 ` Roland Hieber
2020-02-28 16:14 ` Alexander Dahl
2020-02-29 8:48 ` Michael Olbrich
2020-02-29 17:41 ` Alexander Dahl
2020-03-20 11:38 ` Michael Olbrich
2020-02-27 14:44 ` [ptxdist] [PATCH 3/3] rootfs: issue: " Alexander Dahl
2020-03-20 11:39 ` Michael Olbrich
2020-03-20 12:08 ` Alexander Dahl [this message]
2020-03-20 12:44 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6473755.qs92G9q9jm@ada \
--to=ada@thorsis.com \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox