From: Bastian Stender <bst@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] rauc: install rauc service wrapper script for non-systemd systems
Date: Tue, 13 Feb 2018 14:45:18 +0100 [thread overview]
Message-ID: <63ef83be-f1e1-7aca-bd9a-9ceeccaed7fd@pengutronix.de> (raw)
In-Reply-To: <50c94232-f224-15cb-fb95-562a5d81f441@pengutronix.de>
On 02/13/2018 01:00 PM, Bastian Stender wrote:
> On 02/13/2018 12:51 PM, Michael Olbrich wrote:
>> On Tue, Feb 13, 2018 at 11:22:14AM +0100, Bastian Stender wrote:
>>> This is called by dbus activation via
>>> /usr/share/dbus-1/system-services/de.pengutronix.rauc.service when
>>> systemd is not used.
>>>
>>> Signed-off-by: Bastian Stender <bst@pengutronix.de>
>>> ---
>>> rules/rauc.make | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/rules/rauc.make b/rules/rauc.make
>>> index bc3b9462a..c7879f348 100644
>>> --- a/rules/rauc.make
>>> +++ b/rules/rauc.make
>>> @@ -81,6 +81,9 @@ ifdef PTXCONF_INITMETHOD_SYSTEMD
>>> /usr/lib/systemd/system/rauc-mark-good.service)
>>> @$(call install_link, rauc, ../rauc-mark-good.service, \
>>>
>>> /usr/lib/systemd/system/multi-user.target.wants/rauc-mark-good.service)
>>> +else
>>> + @$(call install_copy, rauc, 0, 0, 0755, -, \
>>> + /usr/libexec/rauc-service.sh)
>>
>>
>> $ cat /usr/libexec/rauc-service.sh
>> #!/bin/sh
>> export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
>> /usr/local/bin/rauc service
>>
>> This cannot work.
>
> Yes, another case of host path leakage just like [1]. I will try to fix
> this in rauc and resend the patch when we do the next rauc version bump
> in ptxdist.
FTR: https://github.com/rauc/rauc/pull/228
Regards,
Bastian
--
Pengutronix e.K.
Industrial Linux Solutions
http://www.pengutronix.de/
Peiner Str. 6-8, 31137 Hildesheim, Germany
Amtsgericht Hildesheim, HRA 2686
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-02-13 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 10:22 Bastian Stender
2018-02-13 11:51 ` Michael Olbrich
2018-02-13 12:00 ` Bastian Stender
2018-02-13 13:45 ` Bastian Stender [this message]
2018-02-13 15:42 ` Enrico Joerns
2018-02-13 16:01 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ef83be-f1e1-7aca-bd9a-9ceeccaed7fd@pengutronix.de \
--to=bst@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox