Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory

[Denis Osterland-Heim <denis.osterland@diehl.com>]

Hi,

Am Montag, den 05.10.2020, 14:02 +0200 schrieb Gavin Schenk:
> Hi Denis,
>
> > Am Montag, den 05.10.2020, 13:10 +0200 schrieb Gavin Schenk:
> > > Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> > > even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
> > >
> > > On our read-only system we mount a tmpfs on directory '/media' in order
> > > to dynamically create additional mount points there.
> > >
> > > Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> >
> > Sounds like your "fix" is a change of intended behavior.
>
> what is the intended behavior of PTXCONF_ROOTFS_MEDIA besides creating a
> folder /media which is not always the case without this patch?
You are right. I got it wrong.
If ROOTFS_MEDIA is set, I would expect a /media folder as well.

Regards, Denis

>
> > I suggest to create this folder in the package,
> > in which you install your mount logic (the dynamic creation).
>
> Yes that would be a possible alternative if this patch is rejected.
>
> > This keeps the status quo for the rest of ptxdist installations,
> > where /media is not needed.
> >
>
> If /media is not needed you can just unset PTXCONF_ROOTFS_MEDIA.
> With this change the semantic equals to e.g. PTXCONF_ROOTFS_HOME, where the
> intended behaviour is creating directory /home, in my opinion.
>
> Regards
> Gavin
> Eckelmann AG
> Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
> Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
> Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
> Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
> http://www.eckelmann.de
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de