Re: [ptxdist] [PATCH] courier-unicode: this patch adds courier-unicode lib to ptxdist

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 4878 bytes --]

On 10/22/2015 04:08 PM, Oliver Graute wrote:
> The Courier Unicode Library is used by most other Courier packages, and needs
> to be installed in order to use them or build them.
> 
> This Library is needed for the maildrop package
> 
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/courier-unicode.in   |    7 ++++
>  rules/courier-unicode.make |   85 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 92 insertions(+)
>  create mode 100644 rules/courier-unicode.in
>  create mode 100644 rules/courier-unicode.make
> 
> diff --git a/rules/courier-unicode.in b/rules/courier-unicode.in
> new file mode 100644
> index 0000000..4caad08
> --- /dev/null
> +++ b/rules/courier-unicode.in
> @@ -0,0 +1,7 @@
> +## SECTION=communication
> +
> +config COURIER_UNICODE
> +	tristate
> +	prompt "courier-unicode"
> +	help
> +	  The Courier Unicode Library is used by most other Courier packages, and needs to be installed in order to use them or build them.

Please add a linebreak after ~72 coloums.

> diff --git a/rules/courier-unicode.make b/rules/courier-unicode.make
> new file mode 100644
> index 0000000..5872009
> --- /dev/null
> +++ b/rules/courier-unicode.make
> @@ -0,0 +1,85 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany, Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_COURIER_UNICODE) += courier-unicode
> +
> +#
> +# Paths and names
> +#
> +COURIER_UNICODE_VERSION	:= 1.4
> +COURIER_UNICODE_MD5		:= c1bfff8b538339cd7316c273caa4a3b7
> +COURIER_UNICODE		:= courier-unicode-$(COURIER_UNICODE_VERSION)
> +COURIER_UNICODE_SUFFIX		:= tar.bz2
> +COURIER_UNICODE_URL		:= http://downloads.sourceforge.net/project/courier/courier-unicode/$(COURIER_UNICODE_VERSION)/$(COURIER_UNICODE).$(COURIER_UNICODE_SUFFIX)

Please make use of "$(call ptx/mirror, SF, ...)" here.

> +COURIER_UNICODE_SOURCE		:= $(SRCDIR)/$(COURIER_UNICODE).$(COURIER_UNICODE_SUFFIX)
> +COURIER_UNICODE_DIR		:= $(BUILDDIR)/$(COURIER_UNICODE)
> +COURIER_UNICODE_LICENSE	:= GPLv3
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +COURIER_UNICODE_CONF_ENV	:= $(CROSS_ENV)

please remove

> +
> +#
> +# autoconf
> +#
> +COURIER_UNICODE_CONF_TOOL	:= autoconf
> +COURIER_UNICODE_CONF_OPT	:= $(CROSS_AUTOCONF_USR)

please remove CONF_OPT, as it's the default.

> +
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/courier-unicode.compile:
> +	@$(call targetinfo)
> +	@$(call world/compile, COURIER_UNICODE)
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/courier-unicode.install:
> +	@$(call targetinfo)
> +	@$(call world/install, COURIER_UNICODE)
> +	@$(call touch)

Please remove compile and install stage, as they are default.

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/courier-unicode.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, courier-unicode)
> +	@$(call install_fixup, courier-unicode,PRIORITY,optional)
> +	@$(call install_fixup, courier-unicode,SECTION,base)
> +	@$(call install_fixup, courier-unicode,AUTHOR,"<oliver.graute@neuhaus.de>")
> +	@$(call install_fixup, courier-unicode,DESCRIPTION,missing)
> +
> +	@$(call install_lib, courier-unicode, 0, 0, 0644, libcourier-unicode)
> +
> +	@$(call install_finish, courier-unicode)
> +
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Clean
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/courier-unicode.clean:
> +	@$(call targetinfo)
> +	@$(call clean_pkg, COURIER_UNICODE)

please remove the clean stage.
> +
> +# vim: syntax=make
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de