mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Christian Melki <christian.melki@t2data.com>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH]: Correct binutils spelling misstake in ptxd_make_xpkg_pkg.sh
Date: Fri, 31 Jul 2015 12:28:31 +0200	[thread overview]
Message-ID: <55BB4DCF.6050901@t2data.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

Hi.

 From binutils commitdiff 
https://sourceware.org/git/?p=binutils.git;a=commitdiff;h=45c8411440ad1fac721a9236f2fdff47792dcf1b

elf.c was changed 2012-07-01.
-               (_("%B: unable to initialize commpress status for 
section %s"),
+               (_("%B: unable to initialize compress status for section 
%s"),

Thus the subsequent test in ptxd_make_xpkg_pkg.sh fails to detect this 
condition for newer binutils.

Patch provided for the newer version. Maybe an alternative would be to 
include both cases in the string search.
Don't know why, but I hit this error with a bog standard toolchain built 
by crosstools-ng on Fedora 22. For some reason this toolchain does not 
seem to handle compressed debug sections correctly.

Regards,
Christian

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 717 bytes --]

diff --git a/scripts/lib/ptxd_make_xpkg_pkg.sh b/scripts/lib/ptxd_make_xpkg_pkg.sh
index 53d0041..0b945c5 100644
--- a/scripts/lib/ptxd_make_xpkg_pkg.sh
+++ b/scripts/lib/ptxd_make_xpkg_pkg.sh
@@ -229,7 +229,7 @@ ptxd_install_file_extract_debug() {
     # this can fail if objcopy does not support compressing debug sections or
     # is compiled without zlib support
     "${CROSS_OBJCOPY}" ${ptxd_install_file_objcopy_args} "${dir}${dst}" "${dbg}" |&
-	grep -q "\(unrecognized option\|unable to initialize commpress status\)"
+	grep -q "\(unrecognized option\|unable to initialize compress status\)"
     local -a status=( "${PIPESTATUS[@]}" )
     if [ ${status[0]} -ne 0 ]; then
 	if [ ${status[1]} -eq 0 ]; then

[-- Attachment #3: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

                 reply	other threads:[~2015-07-31  8:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BB4DCF.6050901@t2data.com \
    --to=christian.melki@t2data.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox