[ptxdist] [PATCH] ptxd_install_toolchain_lib: fix "strip" option handling

[ptxdist] [PATCH] ptxd_install_toolchain_lib: fix "strip" option handling

[Albert Antony]

The option was not being passed onward, which meant that
the "strip" parameter passed to install_copy_toolchain_lib
was getting ignored.
---
 scripts/install_copy_toolchain.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/install_copy_toolchain.sh b/scripts/install_copy_toolchain.sh
index 0cf4d31..0b70c12 100755
--- a/scripts/install_copy_toolchain.sh
+++ b/scripts/install_copy_toolchain.sh
@@ -170,7 +170,7 @@ ptxd_install_toolchain_lib() {
 
 		perm="$(stat -c %a "${lib_path}")"
 
-		echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${perm}\"" >> "${STATEDIR}/${packet}.cmds"
+		echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${perm}\" \"${strip}\"" >> "${STATEDIR}/${packet}.cmds"
 	    fi
 	else
 	    echo "error: found ${lib_path}, but neither file nor link" 2>&1
-- 
2.0.0


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_install_toolchain_lib: fix "strip" option handling

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 1432 bytes --]

On 07/20/2015 05:11 PM, Albert Antony wrote:
> The option was not being passed onward, which meant that
> the "strip" parameter passed to install_copy_toolchain_lib
> was getting ignored.
> ---
>  scripts/install_copy_toolchain.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/install_copy_toolchain.sh b/scripts/install_copy_toolchain.sh
> index 0cf4d31..0b70c12 100755
> --- a/scripts/install_copy_toolchain.sh
> +++ b/scripts/install_copy_toolchain.sh
> @@ -170,7 +170,7 @@ ptxd_install_toolchain_lib() {
>  
>  		perm="$(stat -c %a "${lib_path}")"
>  
> -		echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${perm}\"" >> "${STATEDIR}/${packet}.cmds"
> +		echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${perm}\" \"${strip}\"" >> "${STATEDIR}/${packet}.cmds"

What difference does it make?

ptxd_install_shared() {
    local src="$1"
    local dst="$2"
    local usr="$3"
    local grp="$4"
    local mod="$5"
    local filename="$(basename "${src}")"


>  	    fi
>  	else
>  	    echo "error: found ${lib_path}, but neither file nor link" 2>&1
> 

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_install_toolchain_lib: fix "strip" option handling

[Albert Antony]

[-- Attachment #1.1: Type: text/plain, Size: 1763 bytes --]

Sincere apologies for missing that. I'll send along a patch that addresses
the "strip" option for library installation in general. Let's abandon this
patch.

Cheers,
Albert.


On 20 July 2015 at 17:18, Marc Kleine-Budde <mkl@pengutronix.de> wrote:

> On 07/20/2015 05:11 PM, Albert Antony wrote:
> > The option was not being passed onward, which meant that
> > the "strip" parameter passed to install_copy_toolchain_lib
> > was getting ignored.
> > ---
> >  scripts/install_copy_toolchain.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/install_copy_toolchain.sh
> b/scripts/install_copy_toolchain.sh
> > index 0cf4d31..0b70c12 100755
> > --- a/scripts/install_copy_toolchain.sh
> > +++ b/scripts/install_copy_toolchain.sh
> > @@ -170,7 +170,7 @@ ptxd_install_toolchain_lib() {
> >
> >               perm="$(stat -c %a "${lib_path}")"
> >
> > -             echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0
> 0 \"${perm}\"" >> "${STATEDIR}/${packet}.cmds"
> > +             echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0
> 0 \"${perm}\" \"${strip}\"" >> "${STATEDIR}/${packet}.cmds"
>
> What difference does it make?
>
> ptxd_install_shared() {
>     local src="$1"
>     local dst="$2"
>     local usr="$3"
>     local grp="$4"
>     local mod="$5"
>     local filename="$(basename "${src}")"
>
>
> >           fi
> >       else
> >           echo "error: found ${lib_path}, but neither file nor link" 2>&1
> >
>
> Marc
> --
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
>
>

[-- Attachment #1.2: Type: text/html, Size: 2969 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de