From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
References: <1437405096-13826-1-git-send-email-albert@newtec.dk>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Message-ID: <55AD1139.4010001@pengutronix.de>
Date: Mon, 20 Jul 2015 17:18:17 +0200
MIME-Version: 1.0
In-Reply-To: <1437405096-13826-1-git-send-email-albert@newtec.dk>
Subject: Re: [ptxdist] [PATCH] ptxd_install_toolchain_lib: fix "strip"
 option handling
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: multipart/mixed; boundary="===============0063774556=="
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Albert Antony <albert@newtec.dk>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============0063774556==
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="eDhitVos4mcpmEpOJrrkwo71QeVK9h7Cg"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--eDhitVos4mcpmEpOJrrkwo71QeVK9h7Cg
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 07/20/2015 05:11 PM, Albert Antony wrote:
> The option was not being passed onward, which meant that
> the "strip" parameter passed to install_copy_toolchain_lib
> was getting ignored.
> ---
>  scripts/install_copy_toolchain.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/scripts/install_copy_toolchain.sh b/scripts/install_copy_t=
oolchain.sh
> index 0cf4d31..0b70c12 100755
> --- a/scripts/install_copy_toolchain.sh
> +++ b/scripts/install_copy_toolchain.sh
> @@ -170,7 +170,7 @@ ptxd_install_toolchain_lib() {
> =20
>  		perm=3D"$(stat -c %a "${lib_path}")"
> =20
> -		echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${perm=
}\"" >> "${STATEDIR}/${packet}.cmds"
> +		echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${perm=
}\" \"${strip}\"" >> "${STATEDIR}/${packet}.cmds"

What difference does it make?

ptxd_install_shared() {
    local src=3D"$1"
    local dst=3D"$2"
    local usr=3D"$3"
    local grp=3D"$4"
    local mod=3D"$5"
    local filename=3D"$(basename "${src}")"


>  	    fi
>  	else
>  	    echo "error: found ${lib_path}, but neither file nor link" 2>&1
>=20

Marc
--=20
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


--eDhitVos4mcpmEpOJrrkwo71QeVK9h7Cg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJVrRE5AAoJEP5prqPJtc/HwpUH+QEryQ2JwFCsuu27JPplcl2j
xY3FzlX2n/Wji8YsJnlR9RogyNGFk6TbOZENP2bnKKnXgILGQu39bpUGjzS6Z4yc
MzQa7CK/8ltQjX9HmMjMXBUqQmZoCv+9/ffMuZ8YFY9C61MHm0mS7hE4PrZZrnXW
KvZXuBb6oYDNDzHBOuN8T7MjyFAEDENsTiHAJHkow8Y1HmWd/kfipMoHcd0c/PTw
6qMYMsWPxepwuTcq1q16aH86CxVs8bv4qaSUL4wkc/mbhJAhNxj8jdhwi+6vNGsR
fv9CLVAlWROWpe5g6QSUFdYcuZhFy0Srpiq/r120FOUIozn5VTy4J0wJWtGZuCI=
=3cd8
-----END PGP SIGNATURE-----

--eDhitVos4mcpmEpOJrrkwo71QeVK9h7Cg--


--===============0063774556==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

LS0gCnB0eGRpc3QgbWFpbGluZyBsaXN0CnB0eGRpc3RAcGVuZ3V0cm9uaXguZGUK

--===============0063774556==--