From: Marc Kleine-Budde <mkl@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Albert Antony <albert@newtec.dk>
Subject: Re: [ptxdist] [PATCH] ptxd_install_toolchain_lib: fix "strip" option handling
Date: Mon, 20 Jul 2015 17:18:17 +0200 [thread overview]
Message-ID: <55AD1139.4010001@pengutronix.de> (raw)
In-Reply-To: <1437405096-13826-1-git-send-email-albert@newtec.dk>
[-- Attachment #1.1: Type: text/plain, Size: 1432 bytes --]
On 07/20/2015 05:11 PM, Albert Antony wrote:
> The option was not being passed onward, which meant that
> the "strip" parameter passed to install_copy_toolchain_lib
> was getting ignored.
> ---
> scripts/install_copy_toolchain.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/install_copy_toolchain.sh b/scripts/install_copy_toolchain.sh
> index 0cf4d31..0b70c12 100755
> --- a/scripts/install_copy_toolchain.sh
> +++ b/scripts/install_copy_toolchain.sh
> @@ -170,7 +170,7 @@ ptxd_install_toolchain_lib() {
>
> perm="$(stat -c %a "${lib_path}")"
>
> - echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${perm}\"" >> "${STATEDIR}/${packet}.cmds"
> + echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${perm}\" \"${strip}\"" >> "${STATEDIR}/${packet}.cmds"
What difference does it make?
ptxd_install_shared() {
local src="$1"
local dst="$2"
local usr="$3"
local grp="$4"
local mod="$5"
local filename="$(basename "${src}")"
> fi
> else
> echo "error: found ${lib_path}, but neither file nor link" 2>&1
>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
[-- Attachment #2: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2015-07-20 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 15:11 Albert Antony
2015-07-20 15:18 ` Marc Kleine-Budde [this message]
2015-07-21 10:06 ` Albert Antony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD1139.4010001@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=albert@newtec.dk \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox