[ptxdist] [PATCHv1 1/1] quagga: this patch adds quagga support to ptxdist

[ptxdist] [PATCHv1 1/1] quagga: this patch adds quagga support to ptxdist

[Oliver Graute]

Quagga is a routing software suite

Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
---
 rules/quagga.in   |   12 ++++++++
 rules/quagga.make |   84 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 96 insertions(+)
 create mode 100644 rules/quagga.in
 create mode 100644 rules/quagga.make

diff --git a/rules/quagga.in b/rules/quagga.in
new file mode 100644
index 0000000..fe84454
--- /dev/null
+++ b/rules/quagga.in
@@ -0,0 +1,12 @@
+## SECTION=networking
+
+config QUAGGA
+	tristate
+	prompt "quagga"
+	help
+	  Quagga Routing Suite. Quagga is a routing software suite, providing
+	  implementations of OSPFv2, OSPFv3, RIP v1 and v2, RIPng and BGP-4
+	  for Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD.
+	  Quagga is a fork of GNU Zebra which was developed by Kunihiro
+	  Ishiguro. The Quagga tree aims to build a more involved community
+	  around Quagga than the current centralised model of GNU Zebra.
diff --git a/rules/quagga.make b/rules/quagga.make
new file mode 100644
index 0000000..0665d66
--- /dev/null
+++ b/rules/quagga.make
@@ -0,0 +1,84 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany, Oliver Graute <oliver.graute@neuhaus.de>
+#
+# See CREDITS for details about who has contributed to this project.
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+#
+# We provide this package
+#
+PACKAGES-$(PTXCONF_QUAGGA) += quagga
+
+#
+# Paths and names
+#
+QUAGGA_VERSION	:= 0.99.23
+QUAGGA_MD5		:= d17145e62b6ea14f0f13bb63f59e5166
+QUAGGA		:= quagga-$(QUAGGA_VERSION)
+QUAGGA_SUFFIX	:= tar.gz
+QUAGGA_URL		:= http://download.savannah.gnu.org/releases/quagga/$(QUAGGA).$(QUAGGA_SUFFIX)
+QUAGGA_SOURCE	:= $(SRCDIR)/$(QUAGGA).$(QUAGGA_SUFFIX)
+QUAGGA_DIR		:= $(BUILDDIR)/$(QUAGGA)
+QUAGGA_LICENSE	:= GPLv2
+
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+QUAGGA_CONF_ENV	:= $(CROSS_ENV)
+
+#
+# autoconf
+#
+QUAGGA_CONF_TOOL	:= autoconf
+
+# ----------------------------------------------------------------------------
+# Compile
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/quagga.compile:
+	@$(call targetinfo)
+	@$(call world/compile, QUAGGA)
+	@$(call touch)
+
+# ----------------------------------------------------------------------------
+# Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/quagga.install:
+	@$(call targetinfo)
+	@$(call world/install, QUAGGA)
+	@$(call touch)
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/quagga.targetinstall:
+	@$(call targetinfo)
+
+	@$(call install_init, quagga)
+	@$(call install_fixup, quagga,PRIORITY,optional)
+	@$(call install_fixup, quagga,SECTION,base)
+	@$(call install_fixup, quagga,AUTHOR,"<oliver.graute@neuhaus.de>")
+	@$(call install_fixup, quagga,DESCRIPTION,missing)
+
+	@$(call install_lib, quagga, 0, 0, 0644, libzebra)
+	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ripd)
+	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/zebra)
+	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ospfd)
+	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ospfclient)
+	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ospf6d)
+	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/watchquagga)
+	@$(call install_copy, quagga, 0, 0, 0644, -, /etc/ripd.conf.sample)
+	@$(call install_copy, quagga, 0, 0, 0644, -, /etc/zebra.conf.sample)
+	@$(call install_finish, quagga)
+
+	@$(call touch)
+
+# vim: syntax=make
-- 
1.7.9.5


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCHv1 1/1] quagga: this patch adds quagga support to ptxdist

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 4967 bytes --]

On 04/01/2015 04:30 PM, Oliver Graute wrote:
> Quagga is a routing software suite

builds here.

Please fix:
- remove default CONF_ENV
- remove default stages: compile, install
- the install_alternative for the config files is a good idea,
  however /etc/*.sample is probably not used by quagga.
  Please provide a set of config files as /etc/* (without .sample) in
  this patch. I'm not sure if this a sensible option, beacuse quagga
  probsably supports a lot of routing deamon which need different files.

> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/quagga.in   |   12 ++++++++
>  rules/quagga.make |   84 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 96 insertions(+)
>  create mode 100644 rules/quagga.in
>  create mode 100644 rules/quagga.make
> 
> diff --git a/rules/quagga.in b/rules/quagga.in
> new file mode 100644
> index 0000000..fe84454
> --- /dev/null
> +++ b/rules/quagga.in
> @@ -0,0 +1,12 @@
> +## SECTION=networking
> +
> +config QUAGGA
> +	tristate
> +	prompt "quagga"
> +	help
> +	  Quagga Routing Suite. Quagga is a routing software suite, providing
> +	  implementations of OSPFv2, OSPFv3, RIP v1 and v2, RIPng and BGP-4
> +	  for Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD.
> +	  Quagga is a fork of GNU Zebra which was developed by Kunihiro
> +	  Ishiguro. The Quagga tree aims to build a more involved community
> +	  around Quagga than the current centralised model of GNU Zebra.
> diff --git a/rules/quagga.make b/rules/quagga.make
> new file mode 100644
> index 0000000..0665d66
> --- /dev/null
> +++ b/rules/quagga.make
> @@ -0,0 +1,84 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany, Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_QUAGGA) += quagga
> +
> +#
> +# Paths and names
> +#
> +QUAGGA_VERSION	:= 0.99.23
> +QUAGGA_MD5		:= d17145e62b6ea14f0f13bb63f59e5166
> +QUAGGA		:= quagga-$(QUAGGA_VERSION)
> +QUAGGA_SUFFIX	:= tar.gz
> +QUAGGA_URL		:= http://download.savannah.gnu.org/releases/quagga/$(QUAGGA).$(QUAGGA_SUFFIX)
> +QUAGGA_SOURCE	:= $(SRCDIR)/$(QUAGGA).$(QUAGGA_SUFFIX)
> +QUAGGA_DIR		:= $(BUILDDIR)/$(QUAGGA)
> +QUAGGA_LICENSE	:= GPLv2
> +
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +QUAGGA_CONF_ENV	:= $(CROSS_ENV)
> +
> +#
> +# autoconf
> +#
> +QUAGGA_CONF_TOOL	:= autoconf
> +
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/quagga.compile:
> +	@$(call targetinfo)
> +	@$(call world/compile, QUAGGA)
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/quagga.install:
> +	@$(call targetinfo)
> +	@$(call world/install, QUAGGA)
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/quagga.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, quagga)
> +	@$(call install_fixup, quagga,PRIORITY,optional)
> +	@$(call install_fixup, quagga,SECTION,base)
> +	@$(call install_fixup, quagga,AUTHOR,"<oliver.graute@neuhaus.de>")
> +	@$(call install_fixup, quagga,DESCRIPTION,missing)
> +
> +	@$(call install_lib, quagga, 0, 0, 0644, libzebra)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ripd)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/zebra)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ospfd)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ospfclient)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ospf6d)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/watchquagga)
> +	@$(call install_copy, quagga, 0, 0, 0644, -, /etc/ripd.conf.sample)
> +	@$(call install_copy, quagga, 0, 0, 0644, -, /etc/zebra.conf.sample)
> +	@$(call install_finish, quagga)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] Antwort: Re: [PATCHv1 1/1] quagga: this patch adds quagga support to ptxdist

[Oliver.Graute]

[-- Attachment #1.1.1: Type: text/plain, Size: 732 bytes --]


> builds here.
>
> Please fix:
> - remove default CONF_ENV
> - remove default stages: compile, install
> - the install_alternative for the config files is a good idea,
>   however /etc/*.sample is probably not used by quagga.
>   Please provide a set of config files as /etc/* (without .sample) in
>   this patch. I'm not sure if this a sensible option, beacuse quagga
>   probsably supports a lot of routing deamon which need different files.

> > +   @$(call install_copy, quagga, 0, 0, 0644, -, /etc/ripd.conf.sample)
> > +   @$(call install_copy, quagga, 0, 0, 0644,
-, /etc/zebra.conf.sample)

should I remove these install copy lines completly? because if i only
remove
.sample install_copy would fail.

Best regards,

Oliver

[-- Attachment #1.1.2: Type: text/html, Size: 966 bytes --]

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2446 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Antwort: Re: [PATCHv1 1/1] quagga: this patch adds quagga support to ptxdist

[Robert Schwebel]

On Wed, Apr 08, 2015 at 04:29:22PM +0200, Oliver.Graute@neuhaus.de wrote:
> 
> > builds here.
> >
> > Please fix:
> > - remove default CONF_ENV
> > - remove default stages: compile, install
> > - the install_alternative for the config files is a good idea,
> >   however /etc/*.sample is probably not used by quagga.
> >   Please provide a set of config files as /etc/* (without .sample) in
> >   this patch. I'm not sure if this a sensible option, beacuse quagga
> >   probsably supports a lot of routing deamon which need different files.
> 
> > > +   @$(call install_copy, quagga, 0, 0, 0644, -, /etc/ripd.conf.sample)
> > > +   @$(call install_copy, quagga, 0, 0, 0644, -, /etc/zebra.conf.sample)
> 
> should I remove these install copy lines completly? because if i only remove
> .sample install_copy would fail.

As Marc said: if you provide a set of config files as /etc/* (without
.sample), install_copy won't fail if you remove the .sample from the
paths.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de