mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Oliver Graute <oliver.graute@neuhaus.de>
Subject: Re: [ptxdist] [PATCHv1 1/1] quagga: this patch adds quagga support to ptxdist
Date: Thu, 02 Apr 2015 11:31:29 +0200	[thread overview]
Message-ID: <551D0C71.7040402@pengutronix.de> (raw)
In-Reply-To: <1427898644-7511-1-git-send-email-oliver.graute@neuhaus.de>


[-- Attachment #1.1: Type: text/plain, Size: 4967 bytes --]

On 04/01/2015 04:30 PM, Oliver Graute wrote:
> Quagga is a routing software suite

builds here.

Please fix:
- remove default CONF_ENV
- remove default stages: compile, install
- the install_alternative for the config files is a good idea,
  however /etc/*.sample is probably not used by quagga.
  Please provide a set of config files as /etc/* (without .sample) in
  this patch. I'm not sure if this a sensible option, beacuse quagga
  probsably supports a lot of routing deamon which need different files.

> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/quagga.in   |   12 ++++++++
>  rules/quagga.make |   84 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 96 insertions(+)
>  create mode 100644 rules/quagga.in
>  create mode 100644 rules/quagga.make
> 
> diff --git a/rules/quagga.in b/rules/quagga.in
> new file mode 100644
> index 0000000..fe84454
> --- /dev/null
> +++ b/rules/quagga.in
> @@ -0,0 +1,12 @@
> +## SECTION=networking
> +
> +config QUAGGA
> +	tristate
> +	prompt "quagga"
> +	help
> +	  Quagga Routing Suite. Quagga is a routing software suite, providing
> +	  implementations of OSPFv2, OSPFv3, RIP v1 and v2, RIPng and BGP-4
> +	  for Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD.
> +	  Quagga is a fork of GNU Zebra which was developed by Kunihiro
> +	  Ishiguro. The Quagga tree aims to build a more involved community
> +	  around Quagga than the current centralised model of GNU Zebra.
> diff --git a/rules/quagga.make b/rules/quagga.make
> new file mode 100644
> index 0000000..0665d66
> --- /dev/null
> +++ b/rules/quagga.make
> @@ -0,0 +1,84 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany, Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_QUAGGA) += quagga
> +
> +#
> +# Paths and names
> +#
> +QUAGGA_VERSION	:= 0.99.23
> +QUAGGA_MD5		:= d17145e62b6ea14f0f13bb63f59e5166
> +QUAGGA		:= quagga-$(QUAGGA_VERSION)
> +QUAGGA_SUFFIX	:= tar.gz
> +QUAGGA_URL		:= http://download.savannah.gnu.org/releases/quagga/$(QUAGGA).$(QUAGGA_SUFFIX)
> +QUAGGA_SOURCE	:= $(SRCDIR)/$(QUAGGA).$(QUAGGA_SUFFIX)
> +QUAGGA_DIR		:= $(BUILDDIR)/$(QUAGGA)
> +QUAGGA_LICENSE	:= GPLv2
> +
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +QUAGGA_CONF_ENV	:= $(CROSS_ENV)
> +
> +#
> +# autoconf
> +#
> +QUAGGA_CONF_TOOL	:= autoconf
> +
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/quagga.compile:
> +	@$(call targetinfo)
> +	@$(call world/compile, QUAGGA)
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/quagga.install:
> +	@$(call targetinfo)
> +	@$(call world/install, QUAGGA)
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/quagga.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, quagga)
> +	@$(call install_fixup, quagga,PRIORITY,optional)
> +	@$(call install_fixup, quagga,SECTION,base)
> +	@$(call install_fixup, quagga,AUTHOR,"<oliver.graute@neuhaus.de>")
> +	@$(call install_fixup, quagga,DESCRIPTION,missing)
> +
> +	@$(call install_lib, quagga, 0, 0, 0644, libzebra)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ripd)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/zebra)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ospfd)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ospfclient)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/ospf6d)
> +	@$(call install_copy, quagga, 0, 0, 0755, -, /usr/sbin/watchquagga)
> +	@$(call install_copy, quagga, 0, 0, 0644, -, /etc/ripd.conf.sample)
> +	@$(call install_copy, quagga, 0, 0, 0644, -, /etc/zebra.conf.sample)
> +	@$(call install_finish, quagga)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2015-04-02  9:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 14:30 Oliver Graute
2015-04-02  9:31 ` Marc Kleine-Budde [this message]
2015-04-08 14:29   ` [ptxdist] Antwort: " Oliver.Graute
2015-04-08 15:33     ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551D0C71.7040402@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=oliver.graute@neuhaus.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox