From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <551AD44D.4060303@pengutronix.de> Date: Tue, 31 Mar 2015 19:07:25 +0200 From: Marc Kleine-Budde MIME-Version: 1.0 References: <1427809891-28026-1-git-send-email-oliver.graute@neuhaus.de> In-Reply-To: <1427809891-28026-1-git-send-email-oliver.graute@neuhaus.de> Subject: Re: [ptxdist] [PATCHv2] dhcp-helper: this patch adds dhcp-helper to ptxdist Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1126816854==" Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Cc: Oliver Graute This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1126816854== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jWbqFJoPTbCqk8iOc40QCT4Rdx3ataefB" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jWbqFJoPTbCqk8iOc40QCT4Rdx3ataefB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/31/2015 03:51 PM, Oliver Graute wrote: > This patch adds dhcp-helper a DHCP and BOOTP relay agent to ptxdist >=20 > Signed-off-by: Oliver Graute > --- > rules/dhcp-helper.in | 12 ++++++++++ > rules/dhcp-helper.make | 61 ++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 73 insertions(+) > create mode 100644 rules/dhcp-helper.in > create mode 100644 rules/dhcp-helper.make >=20 > diff --git a/rules/dhcp-helper.in b/rules/dhcp-helper.in > new file mode 100644 > index 0000000..b55755b > --- /dev/null > +++ b/rules/dhcp-helper.in > @@ -0,0 +1,12 @@ > +## SECTION=3Dnetworking > + > +config DHCP_HELPER > + tristate > + prompt "dhcp-helper" > + help > + dhcp-helper is a DHCP and BOOTP relay agent. It listens for DHCP and= > + BOOTP broadcasts on directly connected subnets and relays them to DH= CP > + or BOOTP servers elsewhere. It also relays replies from the remote > + servers back to partially configured hosts. Once hosts are fully > + configured they can communicate directly with their servers and no > + longer need the services of a relay. > diff --git a/rules/dhcp-helper.make b/rules/dhcp-helper.make > new file mode 100644 > index 0000000..fa01e4a > --- /dev/null > +++ b/rules/dhcp-helper.make > @@ -0,0 +1,60 @@ > +# -*-makefile-*- > +# > +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germa= ny, Oliver Graute > +# > +# See CREDITS for details about who has contributed to this project. > +# > +# For further information about the PTXdist project and license condit= ions > +# see the README file. > +# > + > +# > +# We provide this package > +# > +PACKAGES-$(PTXCONF_DHCP_HELPER) +=3D dhcp-helper > + > +# > +# Paths and names > +# > +DHCP_HELPER_VERSION :=3D 1.1 > +DHCP_HELPER_MD5 :=3D 049cc2138f151235903d2303a57f8203 ptxdist: error: Wrong md5sum for 'dhcp-helper' (src/dhcp-helper-1.1.tar.g= z) > +DHCP_HELPER :=3D dhcp-helper-$(DHCP_HELPER_VERSION) > +DHCP_HELPER_SUFFIX :=3D tar.gz > +DHCP_HELPER_URL :=3D http://www.thekelleys.org.uk/dhcp-helper/$(DHCP_= HELPER).$(DHCP_HELPER_SUFFIX) > +DHCP_HELPER_SOURCE :=3D $(SRCDIR)/$(DHCP_HELPER).$(DHCP_HELPER_SUFFIX)= > +DHCP_HELPER_DIR :=3D $(BUILDDIR)/$(DHCP_HELPER) > +DHCP_HELPER_LICENSE :=3D GPLv2 > + Please add the usual prepare header here > +DHCP_HELPER_CONF_ENV :=3D $(CROSS_ENV) please remove, as this is default > + > +DHCP_HELPER_CONF_OPT :=3D $(CROSS_AUTOCONF_USR) I see no configure script in the sources, so _CONF_TOOL :=3D NO would be the right option here. Are you sure the package is properly cross compiled? I think you have to add a COMPILE_OPT :=3D CROSS_COMPILE=3D$(COMPILER_PREFIX) PREFIX=3D/usr, = as in the opennhrp package. Further, consider to add a INSTALL_OPT :=3D $(COMPILE_OPT) install. This way the install stage of the package will do the right thing and you can use the standard "-" trick in the targetinstall stage (see below) > + > +# --------------------------------------------------------------------= -------- > +# Compile > +# --------------------------------------------------------------------= -------- > + > +$(STATEDIR)/dhcp-helper.compile: > + @$(call targetinfo) > + @$(call world/compile, DHCP_HELPER) > + @$(call touch ptxdist/ptxdist/rules/dhcp-helper.make:37: *** unterminated call to function 'call': missing ')'. Stop. Please test the rules before sending patches. > + > +# --------------------------------------------------------------------= -------- > +# Target-Install > +# --------------------------------------------------------------------= -------- > + > +$(STATEDIR)/dhcp-helper.targetinstall: > + @$(call targetinfo) > + > + @$(call install_init, dhcp-helper) > + @$(call install_fixup, dhcp-helper,PRIORITY,optional) > + @$(call install_fixup, dhcp-helper,SECTION,base) > + @$(call install_fixup, dhcp-helper,AUTHOR,"= ") > + @$(call install_fixup, dhcp-helper,DESCRIPTION,missing) > + > + @$(call install_copy, dhcp-helper, 0, 0, 0755, $(DHCP_HELPER_DIR)/dhc= p-helper, /usr/bin/dhcp-helper) The package itself installs into _s_bin, you might follow this suggestion. With the INSTALL_OPT as noted, this should work: @$(call install_copy, dhcp-helper, 0, 0, 0755, -, /usr/sbin/dhcp-helper) > + > + @$(call install_finish, dhcp-helper) > + > + @$(call touch) > + > +# vim: syntax=3Dmake >=20 Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --jWbqFJoPTbCqk8iOc40QCT4Rdx3ataefB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJVGtRQAAoJECte4hHFiupU0SAP/0JvzqDB7dV7NcomydU/Jn5w DXf3zomj+eBUvD+Kd54o1xP4o4FmmmRueoBAj3RaR9WwhR84dFKQ4N5EPa3SGhuO 6xhH2wzW+xgQ2P39pXSdsyPfptw7VkJ+531LKH7zkIjDdK5aqvafXiEn84TQIkmo 7Tp7/42qJ/0EMN8Xa4J/JsGcSaNz/pIMtgj/hspuvlDmfHQvtzjo6oMIkGARuL8m 65bfwLKGaHu4SEofqUw6oZuVj5Pw6gari10jGFJUKa6BjAct1QdYxbbqUAtd6T/a rODqTEiKfanTULxLQwt2YKn3TMD0cIchw4HxkVlqOoxTD2Nccvp6XupNYmwkW4EQ 68FBHCN78QUWsdxPUA7wEPOY2xJMpQM1QS2OA6327z3ZNn8Y+3XhXsXwOBls/Swz y5RzAn87cSZ6mjbz0/GH4iers6hRb19M6+t7/9unUzUKkr0W2oHxr2p+7E2c8euT glqn2svjkm4tzyS0xaHIh201KAYKk2MZ/wk45m1Z1YuPSlBIMAFe5/8HMfh9u9tF juXsgl3jlemtUtcUQvW9u6p6/WAr7+CKrOS92ywRl8H4vJZxx1LahVasUdRw5KiS ro34mJCqK05LirsC4Y4HLF5+8wp3TJJEQQ1zjF8dqyPSWVs9iqZ3HvwToqc8jCm6 Viue4cEj6M1jBVXJjmTk =hR5s -----END PGP SIGNATURE----- --jWbqFJoPTbCqk8iOc40QCT4Rdx3ataefB-- --===============1126816854== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- ptxdist mailing list ptxdist@pengutronix.de --===============1126816854==--