mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Denis OSTERLAND-HEIM <denis.osterland@diehl.com>
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>,
	 "christian.melki@t2data.com" <christian.melki@t2data.com>
Subject: Re: [ptxdist] [PATCH v2] linux-firmware: Add new package. Version 20211216
Date: Thu, 20 Jan 2022 09:48:31 +0100 (CET)	[thread overview]
Message-ID: <54cdd598aeb649b1b5c71e8eec07cae3@RCDC-MAIL16.corp.diehl.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]

> Hi,

> >> +
> >> +LINUX_FIRMWARE_SELECTED_LICENSES := $(call remove_quotes,
> >> +$(PTXCONF_LINUX_FIRMWARE_SELECTED_LICENSES))
> >> +ifneq ($(LINUX_FIRMWARE_SELECTED_LICENSES),)
> >> +LINUX_FIRMWARE_LICENSE_FILES := $(filter $(addsuffix %,$(addprefix 
> >> +file://,$(LINUX_FIRMWARE_SELECTED_LICENSES))),$(LINUX_FIRMWARE_LICEN
> >> +SE_
> >> +FILES))
> >> +endif
> > In my opinion LINUX_FIRMWARE_LICENSE_FILES should be 
> > LINUX_FIRMWARE_ALL_LICENSE_FILES and LINUX_FIRMWARE_SELECTED_LICENSES 
> > should be LINUX_FIRMWARE_LICENSE_FILES, so that the license report 
> > only picks up selected licenses.
> > 
>
> The point was that the filter should filter the selected ones from the
full list, to make sure that they do exist. Do you mean that it does not
work? Does the > license report pick licenses in some other way? When I do a
license check it seems to pick the ones I've selected.
>
Sorry, I got the code wrong. You are right.

Regards, Denis 

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3908 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

             reply	other threads:[~2022-01-20  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20  8:48 Denis OSTERLAND-HEIM [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-01-19  6:21 Denis OSTERLAND-HEIM
2022-01-19 18:29 ` Christian Melki
2022-01-18 14:44 Christian Melki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54cdd598aeb649b1b5c71e8eec07cae3@RCDC-MAIL16.corp.diehl.com \
    --to=denis.osterland@diehl.com \
    --cc=christian.melki@t2data.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox