Re: [ptxdist] [PATCH] linux-pam: added Linux-PAM support to ptxdist

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 3896 bytes --]

On 02/25/2015 04:54 PM, Oliver Graute wrote:
> this patch add Linux-PAM support to ptxdist
> 
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/linux-pam.in   |   13 ++++++++++++
>  rules/linux-pam.make |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 rules/linux-pam.in
>  create mode 100644 rules/linux-pam.make
> 
> diff --git a/rules/linux-pam.in b/rules/linux-pam.in
> new file mode 100644
> index 0000000..d76e4db
> --- /dev/null
> +++ b/rules/linux-pam.in
> @@ -0,0 +1,13 @@
> +## SECTION=networking
> +
> +config LINUX_PAM
> +	tristate
> +	prompt "linux-pam"
> +	help
> +	  Linux-PAM is a free implementation of the following DCE-RFC from
> +	  Sunsoft. PAM provides a way to develop programs that are
> +	  independent of authentication scheme. These programs need
> +	  "authentication modules" to be attatched to them at run-time
> +	  in order to work. Which authentication module is to be attatched
> +	  is dependent upon the local system setup and is at the discretion
> +	  of the local system administrator.
> diff --git a/rules/linux-pam.make b/rules/linux-pam.make
> new file mode 100644
> index 0000000..e8fbd02
> --- /dev/null
> +++ b/rules/linux-pam.make
> @@ -0,0 +1,54 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany, Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_LINUX_PAM) += linux-pam
> +
> +#
> +# Paths and names
> +#
> +LINUX_PAM_VERSION	:= 1.1.8
> +LINUX_PAM_MD5		:=

please add MD5.

> +LINUX_PAM		:= Linux-PAM-$(LINUX_PAM_VERSION)
> +LINUX_PAM_SUFFIX	:= tar.gz

why not use the tar.bz2 it's smaller.

> +LINUX_PAM_URL		:= http://www.linux-pam.org/library/$(LINUX_PAM).$(LINUX_PAM_SUFFIX)
> +LINUX_PAM_SOURCE	:= $(SRCDIR)/$(LINUX_PAM).$(LINUX_PAM_SUFFIX)
> +LINUX_PAM_DIR		:= $(BUILDDIR)/$(LINUX_PAM)
> +LINUX_PAM_LICENSE	:= gpl

We usually write GPL in uppercase, in AFICS fact pam is dual licensed
under GPL (version not stated) and I think a BSD license, but I'm not
sure about that.

> +

please add the usual

> # ----------------------------------------------------------------------------   
> # Prepare                                                                        
> # ----------------------------------------------------------------------------   

separator

> +
> +#
> +# autoconf
> +#
> +LINUX_PAM_CONF_TOOL	:= autoconf
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/linux-pam.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, linux-pam)
> +	@$(call install_fixup, linux-pam,PRIORITY,optional)
> +	@$(call install_fixup, linux-pam,SECTION,base)
> +	@$(call install_fixup, linux-pam,AUTHOR,"<oliver.graute@neuhaus.de>")
> +	@$(call install_fixup, linux-pam,DESCRIPTION,missing)
> +
> +	@$(call install_lib, linux-pam, 0, 0, 0644, libpam)
> +
> +	@$(call install_copy, linux-pam, 0, 0, 0644, $(LINUX_PAM_DIR)/conf/pam.conf, /etc/pam.conf)
please use install_alternative instead.
> +	@$(call install_finish, linux-pam)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de