Re: [ptxdist] [PATCHv2] OpenNHRP: add opennhrp to ptxdist

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 3473 bytes --]

On 02/23/2015 03:49 PM, Oliver Graute wrote:
> This patch add OpenNHRP support to ptxdist
> OpenNHRP implements NBMA Next Hop Resolution Protocol (RFC 2332)
> 
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/opennhrp.in   |    7 +++++++
>  rules/opennhrp.make |   53 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 60 insertions(+)
>  create mode 100644 rules/opennhrp.in
>  create mode 100644 rules/opennhrp.make
> 
> diff --git a/rules/opennhrp.in b/rules/opennhrp.in
> new file mode 100644
> index 0000000..52b269a
> --- /dev/null
> +++ b/rules/opennhrp.in
> @@ -0,0 +1,7 @@
> +## SECTION=networking
> +
> +config OPENNHRP
> +	tristate
> +	prompt "opennhrp"
> +	help
> +	 OpenNHRP implements NBMA Next Hop Resolution Protocol (as defined in RFC 2332)

        ^^
Please indent with one tab followed by two spaces, please respect the 80
column limit.

> diff --git a/rules/opennhrp.make b/rules/opennhrp.make
> new file mode 100644
> index 0000000..1b228d5
> --- /dev/null
> +++ b/rules/opennhrp.make
> @@ -0,0 +1,53 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2014 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany,  Oliver Graute <oliver.graute@neuhaus.de>

One space before your name should be enough.

> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_OPENNHRP) += opennhrp
> +
> +#
> +# Paths and names
> +#
> +OPENNHRP_VERSION	:= 0.14.1
> +OPENNHRP_MD5		:= eb42ddb13e07ceb415b9ebb8eaca28ee
> +OPENNHRP		:= opennhrp-$(OPENNHRP_VERSION)
> +OPENNHRP_SUFFIX	:= tar.bz2
> +OPENNHRP_URL		:= $(call ptx/mirror, SF, opennhrp/$(OPENNHRP).$(OPENNHRP))
> +OPENNHRP_SOURCE	:= $(SRCDIR)/$(OPENNHRP).$(OPENNHRP_SUFFIX)
> +OPENNHRP_DIR		:= $(BUILDDIR)/$(OPENNHRP)
> +OPENNHRP_LICENSE	:= MIT
> +
> +
> +OPENNHRP_CONF_ENV	:= $(CROSS_ENV)

Is this a autoconf package?

> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/opennhrp.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, opennhrp)
> +	@$(call install_fixup, opennhrp,PRIORITY,optional)
> +	@$(call install_fixup, opennhrp,SECTION,base)
> +	@$(call install_fixup, opennhrp,AUTHOR,"<oliver.graute@neuhaus.de>")
> +	@$(call install_fixup, opennhrp,DESCRIPTION,missing)
> +
> +	@$(call install_copy, opennhrp, 0, 0, 0755, -, /usr/sbin/opennhrp)
> +	@$(call install_copy, opennhrp, 0, 0, 0755, -, /usr/sbin/opennhrpctl)
> +	@$(call install_copy, opennhrp, 0, 0, 0644, -, /etc/opennhrp/opennhrp.conf)
> +	@$(call install_copy, opennhrp, 0, 0, 0755, -, /etc/opennhrp/racoon-ph1dead.sh)
> +	@$(call install_copy, opennhrp, 0, 0, 0755, -, /etc/opennhrp/racoon-ph1down.sh)

Please use install_alternative for the files in /etc

> +
> +	@$(call install_finish, opennhrp)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> 

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de