Re: [ptxdist] [PATCH] added mosh package to ptxdist

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 4986 bytes --]

On 02/10/2015 08:05 AM, Oliver Graute wrote:
> added a rule for mosh 
> 
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/mosh.in   |    7 ++++
>  rules/mosh.make |  102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 109 insertions(+)
>  create mode 100644 rules/mosh.in
>  create mode 100644 rules/mosh.make
> 
> diff --git a/rules/mosh.in b/rules/mosh.in
> new file mode 100644
> index 0000000..1866a4d
> --- /dev/null
> +++ b/rules/mosh.in
> @@ -0,0 +1,7 @@
> +## SECTION=networking
> +
> +config MOSH
> +	tristate
> +	prompt "mosh"

I assume mosh depends on several external libs, like protobufs and libssl.

> +	help
> +	  Remote terminal application that allows roaming, supports intermittent connectivity, and provides intelligent local echo and line editing of user keystrokes. Mosh is a replacement for SSH. It's more robust and responsive, especially over Wi-Fi, cellular, and long-distance links.

Please limit to 72...80 chars per line.

> diff --git a/rules/mosh.make b/rules/mosh.make
> new file mode 100644
> index 0000000..afbc90f
> --- /dev/null
> +++ b/rules/mosh.make
> @@ -0,0 +1,102 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany,  Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MOSH) += mosh
> +
> +#
> +# Paths and names
> +#
> +MOSH_VERSION	:= 1.2.4
> +MOSH_MD5		:= c2d918f4d91fdc32546e2e089f9281b2
> +MOSH		:= mosh-$(MOSH_VERSION)
> +MOSH_SUFFIX	:= tar.gz
> +MOSH_URL		:= https://mosh.mit.edu//$(MOSH).$(MOSH_SUFFIX)
                                               ^^
please remove one /

> +MOSH_SOURCE	:= $(SRCDIR)/$(MOSH).$(MOSH_SUFFIX)
> +MOSH_DIR		:= $(BUILDDIR)/$(MOSH)
> +MOSH_LICENSE	:= unknown

please add the license of mosh

> +
> +# ----------------------------------------------------------------------------
> +# Get
> +# ----------------------------------------------------------------------------
> +
> +#$(MOSH_SOURCE):
> +#	@$(call targetinfo)
> +#	@$(call get, MOSH)

please remove the commented out stages: get, most of prepare, compile,
install and clean.

> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#MOSH_CONF_ENV	:= $(CROSS_ENV)
> +
> +#
> +# autoconf
> +#
> +MOSH_CONF_TOOL	:= autoconf
> +#MOSH_CONF_OPT	:= $(CROSS_AUTOCONF_USR)
> +
> +#$(STATEDIR)/mosh.prepare:
> +#	@$(call targetinfo)
> +#	@$(call clean, $(MOSH_DIR)/config.cache)
> +#	cd $(MOSH_DIR) && \
> +#		$(MOSH_PATH) $(MOSH_ENV) \
> +#		./configure $(MOSH_CONF_OPT)
> +#	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.compile:
> +#	@$(call targetinfo)
> +#	@$(call world/compile, MOSH)
> +#	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.install:
> +#	@$(call targetinfo)
> +#	@$(call world/install, MOSH)
> +#	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/mosh.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, mosh)
> +	@$(call install_fixup, mosh,PRIORITY,optional)
> +	@$(call install_fixup, mosh,SECTION,base)
> +	@$(call install_fixup, mosh,AUTHOR,"<OGR@neuhaus.de>")
> +	@$(call install_fixup, mosh,DESCRIPTION,missing)
> +
> +	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-server, /usr/bin/mosh-server)
> +	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-client, /usr/bin/mosh-client)
> +
> +	@$(call install_finish, mosh)
> +
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Clean
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.clean:
> +#	@$(call targetinfo)
> +#	@$(call clean_pkg, MOSH)
> +
> +# vim: syntax=make
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de