From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cBeKu-0001Gw-ID for ptxdist@pengutronix.de; Tue, 29 Nov 2016 10:04:24 +0100 Received: from [IPv6:2001:470:7eea:1122:14b9:6c8d:200d:fdc3] (unknown [IPv6:2001:470:7eea:1122:14b9:6c8d:200d:fdc3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mkl@blackshift.org", Issuer "StartCom Class 1 Client CA" (verified OK)) (Authenticated sender: mkl@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 90FD219B8D8 for ; Tue, 29 Nov 2016 09:04:23 +0000 (UTC) References: <1480328492-29475-1-git-send-email-post@lespocky.de> <1480328492-29475-2-git-send-email-post@lespocky.de> <20161128164626.dz57wdql74a64nts@pengutronix.de> From: Marc Kleine-Budde Message-ID: <54014cd5-74ef-3901-9459-953cb6b80d57@pengutronix.de> Date: Tue, 29 Nov 2016 10:04:19 +0100 MIME-Version: 1.0 In-Reply-To: <20161128164626.dz57wdql74a64nts@pengutronix.de> Subject: Re: [ptxdist] [PATCH 1/2] kernel: pass loadaddr for building uImage List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============1174977066==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1174977066== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N03adLXb7pCd4Bww9v3XuCHfLTJ81KAvv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N03adLXb7pCd4Bww9v3XuCHfLTJ81KAvv Content-Type: multipart/mixed; boundary="NgV2bkbGDQsxhehBnAd4gmw27OGerrKsp"; protected-headers="v1" From: Marc Kleine-Budde To: ptxdist@pengutronix.de Message-ID: <54014cd5-74ef-3901-9459-953cb6b80d57@pengutronix.de> Subject: Re: [ptxdist] [PATCH 1/2] kernel: pass loadaddr for building uImage References: <1480328492-29475-1-git-send-email-post@lespocky.de> <1480328492-29475-2-git-send-email-post@lespocky.de> <20161128164626.dz57wdql74a64nts@pengutronix.de> In-Reply-To: <20161128164626.dz57wdql74a64nts@pengutronix.de> --NgV2bkbGDQsxhehBnAd4gmw27OGerrKsp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/28/2016 05:46 PM, Michael Olbrich wrote: > On Mon, Nov 28, 2016 at 11:21:31AM +0100, Alexander Dahl wrote: >> On newer kernels (4.x ?) kernel build fails when building an uImage >> unless you provide LOADADDR as kernel make var, which is put in the >> resulting uImage header. You could append it to >> PTXCONF_KERNEL_EXTRA_MAKEVARS but this would be just a workaround. Thi= s >> patch extends the menu if uImage is selected so you can directly input= >> the desired address. >=20 > I don't have a lot of experience with uImages. Marc, what do you think?= According to rmk uimages are considered obsolete. However there are probably some old bootloaders around that insist of that format. >> Signed-off-by: Alexander Dahl >> --- >> platforms/kernel.in | 7 +++++++ >> rules/kernel.make | 5 +++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/platforms/kernel.in b/platforms/kernel.in >> index fd1c492..2a00122 100644 >> --- a/platforms/kernel.in >> +++ b/platforms/kernel.in >> @@ -213,6 +213,13 @@ config KERNEL_IMAGE >> config KERNEL_DTC >> bool >> =20 >> +config KERNEL_LOADADDR >> + hex >> + prompt "uImage load address" >> + depends on KERNEL_IMAGE_U >> + help >> + Newer kernels want this passed if you build an uImage. >> + >=20 > This should be right after the image selection. >=20 > Michael >=20 >> config KERNEL_XZ >> prompt "build xz-utils hosttool" >> bool >> diff --git a/rules/kernel.make b/rules/kernel.make >> index d02a69c..3270231 100644 >> --- a/rules/kernel.make >> +++ b/rules/kernel.make >> @@ -71,6 +71,11 @@ KERNEL_MAKEVARS +=3D \ >> DEPMOD=3D$(PTXCONF_SYSROOT_HOST)/sbin/depmod >> endif >> =20 >> +ifdef PTXCONF_KERNEL_IMAGE_U >> +KERNEL_MAKEVARS +=3D \ >> + LOADADDR=3D$(PTXCONF_KERNEL_LOADADDR) >> +endif >> + What happens if you build a older kernel and don't configure PTXCONF_KERNEL_LOADADDR via ptxdist? Does it break while it used to work with an older ptxdist? Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --NgV2bkbGDQsxhehBnAd4gmw27OGerrKsp-- --N03adLXb7pCd4Bww9v3XuCHfLTJ81KAvv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEES2FAuYbJvAGobdVQPTuqJaypJWoFAlg9RJMACgkQPTuqJayp JWoahAf+MD6sPvQhOUMhPAzUHt8kIcaIMSvMvc9WU58poxp9m9nkpQVMB6H/2qS9 fqAzKmRvc7ZsqqHfaypnWIxFYOqQk6jd777TDTz5KaFN5WB0dpzEyuPr0IfRYJhu cy5LAqqnjXxIaHzTf13NdTfKNA32YzYTjFIo/PbnBwvz1hGSKexVm0clwplPt/fq 8fwSedE/uYxv1AGv4a4kku/V3Pjb247FsDReMBq2BvAJVFyfYG7/WaBCfGb3AESG g9Jx4qlFBKxFskG9zNJnVKxMkLKpE04CQrwJAZMpHVeFja/oN7HAbtQSqW1i3/wc vZXU/tCVcAhpwoCl7I4d7ZhopVIJ8A== =0Ieb -----END PGP SIGNATURE----- --N03adLXb7pCd4Bww9v3XuCHfLTJ81KAvv-- --===============1174977066== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============1174977066==--