mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv
@ 2014-08-04  8:29 Bruno Thomsen
  2014-08-05 11:37 ` Markus Niebel
  2014-08-05 12:29 ` Markus Niebel
  0 siblings, 2 replies; 6+ messages in thread
From: Bruno Thomsen @ 2014-08-04  8:29 UTC (permalink / raw)
  To: ptxdist; +Cc: bth, Martin Fisker

Provide read/write access to U-Boot environment stored in eMMC flash from Linux.

Access to U-Boot environment can be very useful; dual kernel/rootfs images, production default values, change kernel bootargs, etc.

Tested with U-Boot 2009.08 and 2013.04 on TQMa28.

Warning! This is not ready for ptxdist mainline inclusion.

Signed-off-by: Martin Fisker <mfi@kamstrup.dk>
Signed-off-by: Bruno Thomsen <bth@kamstrup.dk>
---
 ...oot-emmc-support-in-fw_printenv-fw_setenv.patch | 182 +++++++++++++++++++++
 patches/u-boot-2011.12/series                      |   3 +-
 2 files changed, 184 insertions(+), 1 deletion(-)
 create mode 100644 patches/u-boot-2011.12/0002-u-boot-emmc-support-in-fw_printenv-fw_setenv.patch

diff --git a/patches/u-boot-2011.12/0002-u-boot-emmc-support-in-fw_printenv-fw_setenv.patch b/patches/u-boot-2011.12/0002-u-boot-emmc-support-in-fw_printenv-fw_setenv.patch
new file mode 100644
index 0000000..95916ca
--- /dev/null
+++ b/patches/u-boot-2011.12/0002-u-boot-emmc-support-in-fw_printenv-fw_setenv.patch
@@ -0,0 +1,182 @@
+From: Bruno Thomsen <bth@kamstrup.dk>
+Date: Fri, 1 Aug 2014 10:00:16 +0200
+Subject: [RFC] u-boot: emmc support in fw_printenv/fw_setenv
+
+Provide read/write access to U-Boot environment stored in eMMC flash from Linux.
+
+Signed-off-by: Martin Fisker <mfi@kamstrup.dk>
+Signed-off-by: Bruno Thomsen <bth@kamstrup.dk>
+---
+ tools/env/fw_env.c      | 77 +++++++++++++++++++++++++++++++++----------------
+ tools/env/fw_env.config |  4 +++
+ 2 files changed, 56 insertions(+), 25 deletions(-)
+
+diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
+index 996682e..631a26f 100644
+--- a/tools/env/fw_env.c
++++ b/tools/env/fw_env.c
+@@ -45,6 +45,8 @@
+ 
+ #include "fw_env.h"
+ 
++#define CONFIG_ENV_IS_IN_MMC
++
+ #define WHITESPACE(c) ((c == '\t') || (c == ' '))
+ 
+ #define min(x, y) ({				\
+@@ -773,10 +775,10 @@ static int flash_write_buf (int dev, int fd, void *buf, size_t count,
+ 
+ 	blocklen = DEVESIZE (dev);
+ 
+-	top_of_range = ((DEVOFFSET(dev) / blocklen) +
+-					ENVSECTORS (dev)) * blocklen;
++	top_of_range = (DEVOFFSET(dev) & ~(blocklen - 1)) +
++					ENVSECTORS (dev) * blocklen;
+ 
+-	erase_offset = (offset / blocklen) * blocklen;
++	erase_offset = offset & ~(blocklen - 1);
+ 
+ 	/* Maximum area we may use */
+ 	erase_len = top_of_range - erase_offset;
+@@ -790,8 +792,7 @@ static int flash_write_buf (int dev, int fd, void *buf, size_t count,
+ 	 * to the start of the data, then count bytes of data, and to the
+ 	 * end of the block
+ 	 */
+-	write_total = ((block_seek + count + blocklen - 1) /
+-						blocklen) * blocklen;
++	write_total = (block_seek + count + blocklen - 1) & ~(blocklen - 1);
+ 
+ 	/*
+ 	 * Support data anywhere within erase sectors: read out the complete
+@@ -807,9 +808,9 @@ static int flash_write_buf (int dev, int fd, void *buf, size_t count,
+ 			return -1;
+ 		}
+ 
+-		rc = flash_read_buf (dev, fd, data, write_total, erase_offset,
+-				     mtd_type);
+-		if (write_total != rc)
++		rc = flash_read_buf (dev, fd, data, CONFIG_ENV_SIZE,
++					DEVOFFSET(dev_current), mtd_type);
++		if (CONFIG_ENV_SIZE != rc)
+ 			return -1;
+ 
+ 		/* Overwrite the old environment */
+@@ -835,22 +836,27 @@ static int flash_write_buf (int dev, int fd, void *buf, size_t count,
+ 	erase.length = erasesize;
+ 
+ 	/* This only runs once on NOR flash and SPI-dataflash */
++	int loopcount = 0;
+ 	while (processed < write_total) {
+-		rc = flash_bad_block (fd, mtd_type, &blockstart);
+-		if (rc < 0)		/* block test failed */
+-			return rc;
+-
+-		if (blockstart + erasesize > top_of_range) {
+-			fprintf (stderr, "End of range reached, aborting\n");
+-			return -1;
+-		}
++		loopcount++;
++		if(mtd_type != MTD_ABSENT)
++		{
++			rc = flash_bad_block (fd, mtd_type, &blockstart);
++			if (rc < 0)		/* block test failed */
++				return rc;
++
++			if (blockstart + erasesize > top_of_range) {
++				fprintf (stderr, "End of range reached, aborting\n");
++				return -1;
++			}
+ 
+-		if (rc) {		/* block is bad */
+-			blockstart += blocklen;
+-			continue;
++			if (rc) {		/* block is bad */
++				blockstart += blocklen;
++				continue;
++			}
+ 		}
+-
+ 		erase.start = blockstart;
++#ifndef CONFIG_ENV_IS_IN_MMC
+ 		ioctl (fd, MEMUNLOCK, &erase);
+ 
+ 		/* Dataflash does not need an explicit erase cycle */
+@@ -861,7 +867,7 @@ static int flash_write_buf (int dev, int fd, void *buf, size_t count,
+ 					 strerror (errno));
+ 				return -1;
+ 			}
+-
++#endif
+ 		if (lseek (fd, blockstart, SEEK_SET) == -1) {
+ 			fprintf (stderr,
+ 				 "Seek error on %s: %s\n",
+@@ -870,17 +876,34 @@ static int flash_write_buf (int dev, int fd, void *buf, size_t count,
+ 		}
+ 
+ #ifdef DEBUG
+-		printf ("Write 0x%x bytes at 0x%llx\n", erasesize, blockstart);
++		printf ("Write 0x%x bytes at 0x%llx\n", write_total, blockstart);
++		printf("erasesize %d\n", erasesize);
++		printf("count %d\n", count);
++		printf("writeTotal %d\n", write_total);
++		printf("processed %d\n", processed);
++		printf("loopcount %d\n", loopcount);
++		printf("blocklen %d\n", blocklen);
++#endif
++#ifdef CONFIG_ENV_IS_IN_MMC
++		size_t bytesWritten = write (fd, data + processed, write_total);
++		if (bytesWritten != write_total) {
++#else
++		size_t bytesWritten = write (fd, data + processed, erasesize);
++		if (bytesWritten != erasesize) {
+ #endif
+-		if (write (fd, data + processed, erasesize) != erasesize) {
+ 			fprintf (stderr, "Write error on %s: %s\n",
+ 				 DEVNAME (dev), strerror (errno));
+ 			return -1;
+ 		}
+ 
++#ifndef CONFIG_ENV_IS_IN_MMC
+ 		ioctl (fd, MEMLOCK, &erase);
+-
++#endif
++#ifdef CONFIG_ENV_IS_IN_MMC
++		processed  += bytesWritten;
++#else
+ 		processed  += blocklen;
++#endif
+ 		block_seek = 0;
+ 		blockstart += blocklen;
+ 	}
+@@ -964,7 +987,7 @@ static int flash_read (int fd)
+ {
+ 	struct mtd_info_user mtdinfo;
+ 	int rc;
+-
++#ifndef CONFIG_ENV_IS_IN_MMC
+ 	rc = ioctl (fd, MEMGETINFO, &mtdinfo);
+ 	if (rc < 0) {
+ 		perror ("Cannot get MTD information");
+@@ -982,6 +1005,10 @@ static int flash_read (int fd)
+ 
+ 	rc = flash_read_buf (dev_current, fd, environment.image, CONFIG_ENV_SIZE,
+ 			     DEVOFFSET (dev_current), mtdinfo.type);
++#else
++	rc = flash_read_buf (dev_current, fd, environment.image, CONFIG_ENV_SIZE,
++			     DEVOFFSET (dev_current), 0);
++#endif
+ 
+ 	return (rc != CONFIG_ENV_SIZE) ? -1 : 0;
+ }
+diff --git a/tools/env/fw_env.config b/tools/env/fw_env.config
+index 8e21d5a..6b45687 100644
+--- a/tools/env/fw_env.config
++++ b/tools/env/fw_env.config
+@@ -17,3 +17,7 @@
+ 
+ # NAND example
+ #/dev/mtd0		0x4000		0x4000		0x20000			2
++
++# eMMC example
++# MMC device name       Device offset   Env. size
++#/dev/mmcblk0		0x400		0x1FC00		0x1FC00			1
diff --git a/patches/u-boot-2011.12/series b/patches/u-boot-2011.12/series
index eea4611..20733b1 100644
--- a/patches/u-boot-2011.12/series
+++ b/patches/u-boot-2011.12/series
@@ -1,4 +1,5 @@
 # generated by git-ptx-patches
 #tag:base --start-number 1
 0001-tools-Prefer-u-boot-includes-to-system-include-direc.patch
-# 944f1726d2ab9856a3d9b36c7af8e95b  - git-ptx-patches magic
+0002-u-boot-emmc-support-in-fw_printenv-fw_setenv.patch
+# 856c73a788cbb5e251c4dbadfbbf3785  - git-ptx-patches magic
-- 
1.9.1


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv
  2014-08-04  8:29 [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv Bruno Thomsen
@ 2014-08-05 11:37 ` Markus Niebel
  2014-08-05 12:29 ` Markus Niebel
  1 sibling, 0 replies; 6+ messages in thread
From: Markus Niebel @ 2014-08-05 11:37 UTC (permalink / raw)
  To: ptxdist; +Cc: bth, Martin Fisker

Hello Bruno,

Am 04.08.2014 10:29, wrote Bruno Thomsen:
> Provide read/write access to U-Boot environment stored in eMMC flash from Linux.
> 
> Access to U-Boot environment can be very useful; dual kernel/rootfs images, production default values, change kernel bootargs, etc.
> 
> Tested with U-Boot 2009.08 and 2013.04 on TQMa28.
> 

Wouldn't it be better to rework the support for u-boot tools in general? (I know, this will be tricky, since
U-Boot environment tools compilation is really an adventure). Also I think, we should use the same version of
U-Boot tools as we use for the U-Boot itself.

What do you think?

For reference here is an internal used version of the u-boot-tools Makefile (known to work with U-Boot versions from our BSP for TQMa53 / TQMa6x). Should work at least for U-Boot 2013.01 and 2013.04 You need to provide a target specific /etc/fw_env.config

8<--------------------------------------------------------------------
# -*-makefile-*-
#
# Copyright (C) 2012 by Andreas Bießmann <andreas@biessmann.de>
#
# See CREDITS for details about who has contributed to this project.
#
# For further information about the PTXdist project and license conditions
# see the README file.
#

#
# We provide this package
#
PACKAGES-$(PTXCONF_U_BOOT_TOOLS) += u-boot-tools

#
# Paths and names
#
U_BOOT_TOOLS_VERSION	:= $(U_BOOT_VERSION)
U_BOOT_TOOLS_MD5	:= $(U_BOOT_MD5)
U_BOOT_TOOLS		:= u-boot-$(U_BOOT_TOOLS_VERSION)
U_BOOT_TOOLS_SUFFIX	:= tar.bz2
U_BOOT_TOOLS_URL	:= http://ftp.denx.de/pub/u-boot/$(U_BOOT_TOOLS).$(U_BOOT_TOOLS_SUFFIX)
U_BOOT_TOOLS_SOURCE	:= $(SRCDIR)/$(U_BOOT_TOOLS).$(U_BOOT_TOOLS_SUFFIX)
U_BOOT_TOOLS_DIR	:= $(BUILDDIR)/$(U_BOOT_TOOLS)
U_BOOT_TOOLS_LICENSE	:= GPLv2

$(STATEDIR)/u-boot-tools.extract: $(STATEDIR)/u-boot.extract
	@$(call targetinfo)
	@$(call touch)

$(STATEDIR)/u-boot-tools.prepare: $(STATEDIR)/u-boot.prepare
	@$(call targetinfo)
	@$(call touch)

# ----------------------------------------------------------------------------
# Prepare
# ----------------------------------------------------------------------------

U_BOOT_TOOLS_PATH	:= $(U_BOOT_PATH)
# U_BOOT_TOOLS_MAKE_OPT	:= $(U_BOOT_MAKE_OPT) tools

U_BOOT_TOOLS_CONF_TOOL	:= NO
U_BOOT_TOOLS_MAKE_OPT	:= \
	HOSTCC="$(BOOTLOADER_CROSS_COMPILE)gcc" \
	HOSTSTRIP="$(BOOTLOADER_CROSS_COMPILE)strip" \
	CROSS_COMPILE=$(BOOTLOADER_CROSS_COMPILE) \
	tools

#	HOSTCC="$(CROSS_CC)" \
#	HOSTSTRIP="$(CROSS_STRIP)" \
#	tools

ifdef PTXCONF_U_BOOT_TOOLS_TOOL_ENV
U_BOOT_TOOLS_MAKE_OPT	+= env
endif

# ----------------------------------------------------------------------------
# Install
# ----------------------------------------------------------------------------

$(STATEDIR)/u-boot-tools.install:
	@$(call targetinfo)
	install -D $(U_BOOT_TOOLS_DIR)/tools/env/fw_printenv \
		$(U_BOOT_TOOLS_PKGDIR)/usr/sbin/fw_printenv
	@$(call touch)

# ----------------------------------------------------------------------------
# Target-Install
# ----------------------------------------------------------------------------

$(STATEDIR)/u-boot-tools.targetinstall:
	@$(call targetinfo)

	@$(call install_init,  u-boot-tools)
	@$(call install_fixup, u-boot-tools,PRIORITY,optional)
	@$(call install_fixup, u-boot-tools,SECTION,base)
	@$(call install_fixup, u-boot-tools,AUTHOR,\
		"Andreas Bießmann <andreas@biessmann.de>")
	@$(call install_fixup, u-boot-tools,DESCRIPTION,missing)

ifdef PTXCONF_U_BOOT_TOOLS_TOOL_ENV
	@$(call install_copy, u-boot-tools, 0, 0, 0755, -, /usr/sbin/fw_printenv)
	@$(call install_link, u-boot-tools, fw_printenv, /usr/sbin/fw_setenv)
	@$(call install_alternative, u-boot-tools, 0, 0, 0644, /etc/fw_env.config)
endif

	@$(call install_finish, u-boot-tools)

	@$(call touch)

$(STATEDIR)/u-boot-tools.clean:
	@$(call targetinfo)
	-rm $(STATEDIR)/u-boot-tools.*
#	@$(call clean_pkg, U_BOOT_TOOLS)

# vim: syntax=make
8<--------------------------------------------------------------------

Regards

Markus

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv
  2014-08-04  8:29 [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv Bruno Thomsen
  2014-08-05 11:37 ` Markus Niebel
@ 2014-08-05 12:29 ` Markus Niebel
  2014-08-08 10:16   ` Michael Olbrich
  1 sibling, 1 reply; 6+ messages in thread
From: Markus Niebel @ 2014-08-05 12:29 UTC (permalink / raw)
  To: ptxdist; +Cc: bth, Martin Fisker

Hello Bruno,

Am 04.08.2014 10:29, wrote Bruno Thomsen:
> Provide read/write access to U-Boot environment stored in eMMC flash from Linux.
> 
> Access to U-Boot environment can be very useful; dual kernel/rootfs images, production default values, change kernel bootargs, etc.
> 
> Tested with U-Boot 2009.08 and 2013.04 on TQMa28.
> 

Wouldn't it be better to rework the support for u-boot tools in general? (I know, this will be tricky, since
U-Boot environment tools compilation is really an adventure). Also I think, we should use the same version of
U-Boot tools as we use for the U-Boot itself.

What do you think?

For reference here is an internal used version of the u-boot-tools Makefile (known to work with U-Boot versions from our BSP for TQMa53 / TQMa6x). Should work at least for U-Boot 2013.01 and 2013.04 You need to provide a target specific /etc/fw_env.config

8<--------------------------------------------------------------------
# -*-makefile-*-
#
# Copyright (C) 2012 by Andreas Bießmann <andreas@biessmann.de>
#
# See CREDITS for details about who has contributed to this project.
#
# For further information about the PTXdist project and license conditions
# see the README file.
#

#
# We provide this package
#
PACKAGES-$(PTXCONF_U_BOOT_TOOLS) += u-boot-tools

#
# Paths and names
#
U_BOOT_TOOLS_VERSION	:= $(U_BOOT_VERSION)
U_BOOT_TOOLS_MD5	:= $(U_BOOT_MD5)
U_BOOT_TOOLS		:= u-boot-$(U_BOOT_TOOLS_VERSION)
U_BOOT_TOOLS_SUFFIX	:= tar.bz2
U_BOOT_TOOLS_URL	:= http://ftp.denx.de/pub/u-boot/$(U_BOOT_TOOLS).$(U_BOOT_TOOLS_SUFFIX)
U_BOOT_TOOLS_SOURCE	:= $(SRCDIR)/$(U_BOOT_TOOLS).$(U_BOOT_TOOLS_SUFFIX)
U_BOOT_TOOLS_DIR	:= $(BUILDDIR)/$(U_BOOT_TOOLS)
U_BOOT_TOOLS_LICENSE	:= GPLv2

$(STATEDIR)/u-boot-tools.extract: $(STATEDIR)/u-boot.extract
	@$(call targetinfo)
	@$(call touch)

$(STATEDIR)/u-boot-tools.prepare: $(STATEDIR)/u-boot.prepare
	@$(call targetinfo)
	@$(call touch)

# ----------------------------------------------------------------------------
# Prepare
# ----------------------------------------------------------------------------

U_BOOT_TOOLS_PATH	:= $(U_BOOT_PATH)
# U_BOOT_TOOLS_MAKE_OPT	:= $(U_BOOT_MAKE_OPT) tools

U_BOOT_TOOLS_CONF_TOOL	:= NO
U_BOOT_TOOLS_MAKE_OPT	:= \
	HOSTCC="$(BOOTLOADER_CROSS_COMPILE)gcc" \
	HOSTSTRIP="$(BOOTLOADER_CROSS_COMPILE)strip" \
	CROSS_COMPILE=$(BOOTLOADER_CROSS_COMPILE) \
	tools

#	HOSTCC="$(CROSS_CC)" \
#	HOSTSTRIP="$(CROSS_STRIP)" \
#	tools

ifdef PTXCONF_U_BOOT_TOOLS_TOOL_ENV
U_BOOT_TOOLS_MAKE_OPT	+= env
endif

# ----------------------------------------------------------------------------
# Install
# ----------------------------------------------------------------------------

$(STATEDIR)/u-boot-tools.install:
	@$(call targetinfo)
	install -D $(U_BOOT_TOOLS_DIR)/tools/env/fw_printenv \
		$(U_BOOT_TOOLS_PKGDIR)/usr/sbin/fw_printenv
	@$(call touch)

# ----------------------------------------------------------------------------
# Target-Install
# ----------------------------------------------------------------------------

$(STATEDIR)/u-boot-tools.targetinstall:
	@$(call targetinfo)

	@$(call install_init,  u-boot-tools)
	@$(call install_fixup, u-boot-tools,PRIORITY,optional)
	@$(call install_fixup, u-boot-tools,SECTION,base)
	@$(call install_fixup, u-boot-tools,AUTHOR,\
		"Andreas Bießmann <andreas@biessmann.de>")
	@$(call install_fixup, u-boot-tools,DESCRIPTION,missing)

ifdef PTXCONF_U_BOOT_TOOLS_TOOL_ENV
	@$(call install_copy, u-boot-tools, 0, 0, 0755, -, /usr/sbin/fw_printenv)
	@$(call install_link, u-boot-tools, fw_printenv, /usr/sbin/fw_setenv)
	@$(call install_alternative, u-boot-tools, 0, 0, 0644, /etc/fw_env.config)
endif

	@$(call install_finish, u-boot-tools)

	@$(call touch)

$(STATEDIR)/u-boot-tools.clean:
	@$(call targetinfo)
	-rm $(STATEDIR)/u-boot-tools.*
#	@$(call clean_pkg, U_BOOT_TOOLS)

# vim: syntax=make
8<--------------------------------------------------------------------

Regards

Markus

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv
  2014-08-05 12:29 ` Markus Niebel
@ 2014-08-08 10:16   ` Michael Olbrich
  2014-08-20  9:02     ` Bruno Thomsen
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Olbrich @ 2014-08-08 10:16 UTC (permalink / raw)
  To: ptxdist

On Tue, Aug 05, 2014 at 02:29:12PM +0200, Markus Niebel wrote:
> Hello Bruno,
> 
> Am 04.08.2014 10:29, wrote Bruno Thomsen:
> > Provide read/write access to U-Boot environment stored in eMMC flash from Linux.
> > 
> > Access to U-Boot environment can be very useful; dual kernel/rootfs images, production default values, change kernel bootargs, etc.
> > 
> > Tested with U-Boot 2009.08 and 2013.04 on TQMa28.
> > 
> 
> Wouldn't it be better to rework the support for u-boot tools in general? (I know, this will be tricky, since
> U-Boot environment tools compilation is really an adventure). Also I think, we should use the same version of
> U-Boot tools as we use for the U-Boot itself.
> 
> What do you think?

I think it's a good idea.

> For reference here is an internal used version of the u-boot-tools Makefile (known to work with U-Boot versions from our BSP for TQMa53 / TQMa6x). Should work at least for U-Boot 2013.01 and 2013.04 You need to provide a target specific /etc/fw_env.config
> 
> 8<--------------------------------------------------------------------
> # -*-makefile-*-
> #
> # Copyright (C) 2012 by Andreas Bießmann <andreas@biessmann.de>
> #
> # See CREDITS for details about who has contributed to this project.
> #
> # For further information about the PTXdist project and license conditions
> # see the README file.
> #
> 
> #
> # We provide this package
> #
> PACKAGES-$(PTXCONF_U_BOOT_TOOLS) += u-boot-tools
> 
> #
> # Paths and names
> #
> U_BOOT_TOOLS_VERSION	:= $(U_BOOT_VERSION)
> U_BOOT_TOOLS_MD5	:= $(U_BOOT_MD5)
> U_BOOT_TOOLS		:= u-boot-$(U_BOOT_TOOLS_VERSION)
> U_BOOT_TOOLS_SUFFIX	:= tar.bz2
> U_BOOT_TOOLS_URL	:= http://ftp.denx.de/pub/u-boot/$(U_BOOT_TOOLS).$(U_BOOT_TOOLS_SUFFIX)
> U_BOOT_TOOLS_SOURCE	:= $(SRCDIR)/$(U_BOOT_TOOLS).$(U_BOOT_TOOLS_SUFFIX)

This can fail. Use '=' instead of ':=' for anything that uses U_BOOT*
variables (directly or indirectly).

> U_BOOT_TOOLS_DIR	:= $(BUILDDIR)/$(U_BOOT_TOOLS)

Set this to $(BUILDDIR)/u-boot-tools-$(U_BOOT_TOOLS_VERSION) ...

> U_BOOT_TOOLS_LICENSE	:= GPLv2
> 
> $(STATEDIR)/u-boot-tools.extract: $(STATEDIR)/u-boot.extract
> 	@$(call targetinfo)
> 	@$(call touch)
> 
> $(STATEDIR)/u-boot-tools.prepare: $(STATEDIR)/u-boot.prepare
> 	@$(call targetinfo)
> 	@$(call touch)

... and do the extract /prepare correctly. Anything else causes problems
when rebuilding individual packages.

Michael

> 
> # ----------------------------------------------------------------------------
> # Prepare
> # ----------------------------------------------------------------------------
> 
> U_BOOT_TOOLS_PATH	:= $(U_BOOT_PATH)
> # U_BOOT_TOOLS_MAKE_OPT	:= $(U_BOOT_MAKE_OPT) tools
> 
> U_BOOT_TOOLS_CONF_TOOL	:= NO
> U_BOOT_TOOLS_MAKE_OPT	:= \
> 	HOSTCC="$(BOOTLOADER_CROSS_COMPILE)gcc" \
> 	HOSTSTRIP="$(BOOTLOADER_CROSS_COMPILE)strip" \
> 	CROSS_COMPILE=$(BOOTLOADER_CROSS_COMPILE) \
> 	tools
> 
> #	HOSTCC="$(CROSS_CC)" \
> #	HOSTSTRIP="$(CROSS_STRIP)" \
> #	tools
> 
> ifdef PTXCONF_U_BOOT_TOOLS_TOOL_ENV
> U_BOOT_TOOLS_MAKE_OPT	+= env
> endif
> 
> # ----------------------------------------------------------------------------
> # Install
> # ----------------------------------------------------------------------------
> 
> $(STATEDIR)/u-boot-tools.install:
> 	@$(call targetinfo)
> 	install -D $(U_BOOT_TOOLS_DIR)/tools/env/fw_printenv \
> 		$(U_BOOT_TOOLS_PKGDIR)/usr/sbin/fw_printenv
> 	@$(call touch)
> 
> # ----------------------------------------------------------------------------
> # Target-Install
> # ----------------------------------------------------------------------------
> 
> $(STATEDIR)/u-boot-tools.targetinstall:
> 	@$(call targetinfo)
> 
> 	@$(call install_init,  u-boot-tools)
> 	@$(call install_fixup, u-boot-tools,PRIORITY,optional)
> 	@$(call install_fixup, u-boot-tools,SECTION,base)
> 	@$(call install_fixup, u-boot-tools,AUTHOR,\
> 		"Andreas Bießmann <andreas@biessmann.de>")
> 	@$(call install_fixup, u-boot-tools,DESCRIPTION,missing)
> 
> ifdef PTXCONF_U_BOOT_TOOLS_TOOL_ENV
> 	@$(call install_copy, u-boot-tools, 0, 0, 0755, -, /usr/sbin/fw_printenv)
> 	@$(call install_link, u-boot-tools, fw_printenv, /usr/sbin/fw_setenv)
> 	@$(call install_alternative, u-boot-tools, 0, 0, 0644, /etc/fw_env.config)
> endif
> 
> 	@$(call install_finish, u-boot-tools)
> 
> 	@$(call touch)
> 
> $(STATEDIR)/u-boot-tools.clean:
> 	@$(call targetinfo)
> 	-rm $(STATEDIR)/u-boot-tools.*
> #	@$(call clean_pkg, U_BOOT_TOOLS)
> 
> # vim: syntax=make
> 8<--------------------------------------------------------------------
> 
> Regards
> 
> Markus
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv
  2014-08-08 10:16   ` Michael Olbrich
@ 2014-08-20  9:02     ` Bruno Thomsen
  2014-08-25 10:09       ` Markus Niebel
  0 siblings, 1 reply; 6+ messages in thread
From: Bruno Thomsen @ 2014-08-20  9:02 UTC (permalink / raw)
  To: ptxdist


-----Original Message-----
From: ptxdist-bounces@pengutronix.de [mailto:ptxdist-bounces@pengutronix.de] On Behalf Of Michael Olbrich
Sent: 8. august 2014 12:18
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv

> On Tue, Aug 05, 2014 at 02:29:12PM +0200, Markus Niebel wrote:
> > Hello Bruno,
> > 
> > Am 04.08.2014 10:29, wrote Bruno Thomsen:
> > > Provide read/write access to U-Boot environment stored in eMMC flash from Linux.
> > > 
> > > Access to U-Boot environment can be very useful; dual kernel/rootfs images, production default values, change kernel bootargs, etc.
> > > 
> > > Tested with U-Boot 2009.08 and 2013.04 on TQMa28.
> > > 
> > 
> > Wouldn't it be better to rework the support for u-boot tools in 
> > general? (I know, this will be tricky, since U-Boot environment tools 
> > compilation is really an adventure). Also I think, we should use the same version of U-Boot tools as we use for the U-Boot itself.
> > 
> > What do you think?
>
> I think it's a good idea.

Yes, use the same U-Boot package for both bootloader and tools.

Then we have the block device (emmc, etc.) vs. mtd[1] (NAND, NOR) support issue.
As I see there are the following solutions:
1) Select fw_printenv/fw_setenv storage support based on define in board configuration, ex. CONFIG_ENV_IS_IN_MMC in mx28evk.
2) fw_printenv/fw_setenv support both storage technologies:
  a) Add storage type parameter to /etc/fw_env.config
  b) Autodetect storage type with strcmp() based on device name



[1] MTD: Memory Technology Device, http://www.linux-mtd.infradead.org/faq/general.html


Venlig hilsen / Best regards

Kamstrup A/S <http://www.kamstrup.dk> 
Bruno Thomsen
Development engineer
Technology

Kamstrup A/S
Industrivej 28
DK-8660 Skanderborg
Tel:	 +45 89 93 10 00	 
Fax:	 +45 89 93 10 01	 
Dir:	 +45 89 93 13 94	 
E-mail:	 bth@kamstrup.dk	 
Web:	 www.kamstrup.dk	 

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv
  2014-08-20  9:02     ` Bruno Thomsen
@ 2014-08-25 10:09       ` Markus Niebel
  0 siblings, 0 replies; 6+ messages in thread
From: Markus Niebel @ 2014-08-25 10:09 UTC (permalink / raw)
  To: ptxdist

Hello Bruno,
 
> Yes, use the same U-Boot package for both bootloader and tools.
> 
> Then we have the block device (emmc, etc.) vs. mtd[1] (NAND, NOR) support issue.
> As I see there are the following solutions:
> 1) Select fw_printenv/fw_setenv storage support based on define in board configuration, ex. CONFIG_ENV_IS_IN_MMC in mx28evk.
> 2) fw_printenv/fw_setenv support both storage technologies:
>   a) Add storage type parameter to /etc/fw_env.config
>   b) Autodetect storage type with strcmp() based on device name
> 

As long as there is only one device for your platform, we should try to use the install_alternative method to install
a project specific /etc/fw_env.config from <BSP>/projectroot. If there are multiple locations for the environment a project specific way to set a link to the config file to be used has to be implemented in the root FS 

> 
> 
> [1] MTD: Memory Technology Device, http://www.linux-mtd.infradead.org/faq/general.html
> 
> 
> Venlig hilsen / Best regards
> 
> Kamstrup A/S <http://www.kamstrup.dk> 
> Bruno Thomsen
> Development engineer
> Technology
> 
> Kamstrup A/S
> Industrivej 28
> DK-8660 Skanderborg
> Tel:	 +45 89 93 10 00	 
> Fax:	 +45 89 93 10 01	 
> Dir:	 +45 89 93 13 94	 
> E-mail:	 bth@kamstrup.dk	 
> Web:	 www.kamstrup.dk	 
> 
Best Regards

Markus Niebel

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-25  9:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-04  8:29 [ptxdist] [RFC] u-boot-tools: emmc support in fw_printenv/fw_setenv Bruno Thomsen
2014-08-05 11:37 ` Markus Niebel
2014-08-05 12:29 ` Markus Niebel
2014-08-08 10:16   ` Michael Olbrich
2014-08-20  9:02     ` Bruno Thomsen
2014-08-25 10:09       ` Markus Niebel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox