mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Matthias Klein <matthias.klein@optimeas.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] ptxdist: Create symlinks for toolchain-related tools
Date: Wed, 23 Jul 2014 08:19:54 +0200	[thread overview]
Message-ID: <53CF540A.6030105@optimeas.de> (raw)
In-Reply-To: <1406042531-15648-1-git-send-email-bernhard@bwalle.de>

Hello Bernhard,

until now I did not test you patch, but I also have to link all these 
toolchain programs into the sysroot-host/lib/wrapper/ directory for 
using everything with QtCreator.


Best regards,
Matthias


Am 22.07.2014 17:22, schrieb Bernhard Walle:
> This patch adds symlinks in the toolchain wrapper dir for
> toolchain-related tools like as, nm, etc. Currently, that symlinks are
> only created for tools for which ptxdist provides the wrapper mechanism.
>
> The primary use case is our internal build system (application that
> resides in local_src) that expects all programs to be at the same
> location (because some very complicated magic...).
>
> Apart from that, I think the solution to have all tools at the same
> place is cleaner and the patch is very small. So it would be nice if it
> could be accepted.
>
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>   bin/ptxdist | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/bin/ptxdist b/bin/ptxdist
> index 45b3540..d9758e3 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -610,6 +610,12 @@ check_compiler() {
>   		}
>   	done
>   
> +	for tool in ar as cpp nm objcopy objdump ranlib readelf size strip ; do
> +		tool_abs="$(which "${tool}" 2>/dev/null)"
> +		ptxd_replace_link "${tool_abs}" "${wrapper_dir}/${tool}" || \
> +			ptxd_bailout "Unable to create host ${tool} wrapper link"
> +	done
> +
>   	if ptxd_get_ptxconf PTXCONF_BUILD_TOOLCHAIN >/dev/null; then
>   		PATH="${wrapper_dir}:${PATH}"
>   		return
> @@ -712,6 +718,9 @@ check_compiler() {
>   		ptxd_replace_link "$(which ${compiler_prefix}${cc})" "${wrapper_dir}/real/${compiler_prefix}${cc}" &&
>   		ptxd_replace_link "${SCRIPTSDIR}/wrapper/${cc}-wrapper" "${wrapper_dir}/${compiler_prefix}${cc}"
>   	done &&
> +	for tool in ar as cpp nm objcopy objdump ranlib readelf size strip ; do
> +		ptxd_replace_link "$(which ${compiler_prefix}${tool})"  "${wrapper_dir}/${compiler_prefix}${tool}"
> +	done &&
>   	PATH="${wrapper_dir}:${PATH}" &&
>   	if [ -n "${PTXDIST_ICECC}" ]; then
>   		local icecc_dir="${sysroot_host}/lib/icecc"


-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2014-07-23  6:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 15:22 Bernhard Walle
2014-07-23  6:19 ` Matthias Klein [this message]
2014-08-05 15:05   ` Tim Niemeyer
2014-08-05 15:22     ` Bernhard Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CF540A.6030105@optimeas.de \
    --to=matthias.klein@optimeas.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox