Re: [ptxdist] [RFC] ptxd_make_dts_dtb: check on failure if dtc failed

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1416 bytes --]

On 07/08/2014 03:24 PM, Alexander Aring wrote:
> On Tue, Jul 08, 2014 at 03:22:18PM +0200, Marc Kleine-Budde wrote:
>> On 07/08/2014 02:59 PM, Alexander Aring wrote:
>>> This patch adds a error handling for the dtc and call a ptxd_bailout if
>>> an error occur.
>>>
>>> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
>>> ---
>>>  scripts/lib/ptxd_make_dts_dtc.sh | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/scripts/lib/ptxd_make_dts_dtc.sh b/scripts/lib/ptxd_make_dts_dtc.sh
>>> index 24c5604..6a09cae 100644
>>> --- a/scripts/lib/ptxd_make_dts_dtc.sh
>>> +++ b/scripts/lib/ptxd_make_dts_dtc.sh
>>> @@ -59,6 +59,10 @@ ptxd_make_dts_dtb() {
>>>  	-I dts -O dtb -b 0 \
>>>  	-o "${dts_dtb}" "${tmp_dts}"
>>>  
>>> +    if [ "$?" != "0" ]; then
>>> +	ptxd_bailout "Unable to generate ${dts_dtb} file."
>>> +    fi
>>
>> What about:
>>
>>     || ptxd_bailout "Unable to generate ${dts_dtb} file."
>>
> 
> okay, yes then we could save the if. I can also add
> 
> 	|| ptxd_bailout ... for cpp call.

Or better concatenate everything with a && and add || bailout at the end.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de