From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Message-ID: <53A97923.40306@tqsc.de>
Date: Tue, 24 Jun 2014 15:12:03 +0200
From: Markus Niebel <list-09@tqsc.de>
MIME-Version: 1.0
References: <1403249588-4857-1-git-send-email-list-09_ptxdist@tqsc.de>
	<20140623134547.GJ16937@pengutronix.de>
In-Reply-To: <20140623134547.GJ16937@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] memtester: version bump 4.0.8 -> 4.3.0
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de
Cc: m.olbrich@pengutronix.de

Hello,

Am 23.06.2014 15:45, schrieb Michael Olbrich:
> On Fri, Jun 20, 2014 at 09:33:08AM +0200, Markus Niebel wrote:
>> From: Markus Niebel <Markus.Niebel@tq-group.com>
>>
>
> Thanks, applied.
>
> Unrelated to this patch, but I noticed that the code is compiled without
> optimization. Do you think it makes sense to add something like this to the
> prepare stage:
>
> 	@echo "CFLAGS = -O2 -g"               >> $(MEMTESTER_DIR)/Makefile

maybe changing in:

@echo "$(CROSS_CC) -O2 -DPOSIX -D_POSIX_C_SOURCE=200809L 
-D_FILE_OFFSET_BITS=64 -DTEST_NARROW_WRITES -c" > $(MEMTESTER_DIR)/conf-cc
@echo "$(CROSS_CC) -s" > $(MEMTESTER_DIR)/conf-ld

and using package's own build system would be even better?
>
> Michael
>

Markus


-- 
ptxdist mailing list
ptxdist@pengutronix.de