From: Markus Niebel <list-09@tqsc.de>
To: ptxdist@pengutronix.de
Cc: m.olbrich@pengutronix.de
Subject: Re: [ptxdist] [PATCH] memtester: version bump 4.0.8 -> 4.3.0
Date: Tue, 24 Jun 2014 15:12:03 +0200 [thread overview]
Message-ID: <53A97923.40306@tqsc.de> (raw)
In-Reply-To: <20140623134547.GJ16937@pengutronix.de>
Hello,
Am 23.06.2014 15:45, schrieb Michael Olbrich:
> On Fri, Jun 20, 2014 at 09:33:08AM +0200, Markus Niebel wrote:
>> From: Markus Niebel <Markus.Niebel@tq-group.com>
>>
>
> Thanks, applied.
>
> Unrelated to this patch, but I noticed that the code is compiled without
> optimization. Do you think it makes sense to add something like this to the
> prepare stage:
>
> @echo "CFLAGS = -O2 -g" >> $(MEMTESTER_DIR)/Makefile
maybe changing in:
@echo "$(CROSS_CC) -O2 -DPOSIX -D_POSIX_C_SOURCE=200809L
-D_FILE_OFFSET_BITS=64 -DTEST_NARROW_WRITES -c" > $(MEMTESTER_DIR)/conf-cc
@echo "$(CROSS_CC) -s" > $(MEMTESTER_DIR)/conf-ld
and using package's own build system would be even better?
>
> Michael
>
Markus
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2014-06-24 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 7:33 Markus Niebel
2014-06-23 13:45 ` Michael Olbrich
2014-06-24 13:12 ` Markus Niebel [this message]
2014-06-24 13:18 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A97923.40306@tqsc.de \
--to=list-09@tqsc.de \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox