mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v3] Add Music Player Daemon (MPD) support
Date: Sat, 07 Jun 2014 21:03:00 +0200	[thread overview]
Message-ID: <539361E4.8030507@pengutronix.de> (raw)
In-Reply-To: <1402127864-6411-1-git-send-email-m.grzeschik@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 4998 bytes --]

On 06/07/2014 09:57 AM, Michael Grzeschik wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Michael Grzeschik <mgr@pengutronix.de>
> ---
> v1..v2
> -aligned ifs
> -remove MPD in every config section
> -removed commented build stages
> -used MPD_ENABLE-* where needed
> -used simpler addprefix macro
> v2..v3
> -removed MPD_ENABLE-*
> -removed MPD_CONF_ENV
> -used ptx/endis instead
> -simplified install_copy for mpd
> -added EXAMPLECONF option
> 
>  rules/mpd.in   | 61 +++++++++++++++++++++++++++++++++++++++++++++++++
>  rules/mpd.make | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 132 insertions(+)
>  create mode 100644 rules/mpd.in
>  create mode 100644 rules/mpd.make
> 
> diff --git a/rules/mpd.in b/rules/mpd.in
> new file mode 100644
> index 0000000..399bde6
> --- /dev/null
> +++ b/rules/mpd.in
> @@ -0,0 +1,61 @@
> +## SECTION=multimedia_sound
> +
> +menuconfig MPD
> +	tristate
> +	prompt "Music Player Daemon (MPD)     "
> +	select GLIB
> +	select ALSA_LIB		if MPD_ALSA
> +	select LIBID3TAG	if MPD_ID3
> +	select LIBMAD		if MPD_MAD
> +	select MPG123		if MPD_MPG123
> +	select LIBOGG		if MPD_VORBIS
> +	select LIBVORBIS	if MPD_VORBIS
> +	select FLAC		if MPD_FLAC
> +	select LIBCURL		if MPD_CURL
> +	select SQLITE		if MPD_SQLITE
> +	help
> +	  Music Player Daemon (MPD) is a flexible, powerful, server-side
> +	  application for playing music. Through plugins and libraries it
> +	  can play a variety of sound files while being controlled by its
> +	  network protocol.
> +
> +if MPD
> +
> +config MPD_EXAMPLECONF
> +	bool
> +	prompt "install /etc/mpd.conf"
> +	default y
> +
> +config MPD_ALSA
> +	prompt "Alsa support"
> +	bool
> +
> +config MPD_ID3
> +	prompt "ID3 support"
> +	bool
> +
> +config MPD_MAD
> +	prompt "MAD support"
> +	bool
> +
> +config MPD_MPG123
> +	prompt "MPG123 support"
> +	bool
> +
> +config MPD_VORBIS
> +	prompt "Vorbis support"
> +	bool
> +
> +config MPD_FLAC
> +	prompt "FLAC support"
> +	bool
> +
> +config MPD_CURL
> +	prompt "curl support"
> +	bool
> +
> +config MPD_SQLITE
> +	prompt "SQLite support"
> +	bool
> +
> +endif
> diff --git a/rules/mpd.make b/rules/mpd.make
> new file mode 100644
> index 0000000..c280630
> --- /dev/null
> +++ b/rules/mpd.make
> @@ -0,0 +1,71 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2013 by Sascha Hauer <s.hauer@pengutronix.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MPD) += mpd
> +
> +#
> +# Paths and names
> +#
> +MPD_VERSION	:= 0.18.11
> +MPD_MD5		:= 6dd86793ad78d8b502f6721734f87ff7
> +MPD		:= mpd-$(MPD_VERSION)
> +MPD_SUFFIX	:= tar.gz
> +MPD_URL		:= http://www.musicpd.org/download/mpd/0.18/$(MPD).$(MPD_SUFFIX)
> +MPD_SOURCE	:= $(SRCDIR)/$(MPD).$(MPD_SUFFIX)
> +MPD_DIR		:= $(BUILDDIR)/$(MPD)
> +MPD_LICENSE	:= unknown
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +MPD_CONF_TOOL	:= autoconf
> +MPD_CONF_OPT	:= \
> +	$(CROSS_AUTOCONF_USR) \
> +	--$(call ptx/endis, PTXCONF_MPD_ALSA)-alsa \
> +	--$(call ptx/endis, PTXCONF_MPD_FFMPEG)-ffmpeg \
> +	--$(call ptx/endis, PTXCONF_MPD_ID3)-id3 \
> +	--$(call ptx/endis, PTXCONF_MPD_MAD)-mad \
> +	--$(call ptx/endis, PTXCONF_MPD_MPG123)-mpg123 \
> +	--$(call ptx/endis, PTXCONF_MPD_VORBIS)-vorbis \
> +	--$(call ptx/endis, PTXCONF_MPD_FLAC)-flac \
> +	--$(call ptx/endis, PTXCONF_MPD_CURL)-curl \
> +	--$(call ptx/endis, PTXCONF_MPD_SQLITE)-sqlite \
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/mpd.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, mpd)
> +	@$(call install_fixup, mpd,PRIORITY,optional)
> +	@$(call install_fixup, mpd,SECTION,base)
> +	@$(call install_fixup, mpd,AUTHOR,"Sascha Hauer <s.hauer@pengutronix.de>")
> +	@$(call install_fixup, mpd,DESCRIPTION,missing)
> +
> +	@$(call install_copy, mpd, 0, 0, 0755, -, /usr/bin/mpd)
> +
> +ifdef PTXCONF_MPD_EXAMPLECONF
> +	@$(call install_copy, mpd, 0, 0, 0755, $(MPD_PKGDIR)/usr/share/doc/mpd/mpdconf.example, /etc/mpd.conf)
                                         0644

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2014-06-07 19:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-31 12:57 [ptxdist] [PATCH] " Sascha Hauer
2013-08-31 13:17 ` Alexander Aring
2013-08-31 13:34   ` Sascha Hauer
2013-09-04  7:09 ` Michael Olbrich
2013-09-09  8:46 ` Michael Olbrich
2014-05-16 10:05 ` Michael Grzeschik
2014-05-16 10:33   ` Alexander Aring
2014-06-02  8:39   ` Michael Olbrich
2014-06-07  7:57     ` [ptxdist] [PATCH v3] " Michael Grzeschik
2014-06-07 19:03       ` Marc Kleine-Budde [this message]
2014-06-10  5:42       ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539361E4.8030507@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox