From: "Andreas Bießmann" <andreas@biessmann.de>
To: Bernhard Walle <bernhard@bwalle.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] ptxdist: check vendor for ct-ng toolchain
Date: Tue, 18 Mar 2014 16:13:49 +0100 [thread overview]
Message-ID: <532862AD.30201@biessmann.de> (raw)
In-Reply-To: <480422b0110b4795448fed69277f72f9@bwalle.de>
Hi Bernhard,
thanks for your feedback.
On 18.03.14 10:07, Bernhard Walle wrote:
> Hi,
>
> since I'm also using ct-ng toolchains, I like that feature. However,
> in my case CT_TOOLCHAIN_PKGVERSION was empty, so wouldn't it make sense
> to add the line
>
> [ -z "$vendor_is" ] && vendor_is=crosstool-NG
>
> after
>
> vendor_is=$(${ct_vendor_def} | sed -n -e 's/"//g' -e
> 's/^CT_TOOLCHAIN_PKGVERSION=//p')
>
> (sorry, I don't have the original patch in my mail box).
I think we should use the whole ct-ng version string. As you also
mentioned we need some specific parsing then but I think it's worth.
My intention for that patch was to identify our specific ct-ng builds
which are tagged with a vendor string. But as you pointed out most ct-ng
toolchains will not have this parameter set.
I'd provide a reworked patch if some pengutronix guy (mol?) would
indicate if such a ct-ng version check would be applied generally.
Best regards
Andreas Bießmann
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2014-03-18 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 13:28 Andreas Bießmann
2014-03-16 16:07 ` Andreas Bießmann
2014-03-18 9:07 ` Bernhard Walle
2014-03-18 15:13 ` Andreas Bießmann [this message]
2014-03-18 15:49 ` Michael Olbrich
2014-04-20 7:48 ` [ptxdist] [PATCH v2] " Andreas Bießmann
2014-04-21 8:51 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532862AD.30201@biessmann.de \
--to=andreas@biessmann.de \
--cc=bernhard@bwalle.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox