From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from moutng.kundenserver.de ([212.227.17.8]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1WGSxN-0005FW-KO for ptxdist@pengutronix.de; Thu, 20 Feb 2014 13:42:27 +0100 Received: from [192.168.102.106] (punisher.2og.er.corscience.de [192.168.102.106]) by mail.er.corscience.de (Postfix) with ESMTPSA id 95029347A0BB for ; Thu, 20 Feb 2014 13:42:18 +0100 (CET) Message-ID: <5305F82A.5080907@corscience.de> Date: Thu, 20 Feb 2014 13:42:18 +0100 From: =?UTF-8?B?QW5kcmVhcyBCaWXDn21hbm4=?= MIME-Version: 1.0 References: <1381834722-20966-1-git-send-email-andreas@biessmann.de> In-Reply-To: <1381834722-20966-1-git-send-email-andreas@biessmann.de> Subject: Re: [ptxdist] [PATCH] flashbench: print strerror(3) Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0642792535==" Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0642792535== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jUuQV3uvK241e9mq4d4j9cnPOKwBl5K2p" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jUuQV3uvK241e9mq4d4j9cnPOKwBl5K2p Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable ping ... On 10/15/2013 12:58 PM, Andreas Bie=C3=9Fmann wrote: > flashbench may end without any comment on error in setup (mostly ENOMEM= on > allocating scratch buffer). > To avoid others searching again add strerror(3) to give a hint to the u= ser. >=20 > Signed-off-by: Andreas Bie=C3=9Fmann > --- > .../0003-flashbench-printout-error.patch | 33 ++++++++++++= ++++++++ > patches/flashbench-20120222/series | 3 +- > 2 files changed, 35 insertions(+), 1 deletion(-) > create mode 100644 patches/flashbench-20120222/0003-flashbench-printou= t-error.patch >=20 > diff --git a/patches/flashbench-20120222/0003-flashbench-printout-error= =2Epatch b/patches/flashbench-20120222/0003-flashbench-printout-error.pat= ch > new file mode 100644 > index 0000000..63c7453 > --- /dev/null > +++ b/patches/flashbench-20120222/0003-flashbench-printout-error.patch > @@ -0,0 +1,33 @@ > +From: =3D?UTF-8?q?Andreas=3D20Bie=3DC3=3D9Fmann?=3D > +Date: Tue, 15 Oct 2013 12:37:48 +0200 > +Subject: [PATCH] flashbench: printout error > +MIME-Version: 1.0 > +Content-Type: text/plain; charset=3DUTF-8 > +Content-Transfer-Encoding: 8bit > + > +In order to get a clue _what_ happened printout the error string. > + > +Signed-off-by: Andreas Bie=C3=9Fmann = > +--- > + flashbench.c | 8 +++++++- > + 1 file changed, 7 insertions(+), 1 deletion(-) > + > +diff --git a/flashbench.c b/flashbench.c > +index 0a1016f..5b553c7 100644 > +--- a/flashbench.c > ++++ b/flashbench.c > +@@ -19,7 +19,13 @@ > +=20 > + typedef long long ns_t; > +=20 > +-#define returnif(x) do { typeof(x) __x =3D (x); if (__x < 0) return (= __x); } while (0) > ++#define returnif(x) do { = \ > ++ typeof(x) __x =3D (x); = \ > ++ if (__x < 0) { = \ > ++ fprintf(stderr, "flashbench: internal error '%s'\n", strerror(-__x)= ); \ > ++ return (__x); = \ > ++ } = \ > ++ } while (0) > +=20 > + static ns_t ns_min(int count, ns_t data[]) > + { > diff --git a/patches/flashbench-20120222/series b/patches/flashbench-20= 120222/series > index b63b21f..82de47c 100644 > --- a/patches/flashbench-20120222/series > +++ b/patches/flashbench-20120222/series > @@ -2,4 +2,5 @@ > #tag:base --start-number 1 > 0001-Allow-to-specify-MAX_BUFSIZE-during-compile-time.patch > 0002-Add-lrt-to-LDLIBS-instead-of-LDFLAGS.patch > -# fa6c1da743f5dd6808f0f1b887b31657 - git-ptx-patches magic > +0003-flashbench-printout-error.patch > +# 429c331f680c7d428505b255597dd1f0 - git-ptx-patches magic >=20 anything wrong with this patchset? Best regards Andreas Bie=C3=9Fmann --jUuQV3uvK241e9mq4d4j9cnPOKwBl5K2p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJTBfgqAAoJEHPlkEBPIQBj9JUQAMMKfgwYvccxF678E6ODNd6d OzTYQUvkvuZnSOpPo2VoHm3jbFzmTRJCdqtAptxwc5Kk47ujeynTGvhzFrn5scsj 32C/bVwjA6coO+fB/ltn4qCN/PRe4wbkIBt23jsqTxbDZywGxbgXtFJ82hWnIqpq 9tfP1O6EaPJ8yRDPE8Lr1ahZMRf+IMXYksax2oFy7d4r79DYSeZQt0Bt1/iGFiZW HmjTIJKeLT50X1rr7/c8JC5zA4b4Yn/WqcLg5/pZLP95Nf7KoJbLge9Iw90k3SjH nFD0Qh/h4Vtb6iJNCGAXCU9Nw0pKXm+tQGRSQEzehUMdOAGLPN8zd0cqMVd33Zgu DIHfsBeybJ8f+VYQPPXJ0TbR8/WfmFMEGfSi3AwTCgtukIc1WOAXAfaKEuUlDpUG 19S+SABoQ80ag6qKqRLxA5m2QIPFheGo70Tj4VxuEDNXQQAmnvy/CpAp5Ko23uK/ QE8i/Ykebc0nvk+Qi8TLPJtEkpMI93Dr+kwqvFEqAyGbN/PJBd6QBINvmidCZ6VU RFCttYB8aH1tR+MC1iV53x5lpJE7ucUb/kLVLnq+lCJgJpH2/P+QvG5JzE3hCMyY oPhqanCirc70tLI3oWZezPlogNvz1vKOctfzmlrfnUH2rkq+U4/COZxRy+11JiAV u7l6X2/hJjsDb9WaL18R =hN67 -----END PGP SIGNATURE----- --jUuQV3uvK241e9mq4d4j9cnPOKwBl5K2p-- --===============0642792535== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- ptxdist mailing list ptxdist@pengutronix.de --===============0642792535==--