From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <5137B342.1060905@pengutronix.de> Date: Wed, 06 Mar 2013 22:21:06 +0100 From: Marc Kleine-Budde MIME-Version: 1.0 References: <1362600041-13179-1-git-send-email-u.kleine-koenig@pengutronix.de> In-Reply-To: <1362600041-13179-1-git-send-email-u.kleine-koenig@pengutronix.de> Subject: Re: [ptxdist] [PATCH] git-ptx-patches: add --notes to git-format-patch if it's supported Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1309007721==" Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Cc: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1309007721== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2VNPXXOKVUGOTVORWVFRF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2VNPXXOKVUGOTVORWVFRF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/06/2013 09:00 PM, Uwe Kleine-K=C3=B6nig wrote: > While at it also document minimal git version needed for --no-signature= =2E >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > scripts/git-ptx-patches | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/scripts/git-ptx-patches b/scripts/git-ptx-patches > index 37f5d91..fadb2c1 100755 > --- a/scripts/git-ptx-patches > +++ b/scripts/git-ptx-patches > @@ -110,10 +110,17 @@ case "$remove_old" in > ;; > esac > =20 > +# git-format-patch --notes is supported since git 1.7.2 ? > if git format-patch -h 2>&1 | grep -q signature; then > GIT_EXTRA_ARGS=3D"--no-signature" > fi > =20 > +# git-format-patch --notes is supported since git 1.7.6, but actually = you want > +# git 1.8.1-rc0 to get the notes below the --- marker > +if man git-format-patch | grep -q -e --notes; then Why don't we use the same mechanism (either man or -h) to figure out if git supports the extra agrument? > + GIT_EXTRA_ARGS=3D"$GIT_EXTRA_ARGS --notes" > +fi > + > cat .ptxdist/series.0 > .ptxdist/series > git format-patch -N $GIT_EXTRA_ARGS ${tagopt} -o .ptxdist/patches/ ${r= ange} | sed -e 's,^.ptxdist/patches/,,' > .ptxdist/series.auto > cat .ptxdist/series.auto >> .ptxdist/series Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | ------enig2VNPXXOKVUGOTVORWVFRF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlE3s0UACgkQjTAFq1RaXHOomgCfdLBvpxmeGRmVcMv6LeHKJXKY zE0An39eFZtAmpkcP8cDz1PYGrX4Xf2I =5qxP -----END PGP SIGNATURE----- ------enig2VNPXXOKVUGOTVORWVFRF-- --===============1309007721== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- ptxdist mailing list ptxdist@pengutronix.de --===============1309007721==--