On 03/06/2013 09:00 PM, Uwe Kleine-König wrote:
> While at it also document minimal git version needed for --no-signature.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  scripts/git-ptx-patches | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/scripts/git-ptx-patches b/scripts/git-ptx-patches
> index 37f5d91..fadb2c1 100755
> --- a/scripts/git-ptx-patches
> +++ b/scripts/git-ptx-patches
> @@ -110,10 +110,17 @@ case "$remove_old" in
>  		;;
>  esac
>  
> +# git-format-patch --notes is supported since git 1.7.2

?

>  if git format-patch -h 2>&1 | grep -q signature; then
>  	GIT_EXTRA_ARGS="--no-signature"
>  fi
>  
> +# git-format-patch --notes is supported since git 1.7.6, but actually you want
> +# git 1.8.1-rc0 to get the notes below the --- marker
> +if man git-format-patch | grep -q -e --notes; then

Why don't we use the same mechanism (either man or -h) to figure out if
git supports the extra agrument?

> +	GIT_EXTRA_ARGS="$GIT_EXTRA_ARGS --notes"
> +fi
> +
>  cat .ptxdist/series.0 > .ptxdist/series
>  git format-patch -N $GIT_EXTRA_ARGS ${tagopt} -o .ptxdist/patches/ ${range} | sed -e 's,^.ptxdist/patches/,,' > .ptxdist/series.auto
>  cat .ptxdist/series.auto >> .ptxdist/series

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |