From: Josef Holzmayr <holzmayr@rsi-elektrotechnik.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] libmodbus: fix remote buffer overflow vulnerabulity
Date: Thu, 14 Feb 2013 17:07:13 +0100 [thread overview]
Message-ID: <511D0BB1.9060209@rsi-elektrotechnik.de> (raw)
In-Reply-To: <20130207180759.GC6194@pengutronix.de>
Hi Michael,
Am 07.02.2013 19:07, schrieb Michael Olbrich:
>> +Add checks so modbus_reply returns a
>> +MODBUS_EXCEPTION_ILLEGAL_DATA_ADDRESS if the count of requested
>> +registers exceeds the spec as noted in modbus.h, line 73ff.
>
> Can you add your s-o-b here? This looks like it is something for upstream.
> Is there some bug report or something that you can reference here, so we
> know what to do with this when the next update happens?
you mean to s-o-b the patch itself? Sure, why not.
A real bugreport doesn't exist, just some bits and pieces:
- debian was not too concerned due to low count in popcon. We later
pushed the patch into the package, though.
- an earlier version of the patch was sent to the original maintainer
(as github pull request), he is a bit unresponsive though.
I guess the best will be to re-try and send it to upstream. Shall I keep
you in the loop then?
Greetz
_____________________________________________________________
Josef Holzmayr
Dipl-Ing. (FH)
Entwicklung Embedded Devices / Software
Tel.: +49 8444 9204-48>
Fax: +49 8444 9204-50
holzmayr@rsi-elektrotechnik.de
R-S-I Elektrotechnik GmbH & Co. KG
Woelkestrasse 11
D-85301 Schweitenkirchen
www.rsi-elektrotechnik.de
_____________________________________________________________
Amtsgericht Ingolstadt - GmbH: HRB 191328 - KG: HRA 170363
Geschäftsführer: Dr.-Ing. Michael Sorg, Dipl.-Ing. Franz Sorg
USt-IdNr.: DE 128592548
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2013-02-14 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 11:26 Josef Holzmayr
2013-02-07 18:07 ` Michael Olbrich
2013-02-14 16:07 ` Josef Holzmayr [this message]
2013-04-04 8:41 ` Josef Holzmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511D0BB1.9060209@rsi-elektrotechnik.de \
--to=holzmayr@rsi-elektrotechnik.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox