From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from moutng.kundenserver.de ([212.227.17.10])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <andreas.biessmann@corscience.de>) id 1U0qek-0001TZ-LY
	for ptxdist@pengutronix.de; Thu, 31 Jan 2013 10:42:07 +0100
Received: from mail.er.corscience.de (mail.er.corscience.de [192.168.1.6])
	by corscience.de (Postfix) with ESMTP id 8786251E35
	for <ptxdist@pengutronix.de>; Thu, 31 Jan 2013 10:42:00 +0100 (CET)
Received: from [192.168.102.103] (azuregos.2og.er.corscience.de
	[192.168.102.103])
	by mail.er.corscience.de (Postfix) with ESMTPSA id 9DD86347A14A
	for <ptxdist@pengutronix.de>; Thu, 31 Jan 2013 10:42:00 +0100 (CET)
Message-ID: <510A3C68.2050709@corscience.de>
Date: Thu, 31 Jan 2013 10:42:00 +0100
From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?=
 <andreas.biessmann@corscience.de>
MIME-Version: 1.0
References: <1359549168-7713-1-git-send-email-bernhard.sessler@corscience.de>
In-Reply-To: <1359549168-7713-1-git-send-email-bernhard.sessler@corscience.de>
Subject: Re: [ptxdist] [PATCHv2] log4cplus: Add new package
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi Bernhard,

On 30.01.2013 13:32, Bernhard Sessler wrote:
> log4cplus is an excellent port of the popular log4j logging library
> to C++.
> =

> Signed-off-by: Bernhard Sessler <bernhard.sessler@corscience.de>
> ---
>  rules/log4cplus.in   | 21 ++++++++++++++++
>  rules/log4cplus.make | 67 ++++++++++++++++++++++++++++++++++++++++++++++=
++++++
>  2 files changed, 88 insertions(+)
>  create mode 100644 rules/log4cplus.in
>  create mode 100644 rules/log4cplus.make
> =

> diff --git a/rules/log4cplus.in b/rules/log4cplus.in
> new file mode 100644
> index 0000000..941188f
> --- /dev/null
> +++ b/rules/log4cplus.in
> @@ -0,0 +1,21 @@
> +## SECTION=3Dsystem_libraries
> +
> +menuconfig LOG4CPLUS
> +	tristate
> +	prompt "log4cplus                     "
> +	select GLIBC_PTHREAD

just realized that you build log4cplus with cmake. Therefore missing
dependency to host-cmake here!

> +	select QT4 if LOG4CPLUS_QT4

Shouldn't we move that select QT4 down to the LOG4CPLUS_QT4 switch?

> +	help
> +	  The purpose of this project is to port the
> +	  excellent Log for Java (log4j) logging
> +	  library to C++.
> +
> +if LOG4CPLUS
> +
> +config LOG4CPLUS_QT4
> +	bool
> +	prompt "Qt4 debug appender"
> +	help
> +	  Build the log4cplus Qt4 debug appender
> +
> +endif

<snip>

Best regards

Andreas Bie=DFmann

-- =

ptxdist mailing list
ptxdist@pengutronix.de