mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.biessmann@corscience.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCHv2] log4cplus: Add new package
Date: Thu, 31 Jan 2013 10:42:00 +0100	[thread overview]
Message-ID: <510A3C68.2050709@corscience.de> (raw)
In-Reply-To: <1359549168-7713-1-git-send-email-bernhard.sessler@corscience.de>

Hi Bernhard,

On 30.01.2013 13:32, Bernhard Sessler wrote:
> log4cplus is an excellent port of the popular log4j logging library
> to C++.
> 
> Signed-off-by: Bernhard Sessler <bernhard.sessler@corscience.de>
> ---
>  rules/log4cplus.in   | 21 ++++++++++++++++
>  rules/log4cplus.make | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 88 insertions(+)
>  create mode 100644 rules/log4cplus.in
>  create mode 100644 rules/log4cplus.make
> 
> diff --git a/rules/log4cplus.in b/rules/log4cplus.in
> new file mode 100644
> index 0000000..941188f
> --- /dev/null
> +++ b/rules/log4cplus.in
> @@ -0,0 +1,21 @@
> +## SECTION=system_libraries
> +
> +menuconfig LOG4CPLUS
> +	tristate
> +	prompt "log4cplus                     "
> +	select GLIBC_PTHREAD

just realized that you build log4cplus with cmake. Therefore missing
dependency to host-cmake here!

> +	select QT4 if LOG4CPLUS_QT4

Shouldn't we move that select QT4 down to the LOG4CPLUS_QT4 switch?

> +	help
> +	  The purpose of this project is to port the
> +	  excellent Log for Java (log4j) logging
> +	  library to C++.
> +
> +if LOG4CPLUS
> +
> +config LOG4CPLUS_QT4
> +	bool
> +	prompt "Qt4 debug appender"
> +	help
> +	  Build the log4cplus Qt4 debug appender
> +
> +endif

<snip>

Best regards

Andreas Bießmann

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  parent reply	other threads:[~2013-01-31  9:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 12:32 Bernhard Sessler
2013-01-30 20:12 ` Alexander Aring
2013-01-31  9:42 ` Andreas Bießmann [this message]
2013-01-31  9:44   ` Bernhard Walle
2013-01-31  9:46 ` Bernhard Walle
2013-01-31 10:10   ` Bernhard Seßler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510A3C68.2050709@corscience.de \
    --to=andreas.biessmann@corscience.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox