Re: [ptxdist] Binary patches

["Andreas Bießmann" <andreas.biessmann@corscience.de>]

Hi Matthias,

On 29.01.2013 09:39, Matthias Klein wrote:
> Hi Andreas,
> 
>> Well, as I thought, so please try my step by step guide.
>>
> Sorry, at the first reading I have your step guide.
> 
> 
> I have followed your step guide, and git creates a now patch file in the
> format you described (GIT binary patch) and added it to the series file.
> Very nice. Is the "extract --git" and "git ptx-patches" somewhere
> documented?

I do not know if this made it into the 'How to become a PTXdist Guru'
document. I got this hint by Michael last year:
http://article.gmane.org/gmane.comp.embedded.ptxdist.devel/8544

> But then at the normal "extract" I get a error from patch:
> 
> applying '0050-SDMA-firmware.patch'
> patch: **** Only garbage was found in the patch input.
> make: *** [.../platform-tx53/state/kernel.extract] Error 2
> 
> Do I make something wrong, or do I need a speacial "patch" version for
> GIT binary patches?
Not that I know of, patch 2.6.1 works for me here as expected (Debian
Wheezy):

---8<---
0078-add-binary-blob.patch
patchin: git: done

finished target kernel.extract
./p_normal extract kernel  29,22s user 7,69s system 74% cpu 49,745 total
abiessmann@azuregos % git --version
git version 1.7.10.4
abiessmann@azuregos % patch --version
patch 2.6.1
abiessmann@azuregos % ls -la
platform-test/build-target/linux-3.4/firmware/CKFA.bin
-rwxr-xr-x 1 abiessmann abiessmann 6668 Jan 29 10:25
platform-test/build-target/linux-3.4/firmware/CKFA.bin*
abiessmann@azuregos % head -20 patches/linux-3.4/0078-add-binary-blob.patch
From: =?UTF-8?q?Andreas=20Bie=C3=9Fmann?= <andreas.biessmann@corscience.de>
Date: Tue, 29 Jan 2013 10:24:15 +0100
Subject: [PATCH] add binary blob
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Andreas Bießmann <andreas.biessmann@corscience.de>
---
 firmware/CKFA.bin |  Bin 0 -> 6668 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100755 firmware/CKFA.bin

diff --git a/firmware/CKFA.bin b/firmware/CKFA.bin
new file mode 100755
index
0000000000000000000000000000000000000000..9befbf415a9fd8bcc19655ca1dc50966d248ebba
GIT binary patch
literal 6668
zcmbtZ3w)DBwx91y`ZfLf<Y`}~vGPa>FOhY<B9MGZ)AUJ+H4EN?Jo-okn_eCttS?$9
zP*ODI0|OKva4nDz*5!(Ny{v*D0akgat6r8xmSq*uYqIFtE&`Ho&zU5oRFwO>H~CG@
--->8---

Beside that, have you thought about Roberts comment?
You can not distribute binary BLOB in a GPLv2 software and refuse
disclosure of that blob. To load binary closed source firmware blobs the
linux kernel provides a userspace interface. You should use that if you
intend to sell this device.

Best regards

Andreas Bießmann

-- 
ptxdist mailing list
ptxdist@pengutronix.de