* [ptxdist] PATCH: Fix sqlite conf environment
@ 2012-11-20 22:07 Kirill Smirnov
2012-12-08 0:22 ` Kirill Smirnov
0 siblings, 1 reply; 4+ messages in thread
From: Kirill Smirnov @ 2012-11-20 22:07 UTC (permalink / raw)
To: ptxdist
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
Hi!
The attached patch correctly sets up CPPFLAGS variable for sqlite
package and contains a minor cosmetic fix.
Otherwise configure script cannot find external libraries and headers
(such as readline).
--
Kirill
[-- Attachment #2: sqlite_make.patch --]
[-- Type: text/plain, Size: 635 bytes --]
diff --git a/rules/sqlite.make b/rules/sqlite.make
index 0ff4c86..25ff3b7 100644
--- a/rules/sqlite.make
+++ b/rules/sqlite.make
@@ -34,12 +34,13 @@ SQLITE_LICENSE := public_domain
# ----------------------------------------------------------------------------
SQLITE_CONF_ENV := \
- CPPFLAGS=" \
+ $(CROSS_ENV) \
+ CPPFLAGS="$(CROSS_CPPFLAGS) \
-DSQLITE_ENABLE_COLUMN_METADATA \
-DSQLITE_ENABLE_FTS3 \
-DSQLITE_ENABLE_RTREE=1 \
-DSQLITE_ENABLE_UNLOCK_NOTIFY \
- -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1\
+ -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1 \
-DSQLITE_OMIT_LOOKASIDE=1 \
-DSQLITE_SECURE_DELETE \
-DSQLITE_SOUNDEX=1 \
[-- Attachment #3: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] PATCH: Fix sqlite conf environment
2012-11-20 22:07 [ptxdist] PATCH: Fix sqlite conf environment Kirill Smirnov
@ 2012-12-08 0:22 ` Kirill Smirnov
2013-01-03 14:38 ` Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Kirill Smirnov @ 2012-12-08 0:22 UTC (permalink / raw)
To: ptxdist
Hi!
Please, any feedback on this. Did I do anything wrong?
--
Kirill
On 21.11.2012 02:07, Kirill Smirnov wrote:
> Hi!
>
> The attached patch correctly sets up CPPFLAGS variable for sqlite
> package and contains a minor cosmetic fix.
>
> Otherwise configure script cannot find external libraries and headers
> (such as readline).
>
> --
> Kirill
>
>
> diff --git a/rules/sqlite.make b/rules/sqlite.make
> index 0ff4c86..25ff3b7 100644
> --- a/rules/sqlite.make
> +++ b/rules/sqlite.make
> @@ -34,12 +34,13 @@ SQLITE_LICENSE := public_domain
> #
----------------------------------------------------------------------------
> SQLITE_CONF_ENV := \
> - CPPFLAGS=" \
> + $(CROSS_ENV) \
> + CPPFLAGS="$(CROSS_CPPFLAGS) \
> -DSQLITE_ENABLE_COLUMN_METADATA \
> -DSQLITE_ENABLE_FTS3 \
> -DSQLITE_ENABLE_RTREE=1 \
> -DSQLITE_ENABLE_UNLOCK_NOTIFY \
> - -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1\
> + -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1 \
> -DSQLITE_OMIT_LOOKASIDE=1 \
> -DSQLITE_SECURE_DELETE \
> -DSQLITE_SOUNDEX=1 \
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] PATCH: Fix sqlite conf environment
2012-12-08 0:22 ` Kirill Smirnov
@ 2013-01-03 14:38 ` Michael Olbrich
2013-01-04 14:59 ` Kirill Smirnov
0 siblings, 1 reply; 4+ messages in thread
From: Michael Olbrich @ 2013-01-03 14:38 UTC (permalink / raw)
To: ptxdist
On Sat, Dec 08, 2012 at 04:22:27AM +0400, Kirill Smirnov wrote:
> Please, any feedback on this. Did I do anything wrong?
I forgot about this.
> On 21.11.2012 02:07, Kirill Smirnov wrote:
> >The attached patch correctly sets up CPPFLAGS variable for sqlite
> >package and contains a minor cosmetic fix.
Please end a canonical patch (with 'git sent-email' or (git format-patch').
> >Otherwise configure script cannot find external libraries and headers
> >(such as readline).
Interresting, the CROSS_ENV part is definitively correct, but I'm not sure,
why you're getting this error and I don't.
> >--
> >Kirill
> >
> >
> > diff --git a/rules/sqlite.make b/rules/sqlite.make
> > index 0ff4c86..25ff3b7 100644
> > --- a/rules/sqlite.make
> > +++ b/rules/sqlite.make
> > @@ -34,12 +34,13 @@ SQLITE_LICENSE := public_domain
> > # ----------------------------------------------------------------------------
>
> > SQLITE_CONF_ENV := \
> > - CPPFLAGS=" \
> > + $(CROSS_ENV) \
This looks ok.
> > + CPPFLAGS="$(CROSS_CPPFLAGS) \
With the latest changes to ptxdist CROSS_CPPFLAGS is now empty, so this is
not needed any more.
Michael
> > -DSQLITE_ENABLE_COLUMN_METADATA \
> > -DSQLITE_ENABLE_FTS3 \
> > -DSQLITE_ENABLE_RTREE=1 \
> > -DSQLITE_ENABLE_UNLOCK_NOTIFY \
> > - -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1\
> > + -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1 \
> > -DSQLITE_OMIT_LOOKASIDE=1 \
> > -DSQLITE_SECURE_DELETE \
> > -DSQLITE_SOUNDEX=1 \
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] PATCH: Fix sqlite conf environment
2013-01-03 14:38 ` Michael Olbrich
@ 2013-01-04 14:59 ` Kirill Smirnov
0 siblings, 0 replies; 4+ messages in thread
From: Kirill Smirnov @ 2013-01-04 14:59 UTC (permalink / raw)
To: ptxdist
>>> Otherwise configure script cannot find external libraries and headers
>>> (such as readline).
>
> Interresting, the CROSS_ENV part is definitively correct, but I'm not sure,
> why you're getting this error and I don't.
>
Hmm... That's strange. I've just rebuilt my project with the latest
vanilla ptxdist snapshot and there is no error, libreadline is correctly
detected by sqlite.
But the bug is definitely present in version 2012.09.0, double-checked
that. It seems something has been changed elsewhere - I tried to
understand why it works now but failed. So I believe there is no need to
improve the patch any further.
--
Kirill
>>> diff --git a/rules/sqlite.make b/rules/sqlite.make
>>> index 0ff4c86..25ff3b7 100644
>>> --- a/rules/sqlite.make
>>> +++ b/rules/sqlite.make
>>> @@ -34,12 +34,13 @@ SQLITE_LICENSE := public_domain
>>> # ----------------------------------------------------------------------------
>>
>>> SQLITE_CONF_ENV := \
>>> - CPPFLAGS=" \
>>> + $(CROSS_ENV) \
>
> This looks ok.
>
>>> + CPPFLAGS="$(CROSS_CPPFLAGS) \
>
> With the latest changes to ptxdist CROSS_CPPFLAGS is now empty, so this is
> not needed any more.
>
> Michael
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-04 14:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-20 22:07 [ptxdist] PATCH: Fix sqlite conf environment Kirill Smirnov
2012-12-08 0:22 ` Kirill Smirnov
2013-01-03 14:38 ` Michael Olbrich
2013-01-04 14:59 ` Kirill Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox