From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from star.math.spbu.ru ([195.19.226.178])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <kirill.k.smirnov@math.spbu.ru>) id 1Tr8kP-0002z2-R8
	for ptxdist@pengutronix.de; Fri, 04 Jan 2013 15:59:51 +0100
Received: from LocalMailer (localhost.math.spbu.ru [127.0.0.1])
	by star.math.spbu.ru (8.14.3/8.14.3) with ESMTP id r04ExicB055566
	for <ptxdist@pengutronix.de>; Fri, 4 Jan 2013 18:59:47 +0400 (GMT-4)
	(envelope-from kirill.k.smirnov@math.spbu.ru)
Received: from [10.10.13.146] ([10.10.13.146])
	by LocalMailer (8.14.3/8.14.3) with ESMTP id r04Exi5Q055563
	for <ptxdist@pengutronix.de>; Fri, 4 Jan 2013 18:59:44 +0400 (GMT-4)
	(envelope-from kirill.k.smirnov@math.spbu.ru)
Message-ID: <50E6EE5E.3050800@math.spbu.ru>
Date: Fri, 04 Jan 2013 18:59:42 +0400
From: Kirill Smirnov <kirill.k.smirnov@math.spbu.ru>
MIME-Version: 1.0
References: <50ABFF10.9090103@math.spbu.ru> <50C28843.4040505@math.spbu.ru>
	<20130103143800.GD23783@pengutronix.de>
In-Reply-To: <20130103143800.GD23783@pengutronix.de>
Subject: Re: [ptxdist] PATCH: Fix sqlite conf environment
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

>>> Otherwise configure script cannot find external libraries and headers
>>> (such as readline).
>
> Interresting, the CROSS_ENV part is definitively correct, but I'm not sure,
> why you're getting this error and I don't.
>

Hmm... That's strange. I've just rebuilt my project with the latest 
vanilla ptxdist snapshot and there is no error, libreadline is correctly 
detected by sqlite.

But the bug is definitely present in version 2012.09.0, double-checked 
that. It seems something has been changed elsewhere - I tried to 
understand why it works now but failed. So I believe there is no need to 
improve the patch any further.

--
Kirill

>>> diff --git a/rules/sqlite.make b/rules/sqlite.make
>>> index 0ff4c86..25ff3b7 100644
>>> --- a/rules/sqlite.make
>>> +++ b/rules/sqlite.make
>>> @@ -34,12 +34,13 @@ SQLITE_LICENSE	:= public_domain
>>>   # ----------------------------------------------------------------------------
>>
>>>   SQLITE_CONF_ENV := \
>>> -	CPPFLAGS=" \
>>> +	$(CROSS_ENV) \
>
> This looks ok.
>
>>> +	CPPFLAGS="$(CROSS_CPPFLAGS) \
>
> With the latest changes to ptxdist CROSS_CPPFLAGS is now empty, so this is
> not needed any more.
>
> Michael


-- 
ptxdist mailing list
ptxdist@pengutronix.de