From: Kirill Smirnov <kirill.k.smirnov@math.spbu.ru>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] PATCH: Fix sqlite conf environment
Date: Fri, 04 Jan 2013 18:59:42 +0400 [thread overview]
Message-ID: <50E6EE5E.3050800@math.spbu.ru> (raw)
In-Reply-To: <20130103143800.GD23783@pengutronix.de>
>>> Otherwise configure script cannot find external libraries and headers
>>> (such as readline).
>
> Interresting, the CROSS_ENV part is definitively correct, but I'm not sure,
> why you're getting this error and I don't.
>
Hmm... That's strange. I've just rebuilt my project with the latest
vanilla ptxdist snapshot and there is no error, libreadline is correctly
detected by sqlite.
But the bug is definitely present in version 2012.09.0, double-checked
that. It seems something has been changed elsewhere - I tried to
understand why it works now but failed. So I believe there is no need to
improve the patch any further.
--
Kirill
>>> diff --git a/rules/sqlite.make b/rules/sqlite.make
>>> index 0ff4c86..25ff3b7 100644
>>> --- a/rules/sqlite.make
>>> +++ b/rules/sqlite.make
>>> @@ -34,12 +34,13 @@ SQLITE_LICENSE := public_domain
>>> # ----------------------------------------------------------------------------
>>
>>> SQLITE_CONF_ENV := \
>>> - CPPFLAGS=" \
>>> + $(CROSS_ENV) \
>
> This looks ok.
>
>>> + CPPFLAGS="$(CROSS_CPPFLAGS) \
>
> With the latest changes to ptxdist CROSS_CPPFLAGS is now empty, so this is
> not needed any more.
>
> Michael
--
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2013-01-04 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 22:07 Kirill Smirnov
2012-12-08 0:22 ` Kirill Smirnov
2013-01-03 14:38 ` Michael Olbrich
2013-01-04 14:59 ` Kirill Smirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E6EE5E.3050800@math.spbu.ru \
--to=kirill.k.smirnov@math.spbu.ru \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox