From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
References: <20200212164033.7362-1-a.fatoum@pengutronix.de>
 <CABDcavZM6cGP_pKuP5vncYR-=HiP9a2c0iCkS=3dL5WVSKVeOw@mail.gmail.com>
 <c709756e-d494-b9a7-e575-199b70bdbd1c@pengutronix.de>
 <CABDcavb2owcSee=QDgkJo2iJcRKCRTNOh6HCu9xTkJFWhzYtMw@mail.gmail.com>
 <300df1f4-4c3f-0511-a726-19376db749ac@pengutronix.de>
 <935c99ac-5b70-8d24-f84a-48af6d58cb2a@pengutronix.de>
 <CABDcavYXmV0PAW3iV1-dw3Y=jC5AiqCm9+UHWqxi4pzufCyeAw@mail.gmail.com>
 <fb284ae2-7c9b-5d2f-2097-643293aae97f@pengutronix.de>
 <CABDcavZDhO7y=+a_aRPkBJSsy83QPoZGEa31St7EnSP+s-xrXw@mail.gmail.com>
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Message-ID: <4b8670c9-cfde-4be2-16d5-02355fddde87@pengutronix.de>
Date: Thu, 13 Feb 2020 16:08:50 +0100
MIME-Version: 1.0
In-Reply-To: <CABDcavZDhO7y=+a_aRPkBJSsy83QPoZGEa31St7EnSP+s-xrXw@mail.gmail.com>
Content-Language: en-US
Subject: Re: [ptxdist] [PATCH v2] tf-a: new package for ARM trusted firmware
 A
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
Cc: Alejandro Vazquez <avazquez.dev@gmail.com>, ptxdist@pengutronix.de

On 2/13/20 4:05 PM, Guillermo Rodriguez Garcia wrote:

>>>>>
>>>>>>>>> +# ----------------------------------------------------------------------------
>>>>>>>>> +# Install
>>>>>>>>> +# ----------------------------------------------------------------------------
>>>>>>>>> +
>>>>>>>>> +$(STATEDIR)/tf-a.install:
>>>>>>>>> +       @$(call targetinfo)
>>>>>>>>> +ifeq ($(TF_A_ARTIFACTS_SRC),)
>>>>>>>>> +       $(warning TF_A_ARTIFACTS is empty. nothing to install.)
>>>>>>>>> +else
>>>>>>>>> +       @install -m644 -D \
>>>>>>>>> +               --target-directory=$(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware \
>>>>>>>>

> OK this makes sense.
> 
> But, you should at least make sure
> $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware exists before trying to
> copy anything into it.

That's why -D is there. From man install(1):

-D     create all leading components of DEST except the last, or all components of
	--target-directory, then copy SOURCE to DEST

Cheers
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de