* [ptxdist] [PATCH v2] util-linux-ng: Upgrade from v2.31.1 to v2.32
@ 2018-03-26 6:21 Alexander Dahl
2018-03-26 8:04 ` Roland Hieber
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Dahl @ 2018-03-26 6:21 UTC (permalink / raw)
To: ptxdist
Disable option for compilation with Address Sanitizer. Moved patch
series.
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
v1 -> v2: also move patch series
---
.../0001-__progname-redefinition-fix.patch | 2 +-
patches/{util-linux-2.31.1 => util-linux-2.32}/series | 0
rules/util-linux-ng.make | 5 +++--
3 files changed, 4 insertions(+), 3 deletions(-)
rename patches/{util-linux-2.31.1 => util-linux-2.32}/0001-__progname-redefinition-fix.patch (96%)
rename patches/{util-linux-2.31.1 => util-linux-2.32}/series (100%)
diff --git a/patches/util-linux-2.31.1/0001-__progname-redefinition-fix.patch b/patches/util-linux-2.32/0001-__progname-redefinition-fix.patch
similarity index 96%
rename from patches/util-linux-2.31.1/0001-__progname-redefinition-fix.patch
rename to patches/util-linux-2.32/0001-__progname-redefinition-fix.patch
index 4b7594fcb1..fbbc3080e9 100644
--- a/patches/util-linux-2.31.1/0001-__progname-redefinition-fix.patch
+++ b/patches/util-linux-2.32/0001-__progname-redefinition-fix.patch
@@ -16,7 +16,7 @@ Signed-off-by: Jon Ringle <jon@ringle.org>
2 files changed, 2 insertions(+)
diff --git a/libmount/src/cache.c b/libmount/src/cache.c
-index 6ff997140e06..40425b222825 100644
+index b52ca809801a..e65a1a23772e 100644
--- a/libmount/src/cache.c
+++ b/libmount/src/cache.c
@@ -23,6 +23,7 @@
diff --git a/patches/util-linux-2.31.1/series b/patches/util-linux-2.32/series
similarity index 100%
rename from patches/util-linux-2.31.1/series
rename to patches/util-linux-2.32/series
diff --git a/rules/util-linux-ng.make b/rules/util-linux-ng.make
index ed0f85c02e..0961c4c657 100644
--- a/rules/util-linux-ng.make
+++ b/rules/util-linux-ng.make
@@ -17,8 +17,8 @@ PACKAGES-$(PTXCONF_UTIL_LINUX_NG) += util-linux-ng
#
# Paths and names
#
-UTIL_LINUX_NG_VERSION := 2.31.1
-UTIL_LINUX_NG_MD5 := 7733b583dcb51518944d42aa62ef19ea
+UTIL_LINUX_NG_VERSION := 2.32
+UTIL_LINUX_NG_MD5 := e0d8a25853f88cd15ff557e5d8cb4ea7
UTIL_LINUX_NG := util-linux-$(UTIL_LINUX_NG_VERSION)
UTIL_LINUX_NG_SUFFIX := tar.xz
UTIL_LINUX_NG_BASENAME := v$(shell echo $(UTIL_LINUX_NG_VERSION) | sed -e 's/\([0-9]*\.[0-9]*\)[^0-9].*\?/\1/g')
@@ -52,6 +52,7 @@ UTIL_LINUX_NG_CONF_OPT := \
$(CROSS_AUTOCONF_USR) \
--bindir=/usr/bin \
--sbindir=/usr/sbin \
+ --disable-asan \
--enable-shared \
--disable-static \
--disable-gtk-doc \
--
2.11.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [ptxdist] [PATCH v2] util-linux-ng: Upgrade from v2.31.1 to v2.32
2018-03-26 6:21 [ptxdist] [PATCH v2] util-linux-ng: Upgrade from v2.31.1 to v2.32 Alexander Dahl
@ 2018-03-26 8:04 ` Roland Hieber
2018-03-26 8:07 ` Alexander Dahl
0 siblings, 1 reply; 4+ messages in thread
From: Roland Hieber @ 2018-03-26 8:04 UTC (permalink / raw)
To: ptxdist, Alexander Dahl
On 26.03.2018 08:21, Alexander Dahl wrote:
> Disable option for compilation with Address Sanitizer.
Hmm, why did you disable it? Seems a rather useful feature to me to have
by default :)
- Roland
> Moved patch
> series.
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
> v1 -> v2: also move patch series
> ---
> .../0001-__progname-redefinition-fix.patch | 2 +-
> patches/{util-linux-2.31.1 => util-linux-2.32}/series | 0
> rules/util-linux-ng.make | 5 +++--
> 3 files changed, 4 insertions(+), 3 deletions(-)
> rename patches/{util-linux-2.31.1 => util-linux-2.32}/0001-__progname-redefinition-fix.patch (96%)
> rename patches/{util-linux-2.31.1 => util-linux-2.32}/series (100%)
>
> diff --git a/patches/util-linux-2.31.1/0001-__progname-redefinition-fix.patch b/patches/util-linux-2.32/0001-__progname-redefinition-fix.patch
> similarity index 96%
> rename from patches/util-linux-2.31.1/0001-__progname-redefinition-fix.patch
> rename to patches/util-linux-2.32/0001-__progname-redefinition-fix.patch
> index 4b7594fcb1..fbbc3080e9 100644
> --- a/patches/util-linux-2.31.1/0001-__progname-redefinition-fix.patch
> +++ b/patches/util-linux-2.32/0001-__progname-redefinition-fix.patch
> @@ -16,7 +16,7 @@ Signed-off-by: Jon Ringle <jon@ringle.org>
> 2 files changed, 2 insertions(+)
>
> diff --git a/libmount/src/cache.c b/libmount/src/cache.c
> -index 6ff997140e06..40425b222825 100644
> +index b52ca809801a..e65a1a23772e 100644
> --- a/libmount/src/cache.c
> +++ b/libmount/src/cache.c
> @@ -23,6 +23,7 @@
> diff --git a/patches/util-linux-2.31.1/series b/patches/util-linux-2.32/series
> similarity index 100%
> rename from patches/util-linux-2.31.1/series
> rename to patches/util-linux-2.32/series
> diff --git a/rules/util-linux-ng.make b/rules/util-linux-ng.make
> index ed0f85c02e..0961c4c657 100644
> --- a/rules/util-linux-ng.make
> +++ b/rules/util-linux-ng.make
> @@ -17,8 +17,8 @@ PACKAGES-$(PTXCONF_UTIL_LINUX_NG) += util-linux-ng
> #
> # Paths and names
> #
> -UTIL_LINUX_NG_VERSION := 2.31.1
> -UTIL_LINUX_NG_MD5 := 7733b583dcb51518944d42aa62ef19ea
> +UTIL_LINUX_NG_VERSION := 2.32
> +UTIL_LINUX_NG_MD5 := e0d8a25853f88cd15ff557e5d8cb4ea7
> UTIL_LINUX_NG := util-linux-$(UTIL_LINUX_NG_VERSION)
> UTIL_LINUX_NG_SUFFIX := tar.xz
> UTIL_LINUX_NG_BASENAME := v$(shell echo $(UTIL_LINUX_NG_VERSION) | sed -e 's/\([0-9]*\.[0-9]*\)[^0-9].*\?/\1/g')
> @@ -52,6 +52,7 @@ UTIL_LINUX_NG_CONF_OPT := \
> $(CROSS_AUTOCONF_USR) \
> --bindir=/usr/bin \
> --sbindir=/usr/sbin \
> + --disable-asan \
> --enable-shared \
> --disable-static \
> --disable-gtk-doc \
>
--
Pengutronix e.K. | Roland Hieber |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [ptxdist] [PATCH v2] util-linux-ng: Upgrade from v2.31.1 to v2.32
2018-03-26 8:04 ` Roland Hieber
@ 2018-03-26 8:07 ` Alexander Dahl
2018-03-26 8:50 ` Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Dahl @ 2018-03-26 8:07 UTC (permalink / raw)
To: Roland Hieber; +Cc: ptxdist
Hello Roland,
Am Montag, 26. März 2018, 10:04:03 CEST schrieb Roland Hieber:
> On 26.03.2018 08:21, Alexander Dahl wrote:
> > Disable option for compilation with Address Sanitizer.
>
> Hmm, why did you disable it? Seems a rather useful feature to me to have
> by default :)
Two reasons:
* IIRC tools compiled with asan just terminate (and print why) if Address
Sanitizer detects something. This may not be what you want in production on
target.
* Other packages also disable that. See mariadb and krb5.
Greets
Alex
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH v2] util-linux-ng: Upgrade from v2.31.1 to v2.32
2018-03-26 8:07 ` Alexander Dahl
@ 2018-03-26 8:50 ` Michael Olbrich
0 siblings, 0 replies; 4+ messages in thread
From: Michael Olbrich @ 2018-03-26 8:50 UTC (permalink / raw)
To: ptxdist
Hi,
On Mon, Mar 26, 2018 at 10:07:41AM +0200, Alexander Dahl wrote:
> Am Montag, 26. März 2018, 10:04:03 CEST schrieb Roland Hieber:
> > On 26.03.2018 08:21, Alexander Dahl wrote:
> > > Disable option for compilation with Address Sanitizer.
> >
> > Hmm, why did you disable it? Seems a rather useful feature to me to have
> > by default :)
>
> Two reasons:
>
> * IIRC tools compiled with asan just terminate (and print why) if Address
> Sanitizer detects something. This may not be what you want in production on
> target.
>
> * Other packages also disable that. See mariadb and krb5.
That's because asan has a pretty big overhead. It's a debugging tool not a
hardening feature.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-26 8:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-26 6:21 [ptxdist] [PATCH v2] util-linux-ng: Upgrade from v2.31.1 to v2.32 Alexander Dahl
2018-03-26 8:04 ` Roland Hieber
2018-03-26 8:07 ` Alexander Dahl
2018-03-26 8:50 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox