From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from vps-1010511-3500.united-hoster.de ([81.20.132.56] helo=rohieb.name) by metis.ext.pengutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1bc3XX-0003wj-TK for ptxdist@pengutronix.de; Tue, 23 Aug 2016 06:42:20 +0200 Received: from [192.168.178.246] (p5DDFFDE5.dip0.t-ipconnect.de [93.223.253.229]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: rohieb@rohieb.name) by rohieb.name (Postfix) with ESMTPSA id 351D72595763 for ; Tue, 23 Aug 2016 06:41:49 +0200 (CEST) References: <1471445616-7728-1-git-send-email-rohieb@rohieb.name> <20160818065342.463fc7qfeixtb4vt@pengutronix.de> From: Roland Hieber Message-ID: <4a2ebe9f-e1e8-8bd5-b1dc-2ea5040cde7e@rohieb.name> Date: Tue, 23 Aug 2016 06:41:40 +0200 MIME-Version: 1.0 In-Reply-To: <20160818065342.463fc7qfeixtb4vt@pengutronix.de> Subject: Re: [ptxdist] [PATCH] ibrdtn: add packaging rules for IBR-DTN and dtndht List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============1530696753==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1530696753== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N773G7ibIbUk0UGMsfKWG1gS9keJUNxkS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N773G7ibIbUk0UGMsfKWG1gS9keJUNxkS Content-Type: multipart/mixed; boundary="MX4D4hIjf76essrWUkXDBcOojm3raRcI8" From: Roland Hieber To: ptxdist@pengutronix.de Message-ID: <4a2ebe9f-e1e8-8bd5-b1dc-2ea5040cde7e@rohieb.name> Subject: Re: [ptxdist] [PATCH] ibrdtn: add packaging rules for IBR-DTN and dtndht References: <1471445616-7728-1-git-send-email-rohieb@rohieb.name> <20160818065342.463fc7qfeixtb4vt@pengutronix.de> In-Reply-To: <20160818065342.463fc7qfeixtb4vt@pengutronix.de> --MX4D4hIjf76essrWUkXDBcOojm3raRcI8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 18.08.2016 08:53, Michael Olbrich wrote: > And check your configure options. You need to specify everything that i= s > optional or may be auto detected. Please look at some other rules for > guidance or ask me if you are unsure if an option should be specified. Uh, good point. Most of the --disable/--enable options seem to be built in a way that their state is autodetected, except when overwritten on the command line. But not for every --disable there is also a matching --enable (that would let the configure fail if things are wrong)! For example, in ibrcommon, only --disable-netlink really works and disables netlink support, but --enable-netlink also disables netlink support, because AC_ARG_ENABLE only checks for the existence of the --*-netlink switches, not for their actual value. [0] One could argue that configure (without --disable-netlink) will try to detect libnl3 and find it every time because it is listed as a dependency in the rules and is therefore built before ibrcommon. On the other hand, if things go wrong somehow, libnl3 could not be detected although it should be, and configure will not interpret that as a failure and happily build without netlink support. So it seems like a better solution to me if we patch those AC_ARG_ENABLE calls so they respect the actual value of the command line switch, like in [1]. Same applies e.g. for --enable-debug and --enable-gcov (no --disable-debug or --disable-gcov), and I didn't look into the other ibrdtn packages yet... [0]: https://github.com/ibrdtn/ibrdtn/blob/master/ibrcommon/configure.ac#L217 [1]: https://autotools.io/autoconf/arguments.html - Roland --MX4D4hIjf76essrWUkXDBcOojm3raRcI8-- --N773G7ibIbUk0UGMsfKWG1gS9keJUNxkS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXu9QGAAoJELJBPGbdLD/qDQkP/1zQpDtmH4fSCX9kM9DxbYlD ZKB9XnTbuRbcrfCChiAerGRqYPPExn9YUCPam9rBA79dBASY0YgPs+xlKAJQ2qDM CKWjApPAyUel1RO2ddlCtwxjrN9S+BHACGcoWrx28yPHaHNBEkw86hDBsbcJXW1q cwY/qj/DZ9UHav+qb/7FmeVE0eoV3kULkjwBnLKYkQuaAfE2kNOzGN7GSAJCQdWH +pBb3s1nkrpT1nAcm6ZPGtPZyaJ0kbnwjJTu4cw6ji0wACVAMXkj30G2XhXZZn5p 8vPJh2bc6kINp2Bg5Y8yx858N3fCqeO4W8LxI86meWSTNL8MoEWdm6kx9nJ0lomd hBtapHnvimndiVKhKzcjV0ApIzDsIUNJtu0J+r1nm2G7NhkbsPKbgu/ERl17NNcf obtGAhfchM4/pLfVgvUN2GYi1XMHLFhOV8VQFcvOeXXR5m9BNadRD2Cabld5shU6 4HUq+AtbBguXFwwSB4wAp8eHrughY5w5C2ym9Z1n4lzwugXSrRvfL9EcLx/sRFnB vF83NOmApURrNbOlrPVGHdqPoaT7k0fiB8zjYXbGj+ZDe3/yDCff0d/CgnqB7am9 dsaE/fw+MUIR78gq3i5xy2TPHj72gGnCe7iuW/f8lurAiH4i+GtTk+k60HivvSVl lx8vUdTcqv3IvU5C8Dab =pld0 -----END PGP SIGNATURE----- --N773G7ibIbUk0UGMsfKWG1gS9keJUNxkS-- --===============1530696753== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============1530696753==--