From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from moutng.kundenserver.de ([212.227.126.186]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1SbUU1-0005cP-5W for ptxdist@pengutronix.de; Mon, 04 Jun 2012 12:25:58 +0200 Received: from [192.168.102.103] (azuregos.2og.er.corscience.de [192.168.102.103]) by corscience.de (Postfix) with ESMTP id 3EF5C51F37 for ; Mon, 4 Jun 2012 12:25:51 +0200 (CEST) Message-ID: <4FCC8D30.4060307@corscience.de> Date: Mon, 04 Jun 2012 12:25:52 +0200 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= MIME-Version: 1.0 References: <1338478080-9393-1-git-send-email-biessmann@corscience.de> <20120604085932.GG25924@pengutronix.de> In-Reply-To: <20120604085932.GG25924@pengutronix.de> Subject: Re: [ptxdist] [PATCH] util-linux: fix hexsyntax.c for some systems Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Hi again, On 04.06.2012 10:59, Michael Olbrich wrote: > On Thu, May 31, 2012 at 05:28:00PM +0200, Andreas Bie=DFmann wrote: >> See patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.patch = for >> detailed description. > = > This occurs when building host-util-linux-ng on Mac OS, right? Please add= a > comment for this here. > = >> Signed-off-by: Andreas Bie=DFmann >> --- >> .../0004-text-utils-hexsyntax.c-use-c.h.patch | 32 +++++++++++++= +++++++ >> patches/util-linux-2.21.2/series | 3 +- >> 2 files changed, 34 insertions(+), 1 deletion(-) >> create mode 100644 patches/util-linux-2.21.2/0004-text-utils-hexsyntax.= c-use-c.h.patch >> >> diff --git a/patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c= .h.patch b/patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.pa= tch >> new file mode 100644 >> index 0000000..4084af3 >> --- /dev/null >> +++ b/patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.patch >> @@ -0,0 +1,32 @@ >> +From: =3D?UTF-8?q?Andreas=3D20Bie=3DC3=3D9Fmann?=3D >> +Date: Tue, 29 May 2012 09:51:24 +0200 >> +Subject: [PATCH] text-utils/hexsyntax.c: use c.h >> +MIME-Version: 1.0 >> +Content-Type: text/plain; charset=3DUTF-8 >> +Content-Transfer-Encoding: 8bit >> + >> +This patch hfixes following error for me: >> +---8<--- >> +hexsyntax.c: In function 'newsyntax': >> +hexsyntax.c:115: error: 'program_invocation_short_name' undeclared (fir= st use in this function) >> +hexsyntax.c:115: error: (Each undeclared identifier is reported only on= ce >> +hexsyntax.c:115: error: for each function it appears in.) >> +--->8--- > = > This can only happen if program_invocation_short_name is not defined by t= he > libc (probably glibc specific). Please add something like that to the > comment. > Otherwise, the patch might be removed later because it 'works'. sorry, did not read until the end. Well, util-linux-ng has some helper for program_invocation_short_name in its c.h. There are some different ways to get the current process name coded there. Unfortunately the current version miss to include the c.h in hexsyntax.c. The attached patch is also sent mainline and will hopefully applied soon. Therefore this patch can be removed here in future. best regards Andreas Bie=DFmann -- = ptxdist mailing list ptxdist@pengutronix.de