Re: [ptxdist] [PATCH] util-linux: fix hexsyntax.c for some systems

["Andreas Bießmann" <biessmann@corscience.de>]

Hi again,

On 04.06.2012 10:59, Michael Olbrich wrote:
> On Thu, May 31, 2012 at 05:28:00PM +0200, Andreas Bießmann wrote:
>> See patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.patch for
>> detailed description.
> 
> This occurs when building host-util-linux-ng on Mac OS, right? Please add a
> comment for this here.
> 
>> Signed-off-by: Andreas Bießmann <biessmann@corscience.de>
>> ---
>>  .../0004-text-utils-hexsyntax.c-use-c.h.patch      |   32 ++++++++++++++++++++
>>  patches/util-linux-2.21.2/series                   |    3 +-
>>  2 files changed, 34 insertions(+), 1 deletion(-)
>>  create mode 100644 patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.patch
>>
>> diff --git a/patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.patch b/patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.patch
>> new file mode 100644
>> index 0000000..4084af3
>> --- /dev/null
>> +++ b/patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.patch
>> @@ -0,0 +1,32 @@
>> +From: =?UTF-8?q?Andreas=20Bie=C3=9Fmann?= <biessmann@corscience.de>
>> +Date: Tue, 29 May 2012 09:51:24 +0200
>> +Subject: [PATCH] text-utils/hexsyntax.c: use c.h
>> +MIME-Version: 1.0
>> +Content-Type: text/plain; charset=UTF-8
>> +Content-Transfer-Encoding: 8bit
>> +
>> +This patch hfixes following error for me:
>> +---8<---
>> +hexsyntax.c: In function 'newsyntax':
>> +hexsyntax.c:115: error: 'program_invocation_short_name' undeclared (first use in this function)
>> +hexsyntax.c:115: error: (Each undeclared identifier is reported only once
>> +hexsyntax.c:115: error: for each function it appears in.)
>> +--->8---
> 
> This can only happen if program_invocation_short_name is not defined by the
> libc (probably glibc specific). Please add something like that to the
> comment.
> Otherwise, the patch might be removed later because it 'works'.

sorry, did not read until the end.

Well, util-linux-ng has some helper for program_invocation_short_name in
its c.h. There are some different ways to get the current process name
coded there.
Unfortunately the current version miss to include the c.h in
hexsyntax.c. The attached patch is also sent mainline and will hopefully
applied soon. Therefore this patch can be removed here in future.

best regards

Andreas Bießmann

-- 
ptxdist mailing list
ptxdist@pengutronix.de