From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from gallifrey.ext.pengutronix.de
	([2001:6f8:1178:4:5054:ff:fe8d:eefb] helo=[127.0.0.1])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mkl@pengutronix.de>) id 1RamhN-0001P4-5f
	for ptxdist@pengutronix.de; Wed, 14 Dec 2011 12:08:33 +0100
Message-ID: <4EE883AC.7080501@pengutronix.de>
Date: Wed, 14 Dec 2011 12:08:28 +0100
From: Marc Kleine-Budde <mkl@pengutronix.de>
MIME-Version: 1.0
References: <1323817619-69036-1-git-send-email-andreas@biessmann.de>
	<20111214105134.GI15788@pengutronix.de>
In-Reply-To: <20111214105134.GI15788@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] setlocalversion: use /bin/bash explicitly
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============0110957055=="
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--===============0110957055==
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig3B957EECA7B9F691BF1B0055"

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig3B957EECA7B9F691BF1B0055
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 12/14/2011 11:51 AM, Michael Olbrich wrote:
> On Wed, Dec 14, 2011 at 12:06:59AM +0100, Andreas Bie=DFmann wrote:
>> Using /bin/sh in setlocalversion lead to corrupted $PTXDIST_VERSION_FU=
LL
>> cause the 'echo -n "$v"' will use the builtin echo which does not know=

>> about -n switch.
>=20
> Hmmm, I think we could just drop the '-n'.
>=20
> Marc: this is your code, what do you think.

We could use printf instead. I'm not sure what happens, when we have a
trailing newline in the version information.

Marc
--=20
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


--------------enig3B957EECA7B9F691BF1B0055
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7og68ACgkQjTAFq1RaXHOkWgCgga0QWhFzHhDqWy234ngJny90
7BgAn0McUrDGMcnHCTptAXrF1sAcIt+c
=1jFr
-----END PGP SIGNATURE-----

--------------enig3B957EECA7B9F691BF1B0055--


--===============0110957055==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-- 
ptxdist mailing list
ptxdist@pengutronix.de

--===============0110957055==--