mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] setlocalversion: use /bin/bash explicitly
Date: Wed, 14 Dec 2011 12:08:28 +0100	[thread overview]
Message-ID: <4EE883AC.7080501@pengutronix.de> (raw)
In-Reply-To: <20111214105134.GI15788@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 794 bytes --]

On 12/14/2011 11:51 AM, Michael Olbrich wrote:
> On Wed, Dec 14, 2011 at 12:06:59AM +0100, Andreas Bießmann wrote:
>> Using /bin/sh in setlocalversion lead to corrupted $PTXDIST_VERSION_FULL
>> cause the 'echo -n "$v"' will use the builtin echo which does not know
>> about -n switch.
> 
> Hmmm, I think we could just drop the '-n'.
> 
> Marc: this is your code, what do you think.

We could use printf instead. I'm not sure what happens, when we have a
trailing newline in the version information.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2011-12-14 11:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13 23:06 Andreas Bießmann
2011-12-14 10:51 ` Michael Olbrich
2011-12-14 11:08   ` Marc Kleine-Budde [this message]
2011-12-14 11:20     ` Michael Olbrich
2011-12-16 18:18 ` [ptxdist] [PATCH v2] setlocalversion: replace echo -n with printf Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE883AC.7080501@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox