From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay05.ispgateway.de ([80.67.31.93]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1RGbFV-0004ah-GU for ptxdist@pengutronix.de; Wed, 19 Oct 2011 20:52:22 +0200 Received: from [93.104.153.97] (helo=[192.168.0.20]) by smtprelay05.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1RGbFV-0005oC-3H for ptxdist@pengutronix.de; Wed, 19 Oct 2011 20:52:21 +0200 Message-ID: <4E9F1C64.6040604@bwalle.de> Date: Wed, 19 Oct 2011 20:52:20 +0200 From: Bernhard Walle MIME-Version: 1.0 References: <1318893704-23961-1-git-send-email-jon@ringle.org> <20111019174624.GN7130@pengutronix.de> In-Reply-To: <20111019174624.GN7130@pengutronix.de> Subject: Re: [ptxdist] [PATCH] ptxd_ipkg_rev_smaller: fix compare with empty micro Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Am 19.10.2011 19:46, schrieb Robert Schwebel: > On Tue, Oct 18, 2011 at 04:42:46AM -0400, Jon Ringle wrote: >> After more testing, I found that there were other situations where the version >> comparison does not work well. >> >> I ended up replacing the implementation of ptxd_ipkg_rev_smaller() with >> something much simpler, albeit dependent on dpkg that seems to work well: >> >> ptxd_ipkg_rev_smaller() { >> dpkg --compare-versions $1 lt $2 >> } > > Hmm, that makes us dependend on dpkg (and thus on Debian). PTXdist tries > hard to run on any distribution, so I'm not happy with this. Maybe Perl would be okay? http://www.emdebian.org/trac/browser/current/target/dpkg/trunk/scripts/Dpkg/Version.pm?rev=6998 Seems to be quite official, and the Dpkg::ErrorHandling and Dpkg::Gettext could be easily removed. Regards, Bernhard -- ptxdist mailing list ptxdist@pengutronix.de