From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 16 Sep 2022 09:13:03 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oZ5X5-006QMd-4g for lore@lore.pengutronix.de; Fri, 16 Sep 2022 09:13:03 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oZ5X3-0001qV-Mk; Fri, 16 Sep 2022 09:13:01 +0200 Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ5WQ-0001qI-Mf; Fri, 16 Sep 2022 09:12:23 +0200 From: Alexander Dahl To: ptxdist@pengutronix.de Date: Fri, 16 Sep 2022 09:12:20 +0200 Message-ID: <4843812.ST7Gozo1Tx@ada> In-Reply-To: <20220902102130.29131-1-ada@thorsis.com> References: <20220902102130.29131-1-ada@thorsis.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Clacks-Overhead: GNU Terry Pratchett X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_PASS, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v3] libzmq: Add some conf env variables not automatically detected X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Michael Olbrich Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hei hei, Am Freitag, 2. September 2022, 12:21:30 CEST schrieb Alexander Dahl: > Follow up to the discussion on the last version bump. > zmq does not (try to) detect these features when cross compiling, > so we must assist. > Output of prepare stage contains this now: >=20 > checking whether EFD_CLOEXEC is supported... (cached) yes > =E2=80=A6 > checking whether SOCK_CLOEXEC is supported... (cached) yes > checking whether O_CLOEXEC is supported... (cached) yes > checking whether SO_BINDTODEVICE is supported... (cached) yes > checking whether SO_KEEPALIVE is supported... (cached) yes > checking whether TCP_KEEPCNT is supported... (cached) yes > checking whether TCP_KEEPIDLE is supported... (cached) yes > checking whether TCP_KEEPINTVL is supported... (cached) yes > checking whether TCP_KEEPALIVE is supported... not during cross-compi= le > checking whether SO_PRIORITY is supported... (cached) yes > checking whether getrandom is supported... (cached) yes >=20 > Link: > https://lore.ptxdist.org/ptxdist/20220708151537.GK20240@pengutronix.de/T/= #m > 9b6e02442a30b09d25fe98258051ebd34ee4f94b Signed-off-by: Alexander Dahl > > --- >=20 > Notes: > v3: > - Added s-o-b ping? Greets Alex >=20 > v2: > - also enable getrandom(2) > - reorganize comments to reflect glibc follows kernel, > so years are not swapped >=20 > rules/libzmq.make | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) >=20 > diff --git a/rules/libzmq.make b/rules/libzmq.make > index d221ef6ac..94a5f84d8 100644 > --- a/rules/libzmq.make > +++ b/rules/libzmq.make > @@ -34,6 +34,30 @@ LIBZMQ_CONF_ENV :=3D \ > $(CROSS_ENV) \ > ac_cv_lib_sodium_sodium_init=3Dno >=20 > +# Assume these are always available: > +# - O_CLOEXEC (2007, kernel 2.6.23, glibc 2.7) > +# - EFD_CLOEXEC (2008, kernel 2.6.27, glibc 2.9) > +# - SOCK_CLOEXEC (2008, kernel 2.6.27, glibc 2.9) > +# - SO_BINDTODEVICE (2009, kernel 2.6.31) > +# - SO_KEEPALIVE (2009, kernel 2.6.31, glibc 1.x) > +# - SO_PRIORITY (2009, kernel 2.6.31) > +# - TCP_KEEPCNT (pre 2005/2013, pre kernel 2.6.12, glibc 2.18) > +# - TCP_KEEPIDLE (pre 2005/2013, pre kernel 2.6.12, glibc 2.18) > +# - TCP_KEEPINTVL (pre 2005/2013, pre kernel 2.6.12, glibc 2.18) > +# - getrandom (2014/2017, kernel 3.17, glibc 2.25) > +# Note: TCP_KEEPALIVE is not available in glibc/kernel. > +LIBZMQ_CONF_ENV +=3D \ > + libzmq_cv_o_cloexec=3Dyes \ > + libzmq_cv_efd_cloexec=3Dyes \ > + libzmq_cv_sock_cloexec=3Dyes \ > + libzmq_cv_so_bindtodevice=3Dyes \ > + libzmq_cv_so_keepalive=3Dyes \ > + libzmq_cv_so_priority=3Dyes \ > + libzmq_cv_tcp_keepcnt=3Dyes \ > + libzmq_cv_tcp_keepidle=3Dyes \ > + libzmq_cv_tcp_keepintvl=3Dyes \ > + libzmq_cv_getrandom=3Dyes > + > # > # autoconf > # >=20 > base-commit: 20275946c697076ca6f696276117daf08ca6f4d1