From: Bernhard Walle <bernhard@bwalle.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] ptxdist: check vendor for ct-ng toolchain
Date: Tue, 18 Mar 2014 10:07:36 +0100 [thread overview]
Message-ID: <480422b0110b4795448fed69277f72f9@bwalle.de> (raw)
In-Reply-To: <5325CC34.7090409@biessmann.de>
Hi,
since I'm also using ct-ng toolchains, I like that feature. However,
in my case CT_TOOLCHAIN_PKGVERSION was empty, so wouldn't it make sense
to add the line
[ -z "$vendor_is" ] && vendor_is=crosstool-NG
after
vendor_is=$(${ct_vendor_def} | sed -n -e 's/"//g' -e
's/^CT_TOOLCHAIN_PKGVERSION=//p')
(sorry, I don't have the original patch in my mail box).
From the ct-ng help text:
│ ┌── Toolchain ID string
─────────────────────────────────────────────────┐ │
│ │
│ │
│ │ CT_TOOLCHAIN_PKGVERSION:
│ │
│ │
│ │
│ │ Specify a string that identifies your package. You may
wish to include │ │
│ │ a build number or build date. This version string will be
included in │ │
│ │ the output of gcc --version, and also in binutils,
eglibc, gdb and │ │
│ │ gdbserver.
│ │
│ │
│ │
│ │ If this string is left empty, the actual package version
will be: │ │
│ │ "crosstool-NG ${CT_VERSION}"
│ │
│ │ Otherwise, it will be:
│ │
│ │ "crosstool-NG ${CT_VERSION} -
${CT_TOOLCHAIN_PKGVERSION}" │ │
│ │
│ │
│ │ This is passed to the configure flag --with-pkgversion.
│ │
│ │
│ │
│ │ Symbol: TOOLCHAIN_PKGVERSION [=]
│ │
│ │ Type : string
│ │
│ │ Prompt: Toolchain ID string
│ │
│ │ Defined at config/toolchain.in:73
│ │
│ │ Location:
│ │
│ │ -> Toolchain options
│ │
│ │
│ │
│ │
│ │
│ │
│ │
│ │ <OK>
│ │
│
└────────────────────────────────────────────────────────────────────────┘ │
Maybe it would be nice to include the version in the check, but the only
line
where I could find the version of ct-ng in ${TARGET}-ct-ng.config is the
header comment:
# crosstool-NG 1.19.0 Configuration
Don't know if it makes sense to parse that.
Regards,
Bernhard
Am 2014-03-16 17:07, schrieb Andreas Bießmann:
> On 20.02.14 14:28, Andreas Bießmann wrote:
>> Before the toolchain vendor check was dedicated to OSELAS.Toolchain.
>> This patch introduces this feature to a toolchain built with ct-ng.
>>
>> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
>>
>> ---
>> I know that Pengutronix develops and distributes OSELAS.Toolchain. I
>> switched
>> however for some targets to the ct-ng toolchain and found the really
>> useful
>> feature of toolchain versioning broken when using that other
>> toolchain. This
>> patch is hopefully even so accepted ;)
>>
>
> any comments?
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2014-03-18 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 13:28 Andreas Bießmann
2014-03-16 16:07 ` Andreas Bießmann
2014-03-18 9:07 ` Bernhard Walle [this message]
2014-03-18 15:13 ` Andreas Bießmann
2014-03-18 15:49 ` Michael Olbrich
2014-04-20 7:48 ` [ptxdist] [PATCH v2] " Andreas Bießmann
2014-04-21 8:51 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480422b0110b4795448fed69277f72f9@bwalle.de \
--to=bernhard@bwalle.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox