Re: [ptxdist] Using PTXdist on Mac OS

[Daniel Kriesten <daniel.kriesten@etit.tu-chemnitz.de>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1375 bytes --]

Hi,

Am 18.04.2012 um 10:29 schrieb Michael Olbrich:
>> [...]
>>> [...]
>>>> An other thing is xargs ... without the gnu version make distclean fails.
>>>> The solution is to symlink in .../lib/ptxdist-2012.04.0/bin/, too.
>>> 
>>> It's "make clean" actually and that will remove the relevant symlink.
>>> Would this work:
>> 
>> That one is already in ptxdist, after 2012.04:
>> 
>> http://git.pengutronix.de/?p=ptxdist.git;a=commit;h=394af1de808e6fc4c3cf921d36e1b1f887133eb7
> 
> Yes it's there, and calling "make clean" twice still breaks.
> 
>>> ------------------------------------------------------------------
>>> diff --git a/Makefile.in b/Makefile.in
>>> index 8382402..32784c8 100644
>>> --- a/Makefile.in
>>> +++ b/Makefile.in
>>> @@ -63,7 +63,7 @@ environment:
>>> 
>>> clean:
>>> 	@rm -f .done
>>> -	@find "$(abs_srcdir)/bin" -type l -print0 | xargs -r -0 rm
>>> +	@cd "$(abs_srcdir)/bin" && find -type l -print | xargs rm -f
>>> 	@$(MAKE) -C "$(abs_srcdir)/scripts/kconfig" clean
>> 
>> Maybe just -exec ? Maybe it is a bit slower? But see above.
> 
> I really don't care either way.

From my point of view removing -r and adding -f is a simple, but sufficient solution. I added the corresponding patch, along with a patch fixing a typo in configure.ac.

Regards,
	Daniel
-- 
Daniel Kriesten
http://www.die-kriestens.de

[-- Attachment #1.1.2: 0001-fix-typo-in-the-xargs-check.patch --]
[-- Type: application/octet-stream, Size: 868 bytes --]

From 1a40577500278fab95562e449f5e597e77d76f7d Mon Sep 17 00:00:00 2001
From: Daniel Kriesten <krid@tu-chemnitz.eu>
Date: Wed, 18 Apr 2012 11:46:53 +0200
Subject: [PATCH 1/2] fix typo in the xargs check

Signed-off-by: Daniel Kriesten <krid@tu-chemnitz.eu>
---
 configure.ac |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 44c2448..fbc6216 100755
--- a/configure.ac
+++ b/configure.ac
@@ -292,7 +292,7 @@ fi
 AC_MSG_CHECKING([if xargs -r works as expected])
 echo | ${XARGS} -r false
 if test $? -ne 0; then
-	AC_MSG_ERROR([xargs with "-r" support needed, please install GNU xargs (unsually located in the "findutils" package])
+	AC_MSG_ERROR([xargs with "-r" support needed, please install GNU xargs (usually located in the "findutils" package])
 fi
 AC_MSG_RESULT([ok])
 
-- 
1.7.10


[-- Attachment #1.1.3: 0002-Remove-r-from-call-to-xargs.patch --]
[-- Type: application/octet-stream, Size: 838 bytes --]

From 78bd4616dc8d05e6e26d9e4544478bd44262010a Mon Sep 17 00:00:00 2001
From: Daniel Kriesten <krid@tu-chemnitz.eu>
Date: Wed, 18 Apr 2012 11:47:35 +0200
Subject: [PATCH 2/2] Remove -r from call to xargs

The '-r' flag is a GNU extension. To enhance compatibility remove '-r'
and suppress error mesages using 'rm -f'.

Signed-off-by: Daniel Kriesten <krid@tu-chemnitz.eu>
---
 Makefile.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.in b/Makefile.in
index 8382402..1d7678e 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -63,7 +63,7 @@ environment:
 
 clean:
 	@rm -f .done
-	@find "$(abs_srcdir)/bin" -type l -print0 | xargs -r -0 rm
+	@find "$(abs_srcdir)/bin" -type l -print0 | xargs -0 rm -f
 	@$(MAKE) -C "$(abs_srcdir)/scripts/kconfig" clean
 
 dirty-check:
-- 
1.7.10


[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4964 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de