From: Alexander Dahl <post@lespocky.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] libmodbus3: add patch for fixing alignment problem on arm
Date: Tue, 19 Mar 2013 16:55:37 +0100 [thread overview]
Message-ID: <418cf186bf4178fef3675a181603dd34@idefix.lespocky.dyndns.org> (raw)
In-Reply-To: <20130319153256.GC30288@pengutronix.de>
Hei Michael,
Am 2013-03-19 16:32, schrieb Michael Olbrich:
> On Thu, Mar 14, 2013 at 01:16:36PM +0100, Alexander Dahl wrote:
>> We use -Wcast-align on ARMv5 platform and libmodbus3 sets -Werror
>> which leads to a failing build in one case. This patch fixes the
>> alignment problem. Upstream pull requested.
>
> Hmm, this is just unit test stuff, right? We don't actually need this.
Yes, I think so. The targetinstall rule does not install these binaries
anyway.
> Maybe we should do this instead:
>
> LIBMODBUS3_MAKE_OPT := -C src
> LIBMODBUS3_INSTALL_OPT := -C src install
My colleague removed 'tests' from Makefile.am, I don't know which one
would be the best choice.
Greets
Alex
--
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601 D1D5 8FBA 7744 CC87 10D0 ***
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2013-03-19 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 12:16 Alexander Dahl
2013-03-19 15:32 ` Michael Olbrich
2013-03-19 15:55 ` Alexander Dahl [this message]
2013-03-19 16:27 ` Michael Olbrich
2013-03-26 9:04 ` Alexander Dahl
2013-03-27 17:57 ` Michael Olbrich
2013-03-28 7:46 ` Alexander Dahl
2013-03-28 9:27 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418cf186bf4178fef3675a181603dd34@idefix.lespocky.dyndns.org \
--to=post@lespocky.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox