Re: [ptxdist] [PATCH v2] minicoredumper: New package

[Alexander Dahl <ada@thorsis.com>]

Hello Uwe,

found some minor issues, see below. Despite of that:

Tested-by: Alexander Dahl <ada@thorsis.com>

Greets
Alex

Am Dienstag, 14. August 2018, 18:15:39 CEST schrieb Uwe Kleine-König:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Changes since (implicit) v1, sent with Message-Id:
> 20180813145748.21019-1-u.kleine-koenig@pengutronix.de:
> 
>  - s/LGPG-2.1/LGPG-2.1/
>  - Add "AND" to MINICOREDUMPER_LICENSE
>  - Mention missing automatic registration as coredump helper in .in
>    instead of the commit log
>  - drop complete extract stage. The ptxdist defaults are fine enough.
> 
> Most of this was noticed by Roland, thanks
> 
> Best regards
> Uwe
> 
>  rules/minicoredumper.in   | 21 ++++++++++++
>  rules/minicoredumper.make | 69 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 90 insertions(+)
>  create mode 100644 rules/minicoredumper.in
>  create mode 100644 rules/minicoredumper.make
> 
> diff --git a/rules/minicoredumper.in b/rules/minicoredumper.in
> new file mode 100644
> index 000000000000..969be8210c88
> --- /dev/null
> +++ b/rules/minicoredumper.in
> @@ -0,0 +1,21 @@
> +## SECTION=shell_and_console
> +
> +config MINICOREDUMPER
> +	bool

Why not tristate?

> +	prompt "minicoredumper"
> +	select LIBELF
> +	select JSON_C
> +	help
> +	  The minicoredumper project provides a program that handles the
> +	  creation of core dump files on Linux. It can produce much smaller
> +	  core dump files by making use of sparse files, compression, and
> +	  allowing the user to configure what parts of the process memory image
> +	  should be dumped.
> +
> +	  Note that there are currently no mechnisms integrated to
> +	  automatically register minicoredumper as kernel coredump helper. So
> +	  you might want to do

s/mechnisms/mechanisms/

> +
> +	  	echo '|/usr/sbin/minicoredumper %P %u %g %s %t %h %e' >
> /proc/sys/kernel/core_pattern +
> +	  by hand to actually make use of it.
> diff --git a/rules/minicoredumper.make b/rules/minicoredumper.make
> new file mode 100644
> index 000000000000..948068b21c89
> --- /dev/null
> +++ b/rules/minicoredumper.make
> @@ -0,0 +1,69 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2018 by Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MINICOREDUMPER) += minicoredumper
> +
> +#
> +# Paths and names
> +#
> +MINICOREDUMPER_VERSION	:= 2.0.1
> +MINICOREDUMPER_MD5	:= 813b864e0c6a833d14bab244723de6a4
> +MINICOREDUMPER		:= minicoredumper-$(MINICOREDUMPER_VERSION)
> +MINICOREDUMPER_SUFFIX	:= tar.xz
> +MINICOREDUMPER_URL	:=
> https://linutronix.de/minicoredumper/files/$(MINICOREDUMPER).$(MINICOREDUMP
> ER_SUFFIX) +MINICOREDUMPER_SOURCE	:=
> $(SRCDIR)/$(MINICOREDUMPER).$(MINICOREDUMPER_SUFFIX) +MINICOREDUMPER_DIR	:=
> $(BUILDDIR)/$(MINICOREDUMPER)
> +MINICOREDUMPER_LICENSE	:= BSD AND LGPL-2.1
> +MINICOREDUMPER_LICENSE_FILES :=
> file://COPYING;md5=71827c617ec7b45a0dd23658347cc1e9 +
> +#
> ---------------------------------------------------------------------------
> - +# Prepare
> +#
> ---------------------------------------------------------------------------
> - +
> +MINICOREDUMPER_CONF_TOOL := autoconf
> +MINICOREDUMPER_CONF_OPT := \
> +	$(CROSS_AUTOCONF_USR) \
> +	--disable-silent-rules \
> +	--without-coreinject \
> +	--with-minicoredumper \
> +	--without-minicoredumper_regd \
> +	--without-minicoredumper_trigger \
> +	--without-libminicoredumper \
> +	--without-minicoredumper_demo \
> +	--without-werror \
> +
> +#
> ---------------------------------------------------------------------------
> - +# Target-Install
> +#
> ---------------------------------------------------------------------------
> - +
> +$(STATEDIR)/minicoredumper.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, minicoredumper)
> +	@$(call install_fixup, minicoredumper, PRIORITY, optional)
> +	@$(call install_fixup, minicoredumper, SECTION, base)
> +	@$(call install_fixup, minicoredumper, AUTHOR, "Uwe Kleine-Koenig
> <u.kleine-koenig@pengutronix.de>") +	@$(call install_fixup, 
minicoredumper,
> DESCRIPTION, missing)
> +
> +	@$(call install_copy, minicoredumper, 0, 0, 0755, -,
> /usr/sbin/minicoredumper) +
> +	@$(call install_alternative_tree, minicoredumper, 0, 0,
> /etc/minicoredumper) +
> +	@$(call install_copy, minicoredumper, 0, 0, 0755, /var/crash)
> +	@$(call install_copy, minicoredumper, 0, 0, 0755,
> /var/crash/minicoredumper) +
> +	@$(call install_finish, minicoredumper)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make



_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de