From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 30 Aug 2022 11:13:28 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>) id 1oSxJI-001YEz-RQ for lore@lore.pengutronix.de; Tue, 30 Aug 2022 11:13:28 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from <ptxdist-bounces@pengutronix.de>) id 1oSxJI-0004s9-2G; Tue, 30 Aug 2022 11:13:28 +0200 Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ada@thorsis.com>) id 1oSxJA-0004km-UH; Tue, 30 Aug 2022 11:13:21 +0200 From: Alexander Dahl <ada@thorsis.com> To: Michael Olbrich <m.olbrich@pengutronix.de> Date: Tue, 30 Aug 2022 11:13:18 +0200 Message-ID: <3924345.GDJjuhhGN4@ada> In-Reply-To: <Yw267NENa5VHhZuW@pengutronix.de> References: <20220826133537.1843791-1-christian.melki@t2data.com> <979bfe94-2c54-bba5-a1e9-4337f863f7b0@t2data.com> <Yw267NENa5VHhZuW@pengutronix.de> Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Clacks-Overhead: GNU Terry Pratchett X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 1/3] u-boot: Move u-boot URL to github. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de> List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe> List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/> List-Post: <mailto:ptxdist@pengutronix.de> List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help> List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, <mailto:ptxdist-request@pengutronix.de?subject=subscribe> Reply-To: ptxdist@pengutronix.de Cc: Christian Melki <christian.melki@t2data.com>, ptxdist@pengutronix.de Sender: "ptxdist" <ptxdist-bounces@pengutronix.de> X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hei hei, Am Dienstag, 30. August 2022, 09:23:24 CEST schrieb Michael Olbrich: > On Mon, Aug 29, 2022 at 06:57:03PM +0200, Christian Melki wrote: > > On 8/29/22 10:49, Alexander Dahl wrote: > > > Hello Christian, > > > > > > Am Freitag, 26. August 2022, 15:35:35 CEST schrieb Christian Melki: > > >> * Make URL configurable. Also. This aids in pointing > > >> ptxdist to various vendor specific releases. > > >> * Make compression format .tar.gz. Default > > >> github contains such releases for really old releases, > > >> so it should be fine. > > >> * Bump default version to something more recent. > > >> Just cosmetics really. > > > > > > What's the motivation for moving this to a mirror of the official > > > sources? > > > According to https://u-boot.readthedocs.io/en/latest/build/source.html > > > the > > > main and official forge is https://source.denx.de/u-boot/u-boot and > > > additionally https://ftp.denx.de/pub/u-boot/ still contains all release > > > tarballs up to the most recent RCs. This is also mentioned in the README > > > in > > > top level U-Boot source. > > > > > > Greets > > > Alex > > > > The point beeing similarity between various vendor releases and vanilla > > u-boot releases. But since the URL is configurable.. whichever really. > > Github API has the advantage of being able to tell you about new > > releases, should such a tool ever be adapted to ptxdist. > > Nack. Our u-boot package is already complex enough. I don't want to support > whatever vendors do in their downstream repositories as well. Please create > a local new package for that. I would be happy to accept a patch for a > template to make this easier. You might want to have a look at this (not merged) patch series again as a starting point: https://lore.ptxdist.org/ptxdist/20210826084842.21421-1-ada@thorsis.com/ Greets Alex > > Michael > > > I actually tried asking about github as an official source on irc, but > > nobody cared to answer. > > > > regards, > > C > > > > >> Signed-off-by: Christian Melki <christian.melki@t2data.com> > > >> --- > > >> > > >> platforms/u-boot.in | 11 +++++++++-- > > >> rules/u-boot.make | 4 ++-- > > >> 2 files changed, 11 insertions(+), 4 deletions(-) > > >> > > >> diff --git a/platforms/u-boot.in b/platforms/u-boot.in > > >> index 769237081..8c7931d13 100644 > > >> --- a/platforms/u-boot.in > > >> +++ b/platforms/u-boot.in > > >> @@ -9,13 +9,20 @@ menuconfig U_BOOT > > >> > > >> if U_BOOT > > >> > > >> +config U_BOOT_URL > > >> + string > > >> + default "https://github.com/u-boot/u-boot/releases/tag" > > >> + prompt "U-Boot URL" > > >> + help > > >> + Enter the U-Boot URL you want to use. > > >> + > > >> > > >> config U_BOOT_VERSION > > >> > > >> string > > >> > > >> - default "2019.01" > > >> + default "v2022.01" > > >> > > >> prompt "U-Boot version" > > >> help > > >> > > >> Enter the U-Boot version you want to build. Usually something like > > >> > > >> - "2019.01". > > >> + "v2022.01". > > >> > > >> config U_BOOT_MD5 > > >> > > >> string > > >> > > >> diff --git a/rules/u-boot.make b/rules/u-boot.make > > >> index cadca4a6b..1ba6d47b0 100644 > > >> --- a/rules/u-boot.make > > >> +++ b/rules/u-boot.make > > >> @@ -19,8 +19,8 @@ PACKAGES-$(PTXCONF_U_BOOT) += u-boot > > >> > > >> U_BOOT_VERSION := $(call ptx/config-version, PTXCONF_U_BOOT) > > >> U_BOOT_MD5 := $(call ptx/config-md5, PTXCONF_U_BOOT) > > >> U_BOOT := u-boot-$(U_BOOT_VERSION) > > >> > > >> -U_BOOT_SUFFIX := tar.bz2 > > >> -U_BOOT_URL := > > >> https://ftp.denx.de/pub/u-boot/$(U_BOOT).$(U_BOOT_SUFFIX) > > >> +U_BOOT_SUFFIX := tar.gz > > >> +U_BOOT_URL := > > >> $(PTXCONF_U_BOOT_URL)/$(U_BOOT_VERSION).$(U_BOOT_SUFFIX) > > >> > > >> U_BOOT_SOURCE := $(SRCDIR)/$(U_BOOT).$(U_BOOT_SUFFIX) > > >> U_BOOT_DIR := $(BUILDDIR)/$(U_BOOT) > > >> U_BOOT_BUILD_DIR := $(U_BOOT_DIR)$(call ptx/ifdef, > > >> > > >> PTXCONF_U_BOOT_BUILD_OOT,-build)