Re: [ptxdist] [PATCH 1/3] u-boot: Move u-boot URL to github.

[Alexander Dahl <ada@thorsis.com>]

Hei hei,

Am Dienstag, 30. August 2022, 09:23:24 CEST schrieb Michael Olbrich:
> On Mon, Aug 29, 2022 at 06:57:03PM +0200, Christian Melki wrote:
> > On 8/29/22 10:49, Alexander Dahl wrote:
> > > Hello Christian,
> > > 
> > > Am Freitag, 26. August 2022, 15:35:35 CEST schrieb Christian Melki:
> > >> * Make URL configurable. Also. This aids in pointing
> > >> ptxdist to various vendor specific releases.
> > >> * Make compression format .tar.gz. Default
> > >> github contains such releases for really old releases,
> > >> so it should be fine.
> > >> * Bump default version to something more recent.
> > >> Just cosmetics really.
> > > 
> > > What's the motivation for moving this to a mirror of the official
> > > sources?
> > > According to https://u-boot.readthedocs.io/en/latest/build/source.html
> > > the
> > > main and official forge is https://source.denx.de/u-boot/u-boot and
> > > additionally https://ftp.denx.de/pub/u-boot/ still contains all release
> > > tarballs up to the most recent RCs. This is also mentioned in the README
> > > in
> > > top level U-Boot source.
> > > 
> > > Greets
> > > Alex
> > 
> > The point beeing similarity between various vendor releases and vanilla
> > u-boot releases. But since the URL is configurable.. whichever really.
> > Github API has the advantage of being able to tell you about new
> > releases, should such a tool ever be adapted to ptxdist.
> 
> Nack. Our u-boot package is already complex enough. I don't want to support
> whatever vendors do in their downstream repositories as well. Please create
> a local new package for that. I would be happy to accept a patch for a
> template to make this easier.

You might want to have a look at this (not merged) patch series again as a 
starting point:

https://lore.ptxdist.org/ptxdist/20210826084842.21421-1-ada@thorsis.com/

Greets
Alex

> 
> Michael
> 
> > I actually tried asking about github as an official source on irc, but
> > nobody cared to answer.
> > 
> > regards,
> > C
> > 
> > >> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> > >> ---
> > >> 
> > >>  platforms/u-boot.in | 11 +++++++++--
> > >>  rules/u-boot.make   |  4 ++--
> > >>  2 files changed, 11 insertions(+), 4 deletions(-)
> > >> 
> > >> diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> > >> index 769237081..8c7931d13 100644
> > >> --- a/platforms/u-boot.in
> > >> +++ b/platforms/u-boot.in
> > >> @@ -9,13 +9,20 @@ menuconfig U_BOOT
> > >> 
> > >>  if U_BOOT
> > >> 
> > >> +config U_BOOT_URL
> > >> +	string
> > >> +	default "https://github.com/u-boot/u-boot/releases/tag"
> > >> +	prompt "U-Boot URL"
> > >> +	help
> > >> +	  Enter the U-Boot URL you want to use.
> > >> +
> > >> 
> > >>  config U_BOOT_VERSION
> > >>  
> > >>  	string
> > >> 
> > >> -	default "2019.01"
> > >> +	default "v2022.01"
> > >> 
> > >>  	prompt "U-Boot version"
> > >>  	help
> > >>  	
> > >>  	  Enter the U-Boot version you want to build. Usually something like
> > >> 
> > >> -	  "2019.01".
> > >> +	  "v2022.01".
> > >> 
> > >>  config U_BOOT_MD5
> > >>  
> > >>  	string
> > >> 
> > >> diff --git a/rules/u-boot.make b/rules/u-boot.make
> > >> index cadca4a6b..1ba6d47b0 100644
> > >> --- a/rules/u-boot.make
> > >> +++ b/rules/u-boot.make
> > >> @@ -19,8 +19,8 @@ PACKAGES-$(PTXCONF_U_BOOT) += u-boot
> > >> 
> > >>  U_BOOT_VERSION		:= $(call ptx/config-version, PTXCONF_U_BOOT)
> > >>  U_BOOT_MD5		:= $(call ptx/config-md5, PTXCONF_U_BOOT)
> > >>  U_BOOT			:= u-boot-$(U_BOOT_VERSION)
> > >> 
> > >> -U_BOOT_SUFFIX		:= tar.bz2
> > >> -U_BOOT_URL		:=
> > >> https://ftp.denx.de/pub/u-boot/$(U_BOOT).$(U_BOOT_SUFFIX)
> > >> +U_BOOT_SUFFIX		:= tar.gz
> > >> +U_BOOT_URL		:=
> > >> $(PTXCONF_U_BOOT_URL)/$(U_BOOT_VERSION).$(U_BOOT_SUFFIX)
> > >> 
> > >>  U_BOOT_SOURCE		:= $(SRCDIR)/$(U_BOOT).$(U_BOOT_SUFFIX)
> > >>  U_BOOT_DIR		:= $(BUILDDIR)/$(U_BOOT)
> > >>  U_BOOT_BUILD_DIR	:= $(U_BOOT_DIR)$(call ptx/ifdef,
> > >> 
> > >> PTXCONF_U_BOOT_BUILD_OOT,-build)